DPDK patches and discussions
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>
Subject: [dpdk-dev] [PATCH 0/6] remove unncessary void cast
Date: Wed, 23 Aug 2017 08:44:39 -0700	[thread overview]
Message-ID: <20170823154445.19494-1-stephen@networkplumber.org> (raw)

There are many places that cast away the return value from
rte_memcpy().  This was a common practice in the Unix BSD days because
lint would complain about unused return values, but it is not done
in modern Linux style because it clutters the code.

Maybe it was done for some Coverity warnings. If so, that issue
should be addressed with Coverity overrides not more code clutter.

Stephen Hemminger (6):
  testpmd: remove unnecessary void casts
  bnx2x: remove unnecssary void cast of rte_memcpy
  sfc: remove unnecessary cast of rte_memcpy
  e1000: remove unnecessary cast of rte_memcpy
  i40e: remove unnecessary cast of rte_memcpy
  ixgbe: remove unnecessary cast of rte_memcpy

 app/test-pmd/cmdline.c            | 14 +++++-----
 app/test-pmd/config.c             |  4 +--
 app/test-pmd/testpmd.c            |  2 +-
 drivers/net/bnx2x/bnx2x.c         |  6 ++---
 drivers/net/bnx2x/bnx2x.h         |  4 +--
 drivers/net/bnx2x/ecore_sp.h      |  2 +-
 drivers/net/e1000/igb_flow.c      |  8 +++---
 drivers/net/i40e/i40e_ethdev.c    | 54 +++++++++++++++++++--------------------
 drivers/net/i40e/i40e_ethdev_vf.c | 10 ++++----
 drivers/net/i40e/i40e_fdir.c      |  2 +-
 drivers/net/i40e/i40e_pf.c        |  2 +-
 drivers/net/i40e/i40e_tm.c        |  6 ++---
 drivers/net/i40e/rte_pmd_i40e.c   | 16 ++++++------
 drivers/net/ixgbe/ixgbe_ethdev.c  |  4 +--
 drivers/net/ixgbe/ixgbe_fdir.c    |  2 +-
 drivers/net/ixgbe/ixgbe_flow.c    | 20 +++++++--------
 drivers/net/ixgbe/ixgbe_tm.c      |  6 ++---
 drivers/net/sfc/sfc_ethdev.c      |  2 +-
 18 files changed, 82 insertions(+), 82 deletions(-)

-- 
2.11.0

             reply	other threads:[~2017-08-23 15:44 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-23 15:44 Stephen Hemminger [this message]
2017-08-23 15:44 ` [dpdk-dev] [PATCH 1/6] testpmd: remove unnecessary void casts Stephen Hemminger
2017-09-04 11:39   ` Rybalchenko, Kirill
2017-09-07  8:36   ` Wu, Jingjing
2017-09-11 12:44   ` Ferruh Yigit
2017-08-23 15:44 ` [dpdk-dev] [PATCH 2/6] bnx2x: remove unnecssary void cast of rte_memcpy Stephen Hemminger
2017-09-04 11:50   ` Rybalchenko, Kirill
2017-08-23 15:44 ` [dpdk-dev] [PATCH 3/6] sfc: remove unnecessary " Stephen Hemminger
2017-09-04 12:39   ` Rybalchenko, Kirill
2017-08-23 15:44 ` [dpdk-dev] [PATCH 4/6] e1000: " Stephen Hemminger
2017-09-04 12:40   ` Rybalchenko, Kirill
2017-08-23 15:44 ` [dpdk-dev] [PATCH 5/6] i40e: " Stephen Hemminger
2017-09-04 12:45   ` Rybalchenko, Kirill
2017-09-09  3:24   ` Wu, Jingjing
2017-08-23 15:44 ` [dpdk-dev] [PATCH 6/6] ixgbe: " Stephen Hemminger
2017-09-04 12:49   ` Rybalchenko, Kirill
2017-09-11 12:44 ` [dpdk-dev] [PATCH 0/6] remove unncessary void cast Ferruh Yigit
2017-09-11 13:32   ` Ferruh Yigit
2017-09-11 13:00 ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170823154445.19494-1-stephen@networkplumber.org \
    --to=stephen@networkplumber.org \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).