From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f179.google.com (mail-wr0-f179.google.com [209.85.128.179]) by dpdk.org (Postfix) with ESMTP id ADDB27CC0 for ; Thu, 24 Aug 2017 16:01:55 +0200 (CEST) Received: by mail-wr0-f179.google.com with SMTP id 6so2732071wrp.2 for ; Thu, 24 Aug 2017 07:01:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=mP4FVhIvRH9iN1tu2V+98LxqoIVA7MjCXrpz5SVYCvg=; b=TDaD6kD8LvqjbT94Dgni5KuOypjkfWO5nZ7MTVBcSrlFgvUrfw0FPBG04IqIaBN3ni QIbTXVBucbP/d639ZB2ra0Igwai2c8ZPjS8VrxkdkvJS7iwEDzvg+jPecSv4UlZlHRka LyqvJwHmw4PH4KnqaePVWSrhzkPHxTaChuFAxxrgUutRUJc1MG39AiBxxouE5L8YL1ID t/a8K3tFmK5h0tABie12zkA4/d68OSx/TdwMonWHMxHoBLLqd6skAIQnSs8Djw8NHE1R KRSE/pkSfDrKbcalAZbEOuLno0cLFZjv4FsrC1l9SGmSpJcjBWZpFH8fUZchwQflIuty +bTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=mP4FVhIvRH9iN1tu2V+98LxqoIVA7MjCXrpz5SVYCvg=; b=I4h2hgLmWKHyilL85qbKdnq0sB/XiM/9yUrYrLhj4/FZV7+5D5nu+fcPtAdcJx21dU SPDRhWDFNV5fjUkqyssADIbLrIqHKfTlJvw4VdRc1vZlmrUgPf6AyRjd+eblZqMRORtw 8QyrEyYy0q+xNxAs/Aeivp2j8Gzl8sBiuJ2lLUxmo/QptEBUOQO183A9FNwmtuHal9Hg 20kJcd2ptlEvBfcb+YRI7BQk4QLqZIAwU4W4X7A+IgHhADnh8BBPHQAbvSrPl3UzFI75 ar+gTfOBCccf5lVMQLdDFpsCRaSLD5zRZJX3vwU5VhXduCTgnmj+KW20SSMb390UoRnI 17kg== X-Gm-Message-State: AHYfb5jxG6doRyaj2Z9bZGBCVImhfQJL94Rtj5paoHO1rHk7tftn4rp3 nxh7jMJTSagazGG8 X-Received: by 10.223.131.102 with SMTP id 93mr3589205wrd.54.1503583314731; Thu, 24 Aug 2017 07:01:54 -0700 (PDT) Received: from autoinstall.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id c9sm3266099wrd.54.2017.08.24.07.01.53 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 24 Aug 2017 07:01:54 -0700 (PDT) Date: Thu, 24 Aug 2017 16:01:45 +0200 From: =?iso-8859-1?Q?N=E9lio?= Laranjeiro To: Raslan Darawsheh Cc: thomas@monjalon.net, jingjing.wu@intel.com, dev@dpdk.org, adrien.mazarguil@6wind.com Message-ID: <20170824140144.GN4544@autoinstall.dev.6wind.com> References: <1503409570-9946-3-git-send-email-rasland@mellanox.com> <1503560793-21597-1-git-send-email-rasland@mellanox.com> <1503560793-21597-3-git-send-email-rasland@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1503560793-21597-3-git-send-email-rasland@mellanox.com> User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH v2 3/3] net/mlx5: add hardware timestamp X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Aug 2017 14:01:55 -0000 On Thu, Aug 24, 2017 at 10:46:33AM +0300, Raslan Darawsheh wrote: > Expose a new capapilty of Rx hw timestamp and > added new device args to enable it hw_timestamp. > It will add the raw hw timestamp into the packets. > > Its expected that it will lower down the performance since using it > will disable the cqe comprission, and will add extra checkes in > the vec rx path. > > Signed-off-by: Raslan Darawsheh > --- > doc/guides/nics/mlx5.rst | 5 +++++ > drivers/net/mlx5/mlx5.c | 23 +++++++++++++++++++++++ > drivers/net/mlx5/mlx5.h | 1 + > drivers/net/mlx5/mlx5_ethdev.c | 3 ++- > drivers/net/mlx5/mlx5_rxq.c | 3 +++ > drivers/net/mlx5/mlx5_rxtx.c | 5 +++++ > drivers/net/mlx5/mlx5_rxtx.h | 3 ++- > drivers/net/mlx5/mlx5_rxtx_vec_sse.c | 13 ++++++++++++- > 8 files changed, 53 insertions(+), 3 deletions(-) It is strange to enable/disable this single offload again the application request. Why do you need such behavior? Another point I don't seen any code to retrieve this offloads request from the port configuration as for the others. It is expected in the new revision? Thanks, -- Nélio Laranjeiro 6WIND