From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f43.google.com (mail-wm0-f43.google.com [74.125.82.43]) by dpdk.org (Postfix) with ESMTP id 679947D13 for ; Thu, 24 Aug 2017 17:09:07 +0200 (CEST) Received: by mail-wm0-f43.google.com with SMTP id x128so6993216wmg.1 for ; Thu, 24 Aug 2017 08:09:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=PPz0b8rglqEYUbMVRllHSY/Nt45r+gDiulYfMwIQRMU=; b=J309qz3/33Tpnx47BIHBaHIwM0p6at34t5llPBMRU0r+VRn8qTdpLaM2TpDizMxzej LfAU9bOfvHbKAv5qL8TIP6giURAlkCQV2vvG4jxi7Dl8y9oPBqHFZWxpQw/iIhpOTyWa 7VoOSm76nLX64q/V0wyl4QnaEQXM09VcBnb3u8DTINjiwGrWimjOQmLuLqiBvNKAYIr2 Y/rvGQHcDx8x1Q6ck8dY36+lNYGgRx2VHuD/Ln243IHyUU0JyUcrWRxNwmXw2RladkId itTcnPgCNPI4B58J+zSjlz6aLtJtA5qEudE117Va+C9Uk7+5qWaKxv+o87inJSa8JABK S98w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=PPz0b8rglqEYUbMVRllHSY/Nt45r+gDiulYfMwIQRMU=; b=CO8qznJRo4BqeEW5p0VNAMFYe0cBLiVHbGgq0Ok7gZy/NevQwK5r5MNcdMuWqu9uee v7no8FDxKBd0vCOirIvBaRpwNi8rWQZZUmwDjeKc8rASBwy1rsPBAxdQFSCGNIkBM8Fx VaFjT0d40JdaVrF3c/dJAIVVYtU06cXro5shiH49cSduO6hjsNn0MoQ9JTD1WFrkyE3G zSYLOrBdJ1J1J4l6qanK5SN0PNYXN8P7HeCwFhbx+ZPVyRvokfgLdDOqKKSx8GBiNe3C +5KYqth2vgTXSx7bKB1bqSDnvQR1M5YLvHSSwN19N6+jyxgWUaDqnIchsUAS7ROUo1/+ q+Iw== X-Gm-Message-State: AHYfb5jPl3oYS8PqjvGN6HbWWvwwR11ytdyw2z14uusmCOGOIqtjHFRr UOFEGTMmy8qVcO+h X-Received: by 10.28.31.149 with SMTP id f143mr3567946wmf.149.1503587347298; Thu, 24 Aug 2017 08:09:07 -0700 (PDT) Received: from autoinstall.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id v17sm3146852wrg.24.2017.08.24.08.09.06 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 24 Aug 2017 08:09:06 -0700 (PDT) Date: Thu, 24 Aug 2017 17:08:57 +0200 From: =?iso-8859-1?Q?N=E9lio?= Laranjeiro To: Ori Kam Cc: "adrien.mazaruil@6wind.com" , "dev@dpdk.org" Message-ID: <20170824150857.GP4544@autoinstall.dev.6wind.com> References: <1503318941-42015-1-git-send-email-orika@mellanox.com> <20170824065419.GH12995@autoinstall.dev.6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [RFC] net/mlx5: support count flow action X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Aug 2017 15:09:08 -0000 Hi Ori, On Thu, Aug 24, 2017 at 02:04:32PM +0000, Ori Kam wrote: > Hi Nelio, > > Please see my comments in line. > > Ori > > > -----Original Message----- > > From: Nélio Laranjeiro [mailto:nelio.laranjeiro@6wind.com] > > Sent: Thursday, August 24, 2017 9:54 AM > > To: Ori Kam > > Cc: adrien.mazaruil@6wind.com; dev@dpdk.org > > Subject: Re: [RFC] net/mlx5: support count flow action > > > > Hi Ori, > > > > Please keep the coding style of the file, and pass checkpatch before > > submitting a patch on the mailing list. It helps the review by having a correct > > patch respecting the coding style of the file. > > I won't spot out here all the coding style issues, if you need some help, feel > > free to ask. > > > Sorry won't happen again. No problem, first contribution is always complicate. > > On Mon, Aug 21, 2017 at 03:35:41PM +0300, Ori Kam wrote: > > > Support count flow action. > > > > Why copy/pasting the title in the commit message? > > > I was under the impression that main function of the RFC should also be in the message body. No, it is not necessary, the commit message should bring useful information by still being short and precise. >[...] > > > --- > > > drivers/net/mlx5/mlx5.h | 4 ++ > > > drivers/net/mlx5/mlx5_flow.c | 163 > > > ++++++++++++++++++++++++++++++++++++++++++- > > > > There are missing changes in the Makefile to have the > > HAVE_VERBS_IBV_EXP_FLOW_SPEC_ACTION_COUNT and the include of the > > mlx5_autoconf.h in mlx5_flow.c. > > > I haven't added them since this feature is not supported yet, and > I don't want anybody trying to activate them. > When the feature will be supported on the verbs then I will update > those files. Ok, so a new version should be sent soon :) >[...] > > > Will be update according to your suggestion. Thanks, -- Nélio Laranjeiro 6WIND