From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-f43.google.com (mail-pg0-f43.google.com [74.125.83.43]) by dpdk.org (Postfix) with ESMTP id C1E9C7CEE for ; Fri, 25 Aug 2017 01:37:16 +0200 (CEST) Received: by mail-pg0-f43.google.com with SMTP id a7so4639235pgn.1 for ; Thu, 24 Aug 2017 16:37:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=qKwhLt3fTdYI7CcpPntw6V5xf1lc2jTuqAMrWeFhLHo=; b=ajYyNYcPr5u6g2nLg8+b7ng6wG2E/CBch1HU7ICQ5nmS2X5CDsyTSQnocEtqClb7S7 aNhtjmc9l5agL6UY945ta3iZ1qHMon7Gao9Hoe8b85ll29N7ZXH43IH9PlqKNhoWHprp 2Hnpl+HKvpS2ea6kb/9W/TABDhjnIec74j+93O92zrUZzMicgl446tD27fQEU98S3uLO nJ/gNipxWjgU5gWIGW/ulx6Lcr9VztKa9/l3pCIf2hzHGdjK2GhtvtrP+6Lh0ZBBKv48 sflv5NsVBmv8tIrvKC3FIF7L7mhN9KCryTcnVEHvMcAxAl8pIczOlC4za4ZaonFlBN52 9D8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=qKwhLt3fTdYI7CcpPntw6V5xf1lc2jTuqAMrWeFhLHo=; b=T9FJZbFXu0A2/nQ45o/VtYE5YHcBf+UcjlPt3hxzxH3OenR88MxmlFN45MLqOKx1D9 bazUCYwUSSpcxIjZjVJr5TOOk9YjAqmn1125HaTEMSibr5V6WXq8ctM5PridP8zRqaYG nfavo+iiPsMgue+qkGgGOHl3zJy6k4kn8LwSEPY8DS5kC9JJmfWfhCuNA5qaToFSz7LJ SDdKlRgOskIGAoDUSW22R91ZQ0JEsWB0YwDUtEhK2VV9f37+sqbKDeZk9EysynIa0erR u/dKgD/6o2LSSFvsmwg+zGOZjV0hPGHiumXTcwhaRYcUGvvH7P8g7r5Kirm578QcW3Fe ZO5Q== X-Gm-Message-State: AHYfb5iRPzQgA+REOQHrCFnLSfH8+gTcOj2UuFb2Z7NUp2IVyJospMQQ qPO1E0K41CeFACBR X-Received: by 10.99.104.193 with SMTP id d184mr7702497pgc.276.1503617835892; Thu, 24 Aug 2017 16:37:15 -0700 (PDT) Received: from xeon-e3 (76-14-207-240.or.wavecable.com. [76.14.207.240]) by smtp.gmail.com with ESMTPSA id 66sm8479344pfb.149.2017.08.24.16.37.15 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 24 Aug 2017 16:37:15 -0700 (PDT) Date: Thu, 24 Aug 2017 16:37:08 -0700 From: Stephen Hemminger To: David Harton Cc: thomas@monjalon.net, ferruh.yigit@intel.com, stephen.hurd@broadcom.com, ajit.khaparde@broadcom.com, johndale@cisco.com, wenzhuo.lu@intel.com, konstantin.ananyev@intel.com, jingjing.wu@intel.com, beilei.xing@intel.com, jing.d.chen@intel.com, adrien.mazarguil@6wind.com, nelio.laranjeiro@6wind.com, alejandro.lucero@netronome.com, hemant.agrawal@nxp.com, rasesh.mody@cavium.com, harish.patil@cavium.com, skhare@vmware.com, yliu@fridaylinux.org, maxime.coquelin@redhat.com, allain.legacy@windriver.com, dev@dpdk.org Message-ID: <20170824163708.2931e83b@xeon-e3> In-Reply-To: <20170824231851.21829-1-dharton@cisco.com> References: <20170824231851.21829-1-dharton@cisco.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] ethdev: modifiy vlan_offload_set_t to return int X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Aug 2017 23:37:17 -0000 On Thu, 24 Aug 2017 19:18:51 -0400 David Harton wrote: > @@ -2031,7 +2031,7 @@ struct avp_queue { > mask = (ETH_VLAN_STRIP_MASK | > ETH_VLAN_FILTER_MASK | > ETH_VLAN_EXTEND_MASK); > - avp_vlan_offload_set(eth_dev, mask); > + (void)avp_vlan_offload_set(eth_dev, mask); This is a BSDism. You don't need the void cast.