From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id B31137CFC for ; Fri, 25 Aug 2017 10:20:46 +0200 (CEST) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Aug 2017 01:20:44 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,424,1498546800"; d="scan'208";a="144431141" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.221.24]) by fmsmga006.fm.intel.com with SMTP; 25 Aug 2017 01:20:37 -0700 Received: by (sSMTP sendmail emulation); Fri, 25 Aug 2017 09:20:36 +0100 Date: Fri, 25 Aug 2017 09:20:36 +0100 From: Bruce Richardson To: "David Harton (dharton)" Cc: Stephen Hemminger , "thomas@monjalon.net" , "ferruh.yigit@intel.com" , "stephen.hurd@broadcom.com" , "ajit.khaparde@broadcom.com" , "John Daley (johndale)" , "wenzhuo.lu@intel.com" , "konstantin.ananyev@intel.com" , "jingjing.wu@intel.com" , "beilei.xing@intel.com" , "jing.d.chen@intel.com" , "adrien.mazarguil@6wind.com" , "nelio.laranjeiro@6wind.com" , "alejandro.lucero@netronome.com" , "hemant.agrawal@nxp.com" , "rasesh.mody@cavium.com" , "harish.patil@cavium.com" , "skhare@vmware.com" , "yliu@fridaylinux.org" , "maxime.coquelin@redhat.com" , "allain.legacy@windriver.com" , "dev@dpdk.org" Message-ID: <20170825082036.GA9968@bricha3-MOBL3.ger.corp.intel.com> References: <20170824231851.21829-1-dharton@cisco.com> <20170824163708.2931e83b@xeon-e3> <69ca37d9a8014b49bfb5b156f98eba03@XCH-RCD-016.cisco.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <69ca37d9a8014b49bfb5b156f98eba03@XCH-RCD-016.cisco.com> Organization: Intel Research and =?iso-8859-1?Q?De=ACvel?= =?iso-8859-1?Q?opment?= Ireland Ltd. User-Agent: Mutt/1.8.3 (2017-05-23) Subject: Re: [dpdk-dev] [PATCH] ethdev: modifiy vlan_offload_set_t to return int X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Aug 2017 08:20:47 -0000 On Fri, Aug 25, 2017 at 12:55:21AM +0000, David Harton (dharton) wrote: > > > > -----Original Message----- > > From: Stephen Hemminger [mailto:stephen@networkplumber.org] > > Sent: Thursday, August 24, 2017 7:37 PM > > To: David Harton (dharton) > > Cc: thomas@monjalon.net; ferruh.yigit@intel.com; > > stephen.hurd@broadcom.com; ajit.khaparde@broadcom.com; John Daley > > (johndale) ; wenzhuo.lu@intel.com; > > konstantin.ananyev@intel.com; jingjing.wu@intel.com; > > beilei.xing@intel.com; jing.d.chen@intel.com; adrien.mazarguil@6wind.com; > > nelio.laranjeiro@6wind.com; alejandro.lucero@netronome.com; > > hemant.agrawal@nxp.com; rasesh.mody@cavium.com; harish.patil@cavium.com; > > skhare@vmware.com; yliu@fridaylinux.org; maxime.coquelin@redhat.com; > > allain.legacy@windriver.com; dev@dpdk.org > > Subject: Re: [dpdk-dev] [PATCH] ethdev: modifiy vlan_offload_set_t to > > return int > > > > On Thu, 24 Aug 2017 19:18:51 -0400 > > David Harton wrote: > > > > > @@ -2031,7 +2031,7 @@ struct avp_queue { > > > mask = (ETH_VLAN_STRIP_MASK | > > > ETH_VLAN_FILTER_MASK | > > > ETH_VLAN_EXTEND_MASK); > > > - avp_vlan_offload_set(eth_dev, mask); > > > + (void)avp_vlan_offload_set(eth_dev, mask); > > > > This is a BSDism. You don't need the void cast. > > Never know what to do...SA tools and some compilers whine if I don't. > People complain if I do. :) > > What if I check the return code and log an error? Sounds like a case of "doing the right thing" to me :-)