From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f181.google.com (mail-wr0-f181.google.com [209.85.128.181]) by dpdk.org (Postfix) with ESMTP id 52FF67CFC for ; Fri, 25 Aug 2017 10:29:28 +0200 (CEST) Received: by mail-wr0-f181.google.com with SMTP id p14so5162007wrg.3 for ; Fri, 25 Aug 2017 01:29:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=OWkBJ5+Fuel0xj6Ikl0VNT1pPmhfMTe5fkn9knkrdos=; b=Y/YqcJ4H5hrt9Rugn91foy380voQyQxJSRJKSl6NjvH+EEsev/R75WIywkkQpH993F HLCLukZFGcbnbIcQi+Pxymglh9GeK20cGin0ZjN7RN5Ljh7Xb2mk4MZdPIyUatQhs9Se Tx8PUIS7zT0xD/ViAdT5q4AVGLW388VUYq6kK/1tBg5tNd0F0zgVxSPjYS6GY1mkPp3N 8Bmc4oRO8AaKJ9zd6PmGMbAotQfaKZ12txISfMEhKeewl0tv0czdrUb+6kybCl2QGfRC YDCs6RqNxBeBAnPV//lpJuCCUCulb9izKEKHD4C9heWNXl8b0WYGjgwKA9u7FR7ZBviH qC9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=OWkBJ5+Fuel0xj6Ikl0VNT1pPmhfMTe5fkn9knkrdos=; b=OgZczhUuxx6f8RLZMtvFO7LDZvDFMUL8f6M7Dv4Ixm2SeLcLjzhosQqEPeKGois7yv A2lWrRqNJoyHWGcwFDPRyU+WA6dp7J+O62OcEtoBfT0T0qS1/bIBYxF/XT+/8+/Pkxwi cUyZcvsDEnxUjeulocSeR3c+4MPw56AjgaYZ0YEjY6WeOG1ySKUXt/VnDGWdr0fjMXng FLiU8UWoLJh/tYOVk9oWgJ5zOEplns8ILypeHDeqaOl3zAlzdW/2uK5MP82OJAIAOzs0 0GSb0NfgCu6gvM6TM3ilgslX84oPJO0tZhZuXblkviP55fGYSqFgvYxzLMgtdOFwfM+q rZEw== X-Gm-Message-State: AHYfb5hwyzRE+18St/bL65cSSz95OTGW+rPQsWOcLvfoVPXR2wWPTxhJ WNzgAWG4MXiE81KA X-Received: by 10.223.142.245 with SMTP id q108mr5920483wrb.320.1503649767949; Fri, 25 Aug 2017 01:29:27 -0700 (PDT) Received: from autoinstall.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id 69sm4233584wrk.2.2017.08.25.01.29.27 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 25 Aug 2017 01:29:27 -0700 (PDT) Date: Fri, 25 Aug 2017 10:29:18 +0200 From: =?iso-8859-1?Q?N=E9lio?= Laranjeiro To: Matan Azrad Cc: Adrien Mazarguil , "dev@dpdk.org" Message-ID: <20170825082918.GU4544@autoinstall.dev.6wind.com> References: <1502627112-53405-1-git-send-email-matan@mellanox.com> <20170823094037.GS12995@autoinstall.dev.6wind.com> <20170824073824.GA4544@autoinstall.dev.6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH 1/2] net/mlx5: support device removal event X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Aug 2017 08:29:28 -0000 On Thu, Aug 24, 2017 at 02:33:43PM +0000, Matan Azrad wrote: > Hi Nelio >[...] > > > > I am expecting to find something related to a link update, what I see is an > > alarm update. I don't expect to update an alarm but a link. The names and > > action are inconsistent i.e. mlx5_dev_link_status_handler() should handle a > > link not an alarm. > > > > I understand there is a need to add more function levels, but the > > priv_link_status_alarm_update() should be renamed to something like > > priv_link_status_update(). > > OK, I think I understand you. > > Because the alarm is a workaround you don't think it should be mentioned > in function description or function name. > (also the function subject should be the link status and not the alarm) > I can agree with you about it. > And I will create v2 with your suggestion - priv_link_status_update. Thanks, > The return value description can stay as in old code semantic: > Zero if the callback process can be called immediately. > > Are you agree? Yes. > Maybe we can tell something about the alarm and inconsistent reason > In this function description or internal comment for future code review. > If you want it, please suggest comment. Yes the comment can added internally. Thanks, -- Nélio Laranjeiro 6WIND