From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f177.google.com (mail-wr0-f177.google.com [209.85.128.177]) by dpdk.org (Postfix) with ESMTP id D2F20137C for ; Tue, 29 Aug 2017 11:02:21 +0200 (CEST) Received: by mail-wr0-f177.google.com with SMTP id z91so8180984wrc.1 for ; Tue, 29 Aug 2017 02:02:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=isRUvRMRsEnXZYxiCtngyHMVDvICWI+6G2u2hU5/r2I=; b=hFECOOhFgtxTR7bKnlL6y0CKCxHDzaRzBHmoUAOnDVF7dhwymqf3NqHhmcGIeZfNHj kFU9mBSa3/RLfykuAiULyYGJm5LGRCllL2B8yKgZZk3RBFQf6CEj3h0Z9+islcUpIrQw okoPZl9PbGYpB0iHxNjpaTcSg446+DgjBDp7SG2SgggL9DpYV7TFPu2nI7bu84iDW848 2sHN7R3SVFVpQRXb5ojrRJox0p8uLRCHtREZ1HDWckB62RiofKRmSVQctgrpVSSF/Rp2 m979YOOye9juFoZjk4pbj7+RcgPDNw1/rHcO3mDbULKPSsiIdR2Fvz+lYgJIWyWcF+QI dJOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=isRUvRMRsEnXZYxiCtngyHMVDvICWI+6G2u2hU5/r2I=; b=o1w8UUS1/NPJpcWRTipHYdMDWDoVx5fw4DRCZeZZt7oUZxSCI75uAwgybfMUlGzvhG 1RPQfMZQp1VX4heusiE89LJsWXwChUowYE8d6LZKqdPTr++4iXViVx/3isUyLpaqbkRP ktehByJYC6CeqzJi8gmeLxAy/OFEhjBwH9d9gE9fp4y6y7YqBfRgYA6Ts32BDpIFdGOf Blzl4MhHBPernLCY6aF323AqFeluko/p0CcskDggvfS658JmIt9sk2AEgfgvUmYfgsav aHIVkz2zcLqjouXD9pYe65xixYq8mSi1057otDalRFUpC4pm4d9RKJzQ4wrgVGNvuIog u/Yg== X-Gm-Message-State: AHYfb5gYUa9jp6SMZczE+SJsyr18thyYOMYBleexXd6SITLdiVXWML7U Y7CwQTpZp5y6stLS X-Received: by 10.223.158.132 with SMTP id a4mr1998536wrf.220.1503997341181; Tue, 29 Aug 2017 02:02:21 -0700 (PDT) Received: from bidouze.vm.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id q201sm1142779wmg.48.2017.08.29.02.02.19 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 29 Aug 2017 02:02:20 -0700 (PDT) Date: Tue, 29 Aug 2017 11:02:10 +0200 From: =?iso-8859-1?Q?Ga=EBtan?= Rivet To: Raslan Darawsheh Cc: thomas@monjalon.net, dev@dpdk.org Message-ID: <20170829090210.GJ8124@bidouze.vm.6wind.com> References: <20170829081817.GI8124@bidouze.vm.6wind.com> <1503996945-62885-1-git-send-email-rasland@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1503996945-62885-1-git-send-email-rasland@mellanox.com> User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH v2] net/failsafe: fix failsafe bus uninit return value X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Aug 2017 09:02:22 -0000 On Tue, Aug 29, 2017 at 11:55:45AM +0300, Raslan Darawsheh wrote: > fs_bus_uninit is always returning 0 no matter what was the status > of each sub device bus_uninit value. > > Fixes: a46f8d58 ("net/failsafe: add fail-safe PMD") > > Signed-off-by: Raslan Darawsheh > --- > drivers/net/failsafe/failsafe_eal.c | 20 ++++++++++---------- > 1 file changed, 10 insertions(+), 10 deletions(-) > > diff --git a/drivers/net/failsafe/failsafe_eal.c b/drivers/net/failsafe/failsafe_eal.c > index c8f4318..f6e44ca 100644 > --- a/drivers/net/failsafe/failsafe_eal.c > +++ b/drivers/net/failsafe/failsafe_eal.c > @@ -90,19 +90,21 @@ fs_bus_uninit(struct rte_eth_dev *dev) > { > struct sub_device *sdev = NULL; > uint8_t i; > - int ret; > + int sdev_ret; > + int ret = 0; > > FOREACH_SUBDEV_STATE(sdev, i, dev, DEV_PROBED) { > - ret = rte_eal_hotplug_remove(sdev->bus->name, > - sdev->dev->name); > - if (ret) { > - ERROR("Failed to remove requested device %s", > - sdev->dev->name); > + sdev_ret = rte_eal_hotplug_remove(sdev->bus->name, > + sdev->dev->name); > + if (sdev_ret) { > + ERROR("Failed to remove requested device %s" > + "(errno: %d)", sdev->dev->name, sdev_ret); The error string should be on one line to help grepping the issue. The code displayed is not errno, it should not be named as such. + ERROR("Failed to remove requested device %s (%d)", + sdev->dev->name, sdev_ret); > + ret = -1; > continue; > } > sdev->state = DEV_PROBED - 1; > } > - return 0; > + return ret; > } > > int > @@ -111,8 +113,6 @@ failsafe_eal_uninit(struct rte_eth_dev *dev) > int ret; > > ret = fs_bus_uninit(dev); > - if (ret) > - return ret; > PRIV(dev)->state = DEV_PROBED - 1; > - return 0; > + return ret; > } > -- > 2.7.4 > Otherwise, Acked-by: Gaetan Rivet -- Gaëtan Rivet 6WIND