From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f48.google.com (mail-wm0-f48.google.com [74.125.82.48]) by dpdk.org (Postfix) with ESMTP id 7AD3B11F5 for ; Tue, 29 Aug 2017 11:28:56 +0200 (CEST) Received: by mail-wm0-f48.google.com with SMTP id u26so18533064wma.0 for ; Tue, 29 Aug 2017 02:28:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=0dI3hXJb4jDB/EKTB0+ubMpyWd0ytwY8lWRGhHfQ1F4=; b=K2thQpmlEDbiV8q45ZHmavoXUYOY4vSPAXbRdLit8Mx5qYfidk19Pg45/laLE5EOXG wjE6o8OHjjg1TDE7U8yTtPC/0TTQ+2OFKSf7+7TMEig1eECNVeVZi5mLr1P1XZ4CVcXl RDLNh86elIhII3t5xYNaLU9JZkZNCmrw1NOJEV+Fly06jlLR8YSESURQt3NPGXg5pYVW w9GVdgc7/c/gBsSwRafp89D+M/bmu2TfVoqLFGUhI0UqDbTrnmrXuUzkoW/I5Aphe16W soZUvLbsL51ueCQFR8QBddTQyCuksGjTY4qYhHJldKTAKsmiIEQxxtrRTl6j7SGfe/H/ fY0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=0dI3hXJb4jDB/EKTB0+ubMpyWd0ytwY8lWRGhHfQ1F4=; b=e3I/9UVtbVGq4h3kBU+tSvmmTDR7wAku785eEtSJDYeeqlvXQKBWNCgZ4H5froBm7H pPG3ldhVMhxPYayrl40jgIzOaI7aENB7gAb0a9KMYF5EyjnfX2+bjvB254EkCRWgqLKk lem+aL3ZCxS67k7KAGjtNF+2Bp0LZtWOYaASc85iLPZneKWDQ11k/SF+J03XozzOHcNa LuZUdR7dlr02NGJnlc9RQ7Te3WeyFcdhm1qrNACLNL/a7BSH2tEYLF7CIY71RdIwejFe LfudQiLhR3zMFyRVTsWnvd/NFSF7Y+9ycYsRuVMPmP/lygwaxQcUYWtwA3uqhbh+cxU4 U5ag== X-Gm-Message-State: AHYfb5icI9IKoA8CFp8SMLf3mXr6FuKoxYsJuJGzSbyfBRWXY0R31aTw ZmOYP0K1BGV8HCWZ X-Received: by 10.28.95.215 with SMTP id t206mr824109wmb.56.1503998935687; Tue, 29 Aug 2017 02:28:55 -0700 (PDT) Received: from bidouze.vm.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id o191sm855103wmg.5.2017.08.29.02.28.54 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 29 Aug 2017 02:28:54 -0700 (PDT) Date: Tue, 29 Aug 2017 11:28:45 +0200 From: =?iso-8859-1?Q?Ga=EBtan?= Rivet To: Raslan Darawsheh Cc: thomas@monjalon.net, dev@dpdk.org Message-ID: <20170829092845.GL8124@bidouze.vm.6wind.com> References: <1503996945-62885-1-git-send-email-rasland@mellanox.com> <1503997688-1182-1-git-send-email-rasland@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1503997688-1182-1-git-send-email-rasland@mellanox.com> User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH v3] net/failsafe: fix failsafe bus uninit return value X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Aug 2017 09:28:56 -0000 On Tue, Aug 29, 2017 at 12:08:08PM +0300, Raslan Darawsheh wrote: > fs_bus_uninit is always returning 0 no matter what was the status > of each sub device bus_uninit value. > > Fixes: a46f8d58 ("net/failsafe: add fail-safe PMD") > No need to send another version, but for next time: you could have included my ack at this point :). > Signed-off-by: Raslan Darawsheh Acked-by: Gaetan Rivet Thanks, > --- > drivers/net/failsafe/failsafe_eal.c | 19 +++++++++---------- > 1 file changed, 9 insertions(+), 10 deletions(-) > > diff --git a/drivers/net/failsafe/failsafe_eal.c b/drivers/net/failsafe/failsafe_eal.c > index c8f4318..aeb87a0 100644 > --- a/drivers/net/failsafe/failsafe_eal.c > +++ b/drivers/net/failsafe/failsafe_eal.c > @@ -90,19 +90,20 @@ fs_bus_uninit(struct rte_eth_dev *dev) > { > struct sub_device *sdev = NULL; > uint8_t i; > - int ret; > + int sdev_ret; > + int ret = 0; > > FOREACH_SUBDEV_STATE(sdev, i, dev, DEV_PROBED) { > - ret = rte_eal_hotplug_remove(sdev->bus->name, > - sdev->dev->name); > - if (ret) { > - ERROR("Failed to remove requested device %s", > - sdev->dev->name); > + sdev_ret = rte_eal_hotplug_remove(sdev->bus->name, > + sdev->dev->name); > + if (sdev_ret) { > + ERROR("Failed to remove requested device %s (err: %d)", > + sdev->dev->name, sdev_ret); > continue; > } > sdev->state = DEV_PROBED - 1; > } > - return 0; > + return ret; > } > > int > @@ -111,8 +112,6 @@ failsafe_eal_uninit(struct rte_eth_dev *dev) > int ret; > > ret = fs_bus_uninit(dev); > - if (ret) > - return ret; > PRIV(dev)->state = DEV_PROBED - 1; > - return 0; > + return ret; > } > -- > 2.7.4 > -- Gaëtan Rivet 6WIND