From: Jens Freimann <jfreimann@redhat.com>
To: "Stojaczyk, DariuszX" <dariuszx.stojaczyk@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"Wodkowski, PawelX" <pawelx.wodkowski@intel.com>,
"maxime.coquelin@redhat.com" <maxime.coquelin@redhat.com>,
"yliu@fridaylinux.org" <yliu@fridaylinux.org>
Subject: Re: [dpdk-dev] [PATCH v2] vhost: added user callbacks for socket open/close
Date: Wed, 30 Aug 2017 08:33:31 +0200 [thread overview]
Message-ID: <20170830063331.nw2mzka6onpgfgei@dhcp-192-218.str.redhat.com> (raw)
In-Reply-To: <FBE7E039FA50BF47A673AD0BD3CD56A8F112CC@HASMSX105.ger.corp.intel.com>
On Tue, Aug 29, 2017 at 06:08:45AM +0000, Stojaczyk, DariuszX wrote:
>Hi Jens,
>
>> I'm still not sure I understand the use case. So just for my
>> understanding: users need to distinct between "the device is going away
>> temporarily, keep the connection" and "we're shutting down for good", is
>> that it?
>
>Yes, exactly.
>
>> Maybe it's just me or maybe it means you could explain your example in the
>> commit message a bit more.
>
>Ok. How about the following commit message instead:
>```
>rte_vhost: added user callbacks for socket open/close
>
>Added new callbacks to notify about socket connection status.
>As destroy_device is used for virtqueue processing *pause* as
>well as connection close, the user has no distinction between those.
>
>Consider the following scenario:
>rte_vhost: received SET_VRING_BASE message,
> calling destroy_device() as usual
>
>user: end-user asks to remove the device (together with socket file),
> OK, device is not *in use* - that's NOT the behavior we want
> calling rte_vhost_driver_unregister() etc.
>
>Instead of changing new_device/destroy_device callbacks and breaking
>the ABI, a set of new functions new_connection/destroy_connection
>has been added.
>```
Sounds good to me. Thanks!
regards,
Jens
next prev parent reply other threads:[~2017-08-30 6:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-21 9:34 [dpdk-dev] [PATCH] " Dariusz Stojaczyk
2017-08-21 15:00 ` Jens Freimann
2017-08-22 9:55 ` Stojaczyk, DariuszX
2017-08-22 11:58 ` Jens Freimann
2017-08-22 12:10 ` Jens Freimann
2017-08-22 16:24 ` [dpdk-dev] [PATCH v2] " Dariusz Stojaczyk
2017-08-25 9:22 ` Jens Freimann
2017-08-29 6:08 ` Stojaczyk, DariuszX
2017-08-30 6:33 ` Jens Freimann [this message]
2017-08-30 10:50 ` [dpdk-dev] [PATCH v3] rte_vhost: " Dariusz Stojaczyk
2017-10-10 3:14 ` Yuanhan Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170830063331.nw2mzka6onpgfgei@dhcp-192-218.str.redhat.com \
--to=jfreimann@redhat.com \
--cc=dariuszx.stojaczyk@intel.com \
--cc=dev@dpdk.org \
--cc=maxime.coquelin@redhat.com \
--cc=pawelx.wodkowski@intel.com \
--cc=yliu@fridaylinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).