From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.droids-corp.org (zoll.droids-corp.org [94.23.50.67]) by dpdk.org (Postfix) with ESMTP id 3BAB27CBD; Fri, 1 Sep 2017 11:58:15 +0200 (CEST) Received: from lfbn-1-18623-73.w90-103.abo.wanadoo.fr ([90.103.154.73] helo=droids-corp.org) by mail.droids-corp.org with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1dnini-0002RB-Fj; Fri, 01 Sep 2017 12:03:48 +0200 Received: by droids-corp.org (sSMTP sendmail emulation); Fri, 01 Sep 2017 11:58:07 +0200 Date: Fri, 1 Sep 2017 11:58:07 +0200 From: Olivier MATZ To: Yuanhan Liu Cc: dev@dpdk.org, maxime.coquelin@redhat.com, stephen@networkplumber.org, stable@dpdk.org Message-ID: <20170901095806.yo34c4euaqf4avoi@neon> References: <20170831134015.1383-1-olivier.matz@6wind.com> <20170831134015.1383-9-olivier.matz@6wind.com> <20170901092538.GU9736@yliu-home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170901092538.GU9736@yliu-home> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [PATCH 8/9] net/virtio: keep Rx handler whatever the Tx queue config X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Sep 2017 09:58:15 -0000 On Fri, Sep 01, 2017 at 05:25:38PM +0800, Yuanhan Liu wrote: > On Thu, Aug 31, 2017 at 03:40:14PM +0200, Olivier Matz wrote: > > Split use_simple_rxtx into use_simple_rx and use_simple_tx, > > and ensure that only use_simple_tx is updated when txq flags > > forces to use the standard Tx handler. > > I think it's a good idea to split it. > > > This change is also useful for next commit (disable simple Rx > > path when Rx checksum is requested). > > > > Cc: stable@dpdk.org > > But again, I don't think it's a good idea to put them (including the > next patch) to stable releases. Yes, you're right this one is more an enhancement than a fix: it just selects a faster handler if it's possible. But next one is a fix: it must not select the simple handler if offload is requested. If these commits are not pushed in stable, it's not a problem for me, so I let you decide. In that case, I will remove the Cc: stable from the last 3 commits. Do you confirm? Thanks for the review. Olivier