From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f181.google.com (mail-wr0-f181.google.com [209.85.128.181]) by dpdk.org (Postfix) with ESMTP id 8A5EC108F for ; Fri, 1 Sep 2017 12:19:56 +0200 (CEST) Received: by mail-wr0-f181.google.com with SMTP id 40so5218206wrv.5 for ; Fri, 01 Sep 2017 03:19:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=BNxqZ0vkqT075WaZ6ctnGIjUN2nv4qiqBlxYLzoBcAs=; b=NYflXmkzHn0KQSZkt26GTG3/SjZjW1SgWchfaEbkmxnCt03U2/p6FkzaPJ9mRIh7BL fXC2k3FpGnK04xouZFpYgDEmc79Fgv6UbZpZq+nwG67n8MEpA2ndWspXjmcMFeJOrIOd Z57WlwnEtYg7HuVhpDGt1KVbkVzUItI6nFKopeyb87YzD9sfd1LNYx54F9e9NZV2qUjN 6dm9Mr4RzoSncaXMQaQwynK5XdPVz/+BnQvz/FY6YNtoyLRwPqlfu7Z7+ccq8lqTTIMf NffCKNxSVhLB711HFfDwEZcp71ygmlYq9NFXsogxRAADJJolgO9DNTi/lwGI31s+l6Tj IQVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=BNxqZ0vkqT075WaZ6ctnGIjUN2nv4qiqBlxYLzoBcAs=; b=lhsnwr9pYRXC1mXeUmzWApEdN7/BoV/uWG/jr8EWJ1UySQTrxUOhtDIbV9T1rgMyna 05/7cqZ6UEzYSD5+v91AjHO5bonXoEB4eZNtXB2K8xAyGq1onRPChZJwgD4xHSHjTuw6 t8RHeicgnviNWQq+h+chhMzIpy1m5Bb/cyTARNmVCzfACtz0IPo61TBkuLety4WYlbr5 diDvvwDqgpiHSoZQy0ovYHSLXk4sZyHEPA9l8VOyRY0Qunvso6yuKddb/LpRfsnmkFO2 lg+Oh7LXs81gTg+MMz7bqb8N550xpTi4E8IBVMEr/kFqiP25wAxjbTOvpvJtuX/dDK3P 4NhQ== X-Gm-Message-State: AHPjjUjGzHDa5kC1B3NXRa08GC0dIywonZDRiV/YNtbCEzR4wRBqwiu5 0fJCZGHbPuYhiaq9 X-Google-Smtp-Source: ADKCNb7aLSG9mIyY2Ip8W6IfwiKibpJkEh2vd+6ndPRxvf8iXS8XXTTqIg+XeDPO2ZwcPJcq/b0xwg== X-Received: by 10.223.149.129 with SMTP id p1mr73419wrp.118.1504261196154; Fri, 01 Sep 2017 03:19:56 -0700 (PDT) Received: from 6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id j21sm1151966wre.82.2017.09.01.03.19.54 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 01 Sep 2017 03:19:55 -0700 (PDT) Date: Fri, 1 Sep 2017 12:19:45 +0200 From: Adrien Mazarguil To: Ferruh Yigit Cc: dev@dpdk.org Message-ID: <20170901101945.GP4301@6wind.com> References: <203a53f8-41a2-a3f7-fce2-59379de8ba2c@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <203a53f8-41a2-a3f7-fce2-59379de8ba2c@intel.com> Subject: Re: [dpdk-dev] [PATCH v1 04/48] net/mlx4: remove useless compilation checks X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Sep 2017 10:19:56 -0000 Hi Ferruh, On Fri, Aug 18, 2017 at 02:39:18PM +0100, Ferruh Yigit wrote: > On 8/1/2017 5:53 PM, Adrien Mazarguil wrote: > > Verbs support for RSS, inline receive and extended device query calls has > > not been optional for a while. Their absence is untested and is therefore > > unsupported. > > > > Remove the related compilation checks and assume Mellanox OFED is up to > > date, as described in the documentation. > > So this requires Mellanox OFED 4.1 is there, Well, the PMD most likely works with versions older than that, but they are not officially supported anymore. These changes assert that no effort is made to maintain compatibility. > is there a check for the OFED version, or do you think does it required? I think it's not necessary. You know, the existing checks haven't been validated for a very long time, mlx4 probably does not even compile anymore without these features. Even if it does, it might be unable to perform TX/RX at all. Getting a compilation failure at least makes things clear. > > > > > Use this opportunity to remove a few useless data path debugging messages > > behind compilation checks on never defined macros. > > > > Signed-off-by: Adrien Mazarguil > > <...> > -- Adrien Mazarguil 6WIND