From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 213F07CB6 for ; Fri, 1 Sep 2017 15:55:20 +0200 (CEST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga104.jf.intel.com with ESMTP; 01 Sep 2017 06:55:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,458,1498546800"; d="scan'208";a="1010021710" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.221.24]) by orsmga003.jf.intel.com with SMTP; 01 Sep 2017 06:55:16 -0700 Received: by (sSMTP sendmail emulation); Fri, 01 Sep 2017 14:55:16 +0100 Date: Fri, 1 Sep 2017 14:55:15 +0100 From: Bruce Richardson To: Luca Boccassi Cc: dev@dpdk.org Message-ID: <20170901135515.GA10224@bricha3-MOBL3.ger.corp.intel.com> References: <20170901100416.80264-1-bruce.richardson@intel.com> <20170901100416.80264-4-bruce.richardson@intel.com> <1504272772.31011.2.camel@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1504272772.31011.2.camel@gmail.com> Organization: Intel Research and =?iso-8859-1?Q?De=ACvel?= =?iso-8859-1?Q?opment?= Ireland Ltd. User-Agent: Mutt/1.8.3 (2017-05-23) Subject: Re: [dpdk-dev] [PATCH 03/17] igb_uio: add igb_uio kmod to meson build X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Sep 2017 13:55:21 -0000 On Fri, Sep 01, 2017 at 02:32:52PM +0100, Luca Boccassi wrote: > On Fri, 2017-09-01 at 11:04 +0100, Bruce Richardson wrote: > > Support building igb_uio using meson and ninja. For this, we still > > use the > > kernel's kbuild system, by calling out to make, since it's safer and > > easier > > than trying to reproduce that in meson. A list of suitable file > > dependencies is given so that we have a reasonable chance of a > > rebuild when > > necessary. > > > > Signed-off-by: Bruce Richardson > > --- > >  lib/librte_eal/linuxapp/igb_uio/Kbuild      |  1 + > >  lib/librte_eal/linuxapp/igb_uio/meson.build | 47 > > +++++++++++++++++++++++++++++ > >  lib/librte_eal/linuxapp/meson.build         | 10 ++++++ > >  meson_options.txt                           |  2 ++ > >  4 files changed, 60 insertions(+) > >  create mode 100644 lib/librte_eal/linuxapp/igb_uio/Kbuild > >  create mode 100644 lib/librte_eal/linuxapp/igb_uio/meson.build > > > > diff --git a/lib/librte_eal/linuxapp/igb_uio/Kbuild > > b/lib/librte_eal/linuxapp/igb_uio/Kbuild > > new file mode 100644 > > index 000000000..98c98fe52 > > --- /dev/null > > +++ b/lib/librte_eal/linuxapp/igb_uio/Kbuild > > @@ -0,0 +1 @@ > > +obj-m := igb_uio.o > > diff --git a/lib/librte_eal/linuxapp/igb_uio/meson.build > > b/lib/librte_eal/linuxapp/igb_uio/meson.build > > new file mode 100644 > > index 000000000..c046e1d66 > > --- /dev/null > > +++ b/lib/librte_eal/linuxapp/igb_uio/meson.build > > @@ -0,0 +1,47 @@ > > +#   BSD LICENSE > > +# > > +#   Copyright(c) 2017 Intel Corporation. All rights reserved. > > +#   All rights reserved. > > +# > > +#   Redistribution and use in source and binary forms, with or > > without > > +#   modification, are permitted provided that the following > > conditions > > +#   are met: > > +# > > +#     * Redistributions of source code must retain the above > > copyright > > +#       notice, this list of conditions and the following > > disclaimer. > > +#     * Redistributions in binary form must reproduce the above > > copyright > > +#       notice, this list of conditions and the following disclaimer > > in > > +#       the documentation and/or other materials provided with the > > +#       distribution. > > +#     * Neither the name of Intel Corporation nor the names of its > > +#       contributors may be used to endorse or promote products > > derived > > +#       from this software without specific prior written > > permission. > > +# > > +#   THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND > > CONTRIBUTORS > > +#   "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT > > NOT > > +#   LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND > > FITNESS FOR > > +#   A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE > > COPYRIGHT > > +#   OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, > > INCIDENTAL, > > +#   SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT > > +#   LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF > > USE, > > +#   DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND > > ON ANY > > +#   THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR > > TORT > > +#   (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF > > THE USE > > +#   OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH > > DAMAGE. > > + > > +mkfile = custom_target('igb_uio_makefile', > > + output: 'Makefile', > > + command: ['touch', '@OUTPUT@']) > > + > > +custom_target('igb_uio', > > + input: ['igb_uio.c', 'Kbuild'], > > + output: 'igb_uio.ko', > > + command: ['make', '-C', kernel_dir, > > + 'M=' + meson.current_build_dir(), > > + 'src=' + meson.current_source_dir(), > > + 'EXTRA_CFLAGS=-I' + meson.current_source_dir() + > > + '/../../common/include', > > + 'modules'], > > + depends: mkfile, > > + depend_files: [join_paths(kernel_dir, 'Kconfig')], > > Can this be made optional somehow? > > There's no build/Kconfig on Debian: > > $ ls /lib/modules/4.9.0-3-amd64/build > arch  include  Makefile  Module.symvers  scripts > > But the build works fine without that depend_files line. > Yep, definitely can be removed. I was just looking for some way to give meson the smarts to know when the kmod needed to be recompiled, and it seemed a likely candidate to watch for changes. /Bruce