From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stephen@networkplumber.org>
Received: from mail-pg0-f51.google.com (mail-pg0-f51.google.com [74.125.83.51])
 by dpdk.org (Postfix) with ESMTP id 0EE0E325A
 for <dev@dpdk.org>; Sun,  3 Sep 2017 18:10:07 +0200 (CEST)
Received: by mail-pg0-f51.google.com with SMTP id b8so12633670pgn.5
 for <dev@dpdk.org>; Sun, 03 Sep 2017 09:10:07 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=networkplumber-org.20150623.gappssmtp.com; s=20150623;
 h=date:from:to:cc:subject:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=w/K8Yhsx5z+eVsLE4FxPtJcYDbGGmdqjEL71FtED9X0=;
 b=MrCHFy2lHKVkP9Wrp5UY3KE7nzvS3ceUAfNnyI6nouBf3whwCF3ELdKfxvXX/1mjg5
 4C4OPhX8z0sZu78CSvti/OGmVgSsRAWob0G6nK0PV/xdF285N8Vdf9ODOyuILI79Jq3f
 7VsPQNhxUOe2G4iwLL5ZERRpFXATKsXlrOLTvJiAr9HdWjhA0tuMAaULe/4LAPL8UZPe
 OG2DqtlWurw1FPVa6cTapuomgtSwsjtdzXCF1nQFAQPVQIwqaUxfodAoiw0pzXbizw5d
 1+vCppqh3Ts94KiAESrOuKYmnclHlar+yFk8UuU8QtU502wupfTyMMUYbx7Eu+GVjhpy
 tSSw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=w/K8Yhsx5z+eVsLE4FxPtJcYDbGGmdqjEL71FtED9X0=;
 b=qGnZ5SZFVTyJXeCCvRl9bw6TpGdu8vHdMRH60jrDBePM7rK38VDgNvmmi6v/IFuAMw
 JLx34LvngCQOjqCaGBtlW1xO4UlBmbpivSnv36U2jvQkF2z0E2gbOGoAi347XKMA2Bts
 tKsy1leE/cwDto4FV1oPkDQeh6y2ncCrPbB7rUOvjLJNLmwnuRHewv8lXJZT3K8Km6Fl
 in69Kfx83h8JIys7ZStyC0XObadI7OI2VUGhIbYBqnbaHWP1amlXiFN3IOuG1sBFCLe7
 QPzn4IGvCExyE6Y9w/C2sFUviG5fFGp51gTBgkLh2x2Ol3kT+jXFLXDy9WP3BaB7djuq
 kd8Q==
X-Gm-Message-State: AHPjjUj6hIcMfe325p3NarwiujdE4f1OqxRfwebCRdA57WWM1WpyLhIC
 x7Oh8LRc2TFXmxNO3D5Unw==
X-Google-Smtp-Source: ADKCNb4zTBePyoZFx9M51xDdQnjQ2N9lOfTUPJECMynQJN8PoIkqWNl3nymk/ZQIVb1NPtn1+y0GsQ==
X-Received: by 10.99.52.141 with SMTP id b135mr8885195pga.358.1504455007261;
 Sun, 03 Sep 2017 09:10:07 -0700 (PDT)
Received: from xeon-e3 (76-14-207-240.or.wavecable.com. [76.14.207.240])
 by smtp.gmail.com with ESMTPSA id z15sm7854670pgs.37.2017.09.03.09.10.06
 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);
 Sun, 03 Sep 2017 09:10:07 -0700 (PDT)
Date: Sun, 3 Sep 2017 09:10:04 -0700
From: Stephen Hemminger <stephen@networkplumber.org>
To: Jeff Guo <jia.guo@intel.com>
Cc: bruce.richardson@intel.com, dev@dpdk.org, gaetan.rivet@6wind.com,
 shreyansh.jain@nxp.com, jblunck@infradead.org, helin.zhang@intel.com,
 ferruh.yigit@intel.com, konstantin.ananyev@intel.com, thomas@monjalon.net,
 jingjing.wu@intel.com
Message-ID: <20170903091004.186a799b@xeon-e3>
In-Reply-To: <1504453785-15735-2-git-send-email-jia.guo@intel.com>
References: <1498712510-44217-2-git-send-email-jia.guo@intel.com>
 <1504453785-15735-1-git-send-email-jia.guo@intel.com>
 <1504453785-15735-2-git-send-email-jia.guo@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v4 1/2] eal: add uevent monitor for hot plug
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Sun, 03 Sep 2017 16:10:08 -0000

On Sun,  3 Sep 2017 23:49:44 +0800
Jeff Guo <jia.guo@intel.com> wrote:

> +int
> +rte_eal_uev_fd_new(void)
> +{
> +
> +	int netlink_fd = -1;
> +
> +	netlink_fd = socket(PF

Please don't use the "initialize everything" style of programming.

Gcc has good detection and warning about uninitalized variables, and this style
defeats that.