From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f176.google.com (mail-wr0-f176.google.com [209.85.128.176]) by dpdk.org (Postfix) with ESMTP id A1DDA37B0 for ; Mon, 4 Sep 2017 10:47:41 +0200 (CEST) Received: by mail-wr0-f176.google.com with SMTP id b9so4208375wra.0 for ; Mon, 04 Sep 2017 01:47:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=uT6AxiBjsLGKlkLugHbtRCw/ox0hh0Ra5rnzI43Yx1E=; b=MO53CLSWVhlZ9+ZvyJtO5T31+HRyVINEPTteAhkXaZdZm3vv31K/dK56pLicdPqdhg rRGwBGgavvcuhTU0yYOUwGqH6/DctVG7kCtE9vbo9lPIREbgLqIb5M3m1JNJefXXJfk1 xzp0fJxf6Vdf8ezha4AAgh1PPP6KYZnHK1xgXafz1m3r+M6CKrlfGHMBme5Ni0ddq53S O9xIDXtah+aZBAD0Rp04qqAQypYpa5libF5MTwedJkWevrOKuMI4DB2D47t/5qzzC6u4 7h7ZekfhivrWPRFT/P1I2zH9p2TEuh5Aw9RMBBvSX5cZkJzSNwC497d2xiHvsjcdlL7b Dy+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=uT6AxiBjsLGKlkLugHbtRCw/ox0hh0Ra5rnzI43Yx1E=; b=VSOT11wnU8KSX0kiE37HVx26PzGKGtyuwwa76oFJJ2d4f+ouhTZf50X8pUDulBDiG7 RTs9GBObLQiKzAVOkYxkvptTixOayeCvRVBKoEFXp1jCQgGBq2ZcTPyTj9IcoxNvkqhn uDXwCpK8As48kYt7lOBWM33h5//yKFqcjrs1WQFUm10vAhRq8r8tiL1G21eHTrYwR70p 78XMA0EqHWlWMOYtXW85GNGf3iFdxTUSjkyNPRxXXOfBHKWXyqJiPp4Hd4IefUKAnuaN AJpPIUOgJk6D9ZxK5aGuoHlhMpDRvMk83XcM9E44ZJ4kvNFmPX31u/bFK57v0RUXinI5 kVbA== X-Gm-Message-State: AHPjjUjpYWlFzdwIceB7i6Fu7q3a5binpIAVp0MxvVNX6D++1m84/nzB cOtInH9mwXZTR5No X-Google-Smtp-Source: ADKCNb717FtGpPxVMY9Deznnx82L04ajWbHA15ggNi9x98H0BySquwzDrkAYsX7g3iQY9vitnN487Q== X-Received: by 10.223.166.21 with SMTP id k21mr1015461wrc.105.1504514861128; Mon, 04 Sep 2017 01:47:41 -0700 (PDT) Received: from bidouze.vm.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id b196sm38503wmd.29.2017.09.04.01.47.40 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 04 Sep 2017 01:47:40 -0700 (PDT) Date: Mon, 4 Sep 2017 10:47:30 +0200 From: =?iso-8859-1?Q?Ga=EBtan?= Rivet To: Matan Azrad Cc: dev@dpdk.org, stable@dpdk.org Message-ID: <20170904084730.GC21444@bidouze.vm.6wind.com> References: <1504452405-63569-1-git-send-email-matan@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1504452405-63569-1-git-send-email-matan@mellanox.com> User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH] net/failsafe: fix adding MAC error report miss X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Sep 2017 08:47:41 -0000 On Sun, Sep 03, 2017 at 06:26:45PM +0300, Matan Azrad wrote: > The corrupted code don't reply error in case of MAC > address adding failure while failsafe PMD was trying > to apply configuration to the sub device. > > Hence, the application may get unwanted packets. > > The fix adds error report for this case. > > Fixes: ebea83f899d8 ("net/failsafe: add plug-in support") > Cc: stable@dpdk.org > > Signed-off-by: Matan Azrad Acked-by: Gaetan Rivet > --- > drivers/net/failsafe/failsafe_ether.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/failsafe/failsafe_ether.c b/drivers/net/failsafe/failsafe_ether.c > index a3a8cce..fb9bbce 100644 > --- a/drivers/net/failsafe/failsafe_ether.c > +++ b/drivers/net/failsafe/failsafe_ether.c > @@ -203,6 +203,7 @@ fs_eth_dev_conf_apply(struct rte_eth_dev *dev, > > ether_format_addr(ea_fmt, ETHER_ADDR_FMT_SIZE, ea); > ERROR("Adding MAC address %s failed", ea_fmt); > + return ret; > } > } > /* VLAN filter */ > -- > 2.7.4 > -- Gaëtan Rivet 6WIND