* [dpdk-dev] [PATCH] net/failsafe: fix adding MAC error report miss
@ 2017-09-03 15:26 Matan Azrad
2017-09-04 8:47 ` Gaëtan Rivet
0 siblings, 1 reply; 3+ messages in thread
From: Matan Azrad @ 2017-09-03 15:26 UTC (permalink / raw)
To: Gaetan Rivet; +Cc: dev, stable
The corrupted code don't reply error in case of MAC
address adding failure while failsafe PMD was trying
to apply configuration to the sub device.
Hence, the application may get unwanted packets.
The fix adds error report for this case.
Fixes: ebea83f899d8 ("net/failsafe: add plug-in support")
Cc: stable@dpdk.org
Signed-off-by: Matan Azrad <matan@mellanox.com>
---
drivers/net/failsafe/failsafe_ether.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/failsafe/failsafe_ether.c b/drivers/net/failsafe/failsafe_ether.c
index a3a8cce..fb9bbce 100644
--- a/drivers/net/failsafe/failsafe_ether.c
+++ b/drivers/net/failsafe/failsafe_ether.c
@@ -203,6 +203,7 @@ fs_eth_dev_conf_apply(struct rte_eth_dev *dev,
ether_format_addr(ea_fmt, ETHER_ADDR_FMT_SIZE, ea);
ERROR("Adding MAC address %s failed", ea_fmt);
+ return ret;
}
}
/* VLAN filter */
--
2.7.4
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] net/failsafe: fix adding MAC error report miss
2017-09-03 15:26 [dpdk-dev] [PATCH] net/failsafe: fix adding MAC error report miss Matan Azrad
@ 2017-09-04 8:47 ` Gaëtan Rivet
2017-09-05 15:35 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
0 siblings, 1 reply; 3+ messages in thread
From: Gaëtan Rivet @ 2017-09-04 8:47 UTC (permalink / raw)
To: Matan Azrad; +Cc: dev, stable
On Sun, Sep 03, 2017 at 06:26:45PM +0300, Matan Azrad wrote:
> The corrupted code don't reply error in case of MAC
> address adding failure while failsafe PMD was trying
> to apply configuration to the sub device.
>
> Hence, the application may get unwanted packets.
>
> The fix adds error report for this case.
>
> Fixes: ebea83f899d8 ("net/failsafe: add plug-in support")
> Cc: stable@dpdk.org
>
> Signed-off-by: Matan Azrad <matan@mellanox.com>
Acked-by: Gaetan Rivet <gaetan.rivet@6wind.com>
> ---
> drivers/net/failsafe/failsafe_ether.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/failsafe/failsafe_ether.c b/drivers/net/failsafe/failsafe_ether.c
> index a3a8cce..fb9bbce 100644
> --- a/drivers/net/failsafe/failsafe_ether.c
> +++ b/drivers/net/failsafe/failsafe_ether.c
> @@ -203,6 +203,7 @@ fs_eth_dev_conf_apply(struct rte_eth_dev *dev,
>
> ether_format_addr(ea_fmt, ETHER_ADDR_FMT_SIZE, ea);
> ERROR("Adding MAC address %s failed", ea_fmt);
> + return ret;
> }
> }
> /* VLAN filter */
> --
> 2.7.4
>
--
Gaëtan Rivet
6WIND
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [dpdk-stable] [PATCH] net/failsafe: fix adding MAC error report miss
2017-09-04 8:47 ` Gaëtan Rivet
@ 2017-09-05 15:35 ` Ferruh Yigit
0 siblings, 0 replies; 3+ messages in thread
From: Ferruh Yigit @ 2017-09-05 15:35 UTC (permalink / raw)
To: Gaëtan Rivet, Matan Azrad; +Cc: dev, stable
On 9/4/2017 9:47 AM, Gaëtan Rivet wrote:
> On Sun, Sep 03, 2017 at 06:26:45PM +0300, Matan Azrad wrote:
>> The corrupted code don't reply error in case of MAC
>> address adding failure while failsafe PMD was trying
>> to apply configuration to the sub device.
>>
>> Hence, the application may get unwanted packets.
>>
>> The fix adds error report for this case.
>>
>> Fixes: ebea83f899d8 ("net/failsafe: add plug-in support")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Matan Azrad <matan@mellanox.com>
> Acked-by: Gaetan Rivet <gaetan.rivet@6wind.com>
Applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-09-05 15:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-03 15:26 [dpdk-dev] [PATCH] net/failsafe: fix adding MAC error report miss Matan Azrad
2017-09-04 8:47 ` Gaëtan Rivet
2017-09-05 15:35 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).