From: Bruce Richardson <bruce.richardson@intel.com>
To: Zhiyong Yang <zhiyong.yang@intel.com>
Cc: dev@dpdk.org, thomas@monjalon.net, ferruh.yigit@intel.com,
keith.wiles@intel.com, stephen@networkplumber.org
Subject: Re: [dpdk-dev] [PATCH v2 1/4] ethdev: increase port_id range
Date: Mon, 4 Sep 2017 10:06:59 +0100 [thread overview]
Message-ID: <20170904090658.GA17464@bricha3-MOBL3.ger.corp.intel.com> (raw)
In-Reply-To: <20170904055734.21354-2-zhiyong.yang@intel.com>
On Mon, Sep 04, 2017 at 01:57:31PM +0800, Zhiyong Yang wrote:
> Extend port_id definition from uint8_t to uint16_t in lib and drivers
> data structures, specifically rte_eth_dev_data. Modify the APIs,
> drivers and app using port_id at the same time except some drivers
> such as MLX4 and MLX5 due to fail to compile them in my server.
>
I think you can change those drivers too - it's not hard to set up
compilation for MLX drivers (instruction in DPDK docs on the website),
and even if you can't compile test them, e.g. dpaa2 drivers, or other
SoC ones, others can do so on your behalf. If you are going to change
drivers, I think you should change all of them across the board.
> Fix some checkpatch issues from the original code and remove some
> unnecessary cast operations.
>
> Signed-off-by: Zhiyong Yang <zhiyong.yang@intel.com>
> ---
> app/pdump/main.c | 2 +-
> app/test-eventdev/test_perf_common.h | 6 +-
> app/test-pmd/cmdline.c | 4 +-
> app/test-pmd/config.c | 4 +-
> app/test-pmd/testpmd.c | 18 +-
> app/test-pmd/testpmd.h | 2 +-
> drivers/event/octeontx/ssovf_evdev.c | 6 +-
> drivers/event/octeontx/ssovf_evdev.h | 4 +-
> drivers/event/skeleton/skeleton_eventdev.c | 4 +-
> drivers/event/skeleton/skeleton_eventdev.h | 2 +-
> drivers/event/sw/sw_evdev.c | 4 +-
> drivers/event/sw/sw_evdev.h | 6 +-
> drivers/event/sw/sw_evdev_xstats.c | 8 +-
These are not ethdev drivers, but eventdev ones. I don't think eventdev
needs to go to 16-bit port numbers, but there is no harm in doing so.
However, it would be best to modify eventdev drivers in a separate
patch - or even patchset.
> drivers/net/af_packet/rte_eth_af_packet.c | 2 +-
> drivers/net/ark/ark_ethdev.c | 2 +-
> drivers/net/ark/ark_udm.h | 2 +-
> drivers/net/avp/avp_ethdev.c | 2 +-
> drivers/net/bnx2x/bnx2x.c | 11 +-
> drivers/net/bnx2x/bnx2x_rxtx.h | 4 +-
> drivers/net/bnx2x/elink.c | 12 +-
> drivers/net/bnx2x/elink.h | 17 +-
> drivers/net/bnxt/bnxt.h | 2 +-
> drivers/net/bnxt/bnxt_ethdev.c | 8 +-
> drivers/net/bnxt/bnxt_rxq.h | 2 +-
> drivers/net/bnxt/bnxt_txq.h | 2 +-
> drivers/net/bnxt/rte_pmd_bnxt.c | 32 +--
> drivers/net/bnxt/rte_pmd_bnxt.h | 36 ++--
> drivers/net/bonding/rte_eth_bond.h | 42 ++--
> drivers/net/bonding/rte_eth_bond_8023ad.c | 6 +-
> drivers/net/bonding/rte_eth_bond_8023ad_private.h | 6 +-
> drivers/net/bonding/rte_eth_bond_api.c | 56 ++---
> drivers/net/bonding/rte_eth_bond_pmd.c | 30 +--
> drivers/net/bonding/rte_eth_bond_private.h | 43 ++--
> drivers/net/e1000/em_rxtx.c | 4 +-
> drivers/net/e1000/igb_rxtx.c | 4 +-
> drivers/net/failsafe/failsafe_ether.c | 4 +-
> drivers/net/failsafe/failsafe_private.h | 4 +-
> drivers/net/fm10k/fm10k.h | 6 +-
> drivers/net/i40e/i40e_ethdev.c | 5 +-
> drivers/net/i40e/i40e_rxtx.h | 4 +-
> drivers/net/i40e/rte_pmd_i40e.c | 50 ++---
> drivers/net/i40e/rte_pmd_i40e.h | 48 ++---
> drivers/net/ixgbe/ixgbe_ethdev.c | 5 +-
> drivers/net/ixgbe/ixgbe_rxtx.h | 4 +-
> drivers/net/ixgbe/rte_pmd_ixgbe.c | 60 +++---
> drivers/net/ixgbe/rte_pmd_ixgbe.h | 70 ++++---
> drivers/net/nfp/nfp_net.c | 26 +--
> drivers/net/nfp/nfp_net_pmd.h | 2 +-
> drivers/net/null/rte_eth_null.c | 2 +-
> drivers/net/pcap/rte_eth_pcap.c | 2 +-
> drivers/net/qede/qede_if.h | 2 +-
> drivers/net/ring/rte_eth_ring.c | 2 +-
> drivers/net/vhost/rte_eth_vhost.c | 8 +-
> drivers/net/vhost/rte_eth_vhost.h | 6 +-
> drivers/net/virtio/virtio_pci.h | 2 +-
> drivers/net/virtio/virtio_rxtx.h | 6 +-
> drivers/net/xenvirt/virtqueue.h | 2 +-
> lib/librte_bitratestats/rte_bitrate.c | 2 +-
> lib/librte_bitratestats/rte_bitrate.h | 2 +-
> lib/librte_ether/rte_ethdev.c | 239 +++++++++++-----------
> lib/librte_ether/rte_ethdev.h | 238 ++++++++++-----------
> lib/librte_ether/rte_tm.c | 62 +++---
> lib/librte_ether/rte_tm.h | 60 +++---
> lib/librte_ether/rte_tm_driver.h | 2 +-
> lib/librte_eventdev/rte_eventdev.c | 36 ++--
> lib/librte_eventdev/rte_eventdev.h | 34 +--
> lib/librte_eventdev/rte_eventdev_pmd.h | 8 +-
eventdev changes should be separte patches from ethdev.
> lib/librte_kni/rte_kni.h | 6 +-
> lib/librte_latencystats/rte_latencystats.c | 12 +-
> lib/librte_pdump/rte_pdump.c | 16 +-
> lib/librte_pdump/rte_pdump.h | 4 +-
> lib/librte_port/rte_port_ethdev.c | 6 +-
> lib/librte_port/rte_port_ethdev.h | 6 +-
> 73 files changed, 733 insertions(+), 715 deletions(-)
>
next prev parent reply other threads:[~2017-09-04 9:07 UTC|newest]
Thread overview: 101+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-09 8:42 [dpdk-dev] [PATCH 0/2] " Zhiyong Yang
2017-08-09 8:42 ` [dpdk-dev] [PATCH 1/2] ethdev: " Zhiyong Yang
2017-08-09 12:52 ` Ferruh Yigit
2017-08-09 12:57 ` Wiles, Keith
2017-08-10 0:53 ` Yang, Zhiyong
2017-08-10 0:51 ` Yang, Zhiyong
2017-08-09 8:42 ` [dpdk-dev] [PATCH 2/2] examples: " Zhiyong Yang
2017-08-09 14:48 ` Stephen Hemminger
2017-08-10 1:03 ` Yang, Zhiyong
2017-08-09 9:00 ` [dpdk-dev] [PATCH 0/2] " De Lara Guarch, Pablo
2017-08-09 9:17 ` Yang, Zhiyong
2017-09-04 5:57 ` [dpdk-dev] [PATCH v2 0/4] " Zhiyong Yang
2017-09-04 5:57 ` [dpdk-dev] [PATCH v2 1/4] ethdev: " Zhiyong Yang
2017-09-04 9:06 ` Bruce Richardson [this message]
2017-09-04 9:29 ` Ferruh Yigit
2017-09-04 9:47 ` Yang, Zhiyong
2017-09-04 13:12 ` Adrien Mazarguil
2017-09-04 13:17 ` Richardson, Bruce
2017-09-04 13:36 ` Adrien Mazarguil
2017-09-04 13:59 ` Yang, Zhiyong
2017-09-04 14:41 ` Adrien Mazarguil
2017-09-05 6:51 ` Yang, Zhiyong
2017-09-06 8:32 ` Hemant Agrawal
2017-09-06 8:48 ` Yang, Zhiyong
[not found] ` <CALZ3Guikt9x8sz-oEKCuDCSp_wtKa64bSXTrMhqcWyg7f_dS7g@mail.gmail.com>
2017-09-07 0:45 ` Yang, Zhiyong
2017-09-04 5:57 ` [dpdk-dev] [PATCH v2 2/4] examples: " Zhiyong Yang
2017-09-04 14:15 ` Hunt, David
2017-09-04 15:01 ` Yang, Zhiyong
2017-09-04 5:57 ` [dpdk-dev] [PATCH v2 3/4] common_base: extend RTE_MAX_ETHPORTS from 32 to 1024 Zhiyong Yang
2017-09-04 7:46 ` Yao, Lei A
2017-09-04 7:59 ` Yang, Zhiyong
2017-09-04 9:09 ` Bruce Richardson
2017-09-04 10:05 ` Yang, Zhiyong
2017-09-04 10:27 ` Ananyev, Konstantin
2017-09-04 14:18 ` Yang, Zhiyong
2017-09-06 8:42 ` Hemant Agrawal
2017-09-06 8:52 ` Yang, Zhiyong
2017-09-04 10:29 ` Bruce Richardson
2017-09-04 9:27 ` Ananyev, Konstantin
2017-09-04 5:57 ` [dpdk-dev] [PATCH v2 4/4] testpmd: add flexibility to mbuf allocation Zhiyong Yang
2017-09-09 14:47 ` [dpdk-dev] [PATCH v3 0/4] increase port_id range Zhiyong Yang
2017-09-09 14:47 ` [dpdk-dev] [PATCH v3 1/4] ethdev: " Zhiyong Yang
2017-09-11 9:37 ` Adrien Mazarguil
2017-09-11 10:51 ` Yang, Zhiyong
2017-09-11 10:21 ` Ferruh Yigit
2017-09-13 2:26 ` Yang, Zhiyong
2017-09-13 11:56 ` Ferruh Yigit
2017-09-13 12:15 ` Yang, Zhiyong
2017-09-13 12:18 ` Thomas Monjalon
2017-09-13 13:33 ` Ferruh Yigit
2017-09-19 6:05 ` Yang, Zhiyong
2017-09-19 12:30 ` Wiles, Keith
2017-09-14 12:49 ` Ferruh Yigit
2017-09-15 5:11 ` Yang, Zhiyong
2017-09-09 14:47 ` [dpdk-dev] [PATCH v3 2/4] test: " Zhiyong Yang
2017-09-09 14:47 ` [dpdk-dev] [PATCH v3 3/4] examples: " Zhiyong Yang
2017-09-14 14:41 ` Ferruh Yigit
2017-09-09 14:47 ` [dpdk-dev] [PATCH v3 4/4] librte_mbuf: modify port initialization value Zhiyong Yang
2017-09-11 10:23 ` [dpdk-dev] [PATCH v3 0/4] increase port_id range Ferruh Yigit
2017-09-11 11:25 ` Yang, Zhiyong
2017-09-13 8:14 ` Matej Vido
2017-09-13 8:21 ` Yang, Zhiyong
2017-09-18 14:54 ` Laatz, Kevin
2017-09-19 1:39 ` Yang, Zhiyong
2017-09-11 10:26 ` Ferruh Yigit
2017-09-11 10:55 ` Yang, Zhiyong
2017-09-11 11:24 ` Ferruh Yigit
2017-09-21 8:32 ` [dpdk-dev] [PATCH v4 0/5] " Zhiyong Yang
2017-09-21 8:32 ` [dpdk-dev] [PATCH v4 1/5] net/bonding: remove bonding APIs using ABI versioning Zhiyong Yang
2017-09-21 10:36 ` Ferruh Yigit
2017-09-22 2:02 ` Yang, Zhiyong
2017-09-21 8:32 ` [dpdk-dev] [PATCH v4 2/5] ethdev: increase port_id range Zhiyong Yang
2017-09-21 11:49 ` Adrien Mazarguil
2017-10-06 14:34 ` Nélio Laranjeiro
2017-09-21 8:32 ` [dpdk-dev] [PATCH v4 3/5] examples: " Zhiyong Yang
2017-09-21 8:32 ` [dpdk-dev] [PATCH v4 4/5] test: " Zhiyong Yang
2017-09-21 8:32 ` [dpdk-dev] [PATCH v4 5/5] librte_mbuf: modify port initialization value Zhiyong Yang
2017-09-25 3:22 ` [dpdk-dev] [PATCH v5 0/5] increase port_id range Zhiyong Yang
2017-09-25 3:22 ` [dpdk-dev] [PATCH v5 1/5] net/bonding: remove bonding APIs using ABI versioning Zhiyong Yang
2017-09-25 11:34 ` Ferruh Yigit
2017-09-25 3:22 ` [dpdk-dev] [PATCH v5 2/5] ethdev: increase port_id range Zhiyong Yang
2017-09-25 11:37 ` Ferruh Yigit
2017-09-25 12:06 ` Ferruh Yigit
2017-09-26 7:01 ` Yang, Zhiyong
2017-09-27 18:44 ` Ferruh Yigit
2017-09-28 2:12 ` Yang, Zhiyong
2017-09-25 3:22 ` [dpdk-dev] [PATCH v5 3/5] examples: " Zhiyong Yang
2017-09-25 3:22 ` [dpdk-dev] [PATCH v5 4/5] test: " Zhiyong Yang
2017-09-25 3:22 ` [dpdk-dev] [PATCH v5 5/5] librte_mbuf: modify port initialization value Zhiyong Yang
2017-09-29 7:17 ` [dpdk-dev] [PATCH v6 0/5] increase port_id range Zhiyong Yang
2017-09-29 7:17 ` [dpdk-dev] [PATCH v6 1/5] net/bonding: remove bonding APIs using ABI versioning Zhiyong Yang
2017-09-29 7:17 ` [dpdk-dev] [PATCH v6 2/5] ethdev: increase port_id range Zhiyong Yang
2017-09-29 7:17 ` [dpdk-dev] [PATCH v6 3/5] examples: " Zhiyong Yang
2017-09-29 7:17 ` [dpdk-dev] [PATCH v6 4/5] test: " Zhiyong Yang
2017-09-29 7:17 ` [dpdk-dev] [PATCH v6 5/5] librte_mbuf: modify port initialization value Zhiyong Yang
2017-10-06 2:15 ` [dpdk-dev] [PATCH v6 0/5] increase port_id range Ferruh Yigit
2017-10-06 13:31 ` Gaëtan Rivet
2017-10-06 14:29 ` Thomas Monjalon
2017-10-06 16:02 ` Thomas Monjalon
2017-10-11 21:21 ` Ferruh Yigit
2017-10-12 1:33 ` Yang, Zhiyong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170904090658.GA17464@bricha3-MOBL3.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=keith.wiles@intel.com \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
--cc=zhiyong.yang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).