From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id A9D2537AC for ; Mon, 4 Sep 2017 11:09:09 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga105.jf.intel.com with ESMTP; 04 Sep 2017 02:09:08 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,474,1498546800"; d="scan'208";a="1168906046" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.221.24]) by orsmga001.jf.intel.com with SMTP; 04 Sep 2017 02:09:04 -0700 Received: by (sSMTP sendmail emulation); Mon, 04 Sep 2017 10:09:04 +0100 Date: Mon, 4 Sep 2017 10:09:03 +0100 From: Bruce Richardson To: "Yang, Zhiyong" Cc: "Yao, Lei A" , "dev@dpdk.org" , "thomas@monjalon.net" , "Yigit, Ferruh" , "Wiles, Keith" , "stephen@networkplumber.org" Message-ID: <20170904090903.GB17464@bricha3-MOBL3.ger.corp.intel.com> References: <20170809084203.17562-1-zhiyong.yang@intel.com> <20170904055734.21354-1-zhiyong.yang@intel.com> <20170904055734.21354-4-zhiyong.yang@intel.com> <2DBBFF226F7CF64BAFCA79B681719D953A266703@shsmsx102.ccr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Research and =?iso-8859-1?Q?De=ACvel?= =?iso-8859-1?Q?opment?= Ireland Ltd. User-Agent: Mutt/1.8.3 (2017-05-23) Subject: Re: [dpdk-dev] [PATCH v2 3/4] common_base: extend RTE_MAX_ETHPORTS from 32 to 1024 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Sep 2017 09:09:10 -0000 On Mon, Sep 04, 2017 at 07:59:29AM +0000, Yang, Zhiyong wrote: > Hi, Lei: > > > -----Original Message----- > > From: Yao, Lei A > > Sent: Monday, September 4, 2017 3:46 PM > > To: Yang, Zhiyong ; dev@dpdk.org > > Cc: thomas@monjalon.net; Yigit, Ferruh ; Wiles, Keith > > ; stephen@networkplumber.org; Yang, Zhiyong > > > > Subject: RE: [dpdk-dev] [PATCH v2 3/4] common_base: extend > > RTE_MAX_ETHPORTS from 32 to 1024 > > > > > > > > > -----Original Message----- > > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Zhiyong Yang > > > Sent: Monday, September 4, 2017 1:58 PM > > > To: dev@dpdk.org > > > Cc: thomas@monjalon.net; Yigit, Ferruh ; > > > Wiles, Keith ; stephen@networkplumber.org; > > > Yang, Zhiyong > > > Subject: [dpdk-dev] [PATCH v2 3/4] common_base: extend > > > RTE_MAX_ETHPORTS from 32 to 1024 > > > > > > The reasons to modify RTE_MAX_ETHPORTS is the following. > > > > > > 1. RTE_MAX_ETHPORTS=32 by default has not met user's requirements with > > > development of virtualization technology. Some vdev users have to > > > modify the setting before the compiling. > > > > > > 2. port_id have been extended to 16 bits definition. But for many > > > samples such as testpmd, l3fwd, num of port is still limited to > > > RTE_MAX_ETHPORTS=32 by default. This may limit usage of 16 bits > > > port_id. > > > > > > So, it is necessary to enlarge RTE_MAX_ETHPORTS to more than 256. > > > > > > Signed-off-by: Zhiyong Yang > > > --- > > > config/common_base | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/config/common_base b/config/common_base index > > > 5e97a08b6..dccc13e31 100644 > > > --- a/config/common_base > > > +++ b/config/common_base > > > @@ -131,7 +131,7 @@ CONFIG_RTE_LIBRTE_KVARGS=y # > > > CONFIG_RTE_LIBRTE_ETHER=y CONFIG_RTE_LIBRTE_ETHDEV_DEBUG=n > > > -CONFIG_RTE_MAX_ETHPORTS=32 > > > +CONFIG_RTE_MAX_ETHPORTS=1024 > > > CONFIG_RTE_MAX_QUEUES_PER_PORT=1024 > > > CONFIG_RTE_LIBRTE_IEEE1588=n > > > CONFIG_RTE_ETHDEV_QUEUE_STAT_CNTRS=16 > > > -- > > > 2.13.3 > > Hi, Zhiyong > > > > I met one issue for changing CONFIG_RTE_MAX_ETHPORTS to 1024. > > One process can only open 1024 file as maximum in common linux distribution, > > after practice, only 1009 socket file can be used for vdev device with testpmd > > sample. > > Thanks for your info. It seems that 1024 is too large and may bring some potential issues. > > Thanks > Zhiyong > It should be possible to have a dynamically allocated ethdev array, which would allow use to have a default value - which could be e.g. 32 or 64 as now - while also allowing a run-time parameter to increase that to thousands if needed. /Bruce