From: Bruce Richardson <bruce.richardson@intel.com>
To: "Van Haaren, Harry" <harry.van.haaren@intel.com>
Cc: "Gonzalez Monroy, Sergio" <sergio.gonzalez.monroy@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"Ananyev, Konstantin" <konstantin.ananyev@intel.com>
Subject: Re: [dpdk-dev] [PATCH] eal/x86: implement x86 specific tsc hz
Date: Mon, 4 Sep 2017 11:32:36 +0100 [thread overview]
Message-ID: <20170904103236.GC16984@bricha3-MOBL3.ger.corp.intel.com> (raw)
In-Reply-To: <20170904102407.GA16984@bricha3-MOBL3.ger.corp.intel.com>
On Mon, Sep 04, 2017 at 11:24:07AM +0100, Bruce Richardson wrote:
> On Mon, Sep 04, 2017 at 10:38:08AM +0100, Van Haaren, Harry wrote:
> > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Sergio Gonzalez Monroy
> > > Sent: Wednesday, August 23, 2017 4:00 PM
> > > To: dev@dpdk.org
> > > Cc: Ananyev, Konstantin <konstantin.ananyev@intel.com>; Richardson, Bruce
> > > <bruce.richardson@intel.com>
> > > Subject: [dpdk-dev] [PATCH] eal/x86: implement x86 specific tsc hz
> > >
<snip>
> > +
> > > +static uint32_t
> > > +check_model_wsm_nhm(uint8_t model)
> > > +{
> > > + switch (model) {
> > > + /* Westmere */
> > > + case 0x25:
> > > + case 0x2C:
> > > + case 0x2F:
> > > + /* Nehalem */
> > > + case 0x1E:
> > > + case 0x1F:
> > > + case 0x1A:
> > > + case 0x2E:
> > > + return 1;
> > > + }
> >
> > DPDK coding standards say /* fallthrough */ comments required when falling through cases.
> > In this case I feel it would reduce readability, more than it improves it, but I recall
> > some recent gcc/clang prints warnings if no /* fallthrough */ comments exist.. opinions?
> >
> > Same for switch() below.
> >
>
> I see no warnings in this case with gcc 7.x. I don't think it counts as
> a fallthrough unless there is code after the label - i.e. multiple
> labels though technically fallthrough are treated as such by compiler.
>
apologies, typo: ... are NOT treated as such ...
next prev parent reply other threads:[~2017-09-04 10:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-23 15:00 Sergio Gonzalez Monroy
2017-08-23 15:00 ` [dpdk-dev] [PATCH] eal/x86: use cpuid builtin Sergio Gonzalez Monroy
2017-10-04 23:39 ` Ferruh Yigit
2017-10-11 20:00 ` Thomas Monjalon
2017-09-04 9:38 ` [dpdk-dev] [PATCH] eal/x86: implement x86 specific tsc hz Van Haaren, Harry
2017-09-04 10:24 ` Bruce Richardson
2017-09-04 10:32 ` Bruce Richardson [this message]
2017-10-02 10:09 ` [dpdk-dev] [PATCH v2] " Sergio Gonzalez Monroy
2017-10-02 11:17 ` [dpdk-dev] [PATCH v3] " Sergio Gonzalez Monroy
2017-10-02 11:24 ` Jerin Jacob
2017-10-02 11:27 ` Sergio Gonzalez Monroy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170904103236.GC16984@bricha3-MOBL3.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=harry.van.haaren@intel.com \
--cc=konstantin.ananyev@intel.com \
--cc=sergio.gonzalez.monroy@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).