From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 6584B376C for ; Mon, 4 Sep 2017 15:51:16 +0200 (CEST) Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Sep 2017 06:51:05 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,474,1498546800"; d="scan'208";a="145301174" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.221.24]) by orsmga005.jf.intel.com with SMTP; 04 Sep 2017 06:51:03 -0700 Received: by (sSMTP sendmail emulation); Mon, 04 Sep 2017 14:51:02 +0100 Date: Mon, 4 Sep 2017 14:51:01 +0100 From: Bruce Richardson To: "Van Haaren, Harry" Cc: "dev@dpdk.org" Message-ID: <20170904135101.GB22056@bricha3-MOBL3.ger.corp.intel.com> References: <20170901100416.80264-1-bruce.richardson@intel.com> <20170901100416.80264-2-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Research and =?iso-8859-1?Q?De=ACvel?= =?iso-8859-1?Q?opment?= Ireland Ltd. User-Agent: Mutt/1.8.3 (2017-05-23) Subject: Re: [dpdk-dev] [PATCH 01/17] build: add initial infrastructure for meson & ninja builds X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Sep 2017 13:51:16 -0000 On Mon, Sep 04, 2017 at 02:36:42PM +0100, Van Haaren, Harry wrote: > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Bruce Richardson > > Sent: Friday, September 1, 2017 11:04 AM > > To: dev@dpdk.org > > Cc: Richardson, Bruce > > Subject: [dpdk-dev] [PATCH 01/17] build: add initial infrastructure for meson & ninja builds > > > > To build with meson and ninja, we need some initial infrastructure in > > place. The build files for meson always need to be called "meson.build", > > and options get placed in meson_options.txt > > > > This commit adds a top-level meson.build file, which sets up the global > > variables for tracking drivers, libraries, etc., and then includes other > > build files, before finishing by writing the global build configuration > > header file and a DPDK pkgconfig file at the end, using some of those same > > globals. > > > > From the top level build file, the only include file thus far is for the > > config folder, which does some other setup of global configuration > > parameters, including pulling in architecture specific parameters from an > > architectural subdirectory. A number of configuration build options are > > provided for the project to tune a number of global variables which will be > > used later e.g. max numa nodes, max cores, etc. These settings all make > > their way to the global build config header "rte_build_config.h". There is > > also a file "rte_config.h", which includes "rte_build_config.h", and this > > file is meant to hold other build-time values which are present in our > > current static build configuration but are not normally meant for > > user-configuration. Ideally, over time, the values placed here should be > > moved to the individual libraries or drivers which want those values. > > > > Signed-off-by: Bruce Richardson > > Comments inline below; > > > > > diff --git a/config/meson.build b/config/meson.build > > > +# disable any unwanted warnings > > +unwanted_warnings = [ > > + '-Wno-address-of-packed-member', > > + '-Wno-format-truncation' > > +] > > +foreach arg: unwanted_warnings > > + if cc.has_argument(arg) > > + add_project_arguments(arg, language: 'c') > > + endif > > +endforeach > > I can't fault the code here, or Meson, just noting that the disabling of these warnings causes prints on GCC 4.8.5 and GCC 5.4.0, GCC 7 only prints on -Wno-address-of-packed-member. Clang handles it correctly - and no out-of-the-ordinary prints occur. No code changes required here. > Strange. Just tested with gcc 4.8.5 and gcc 5.4, and everything worked as expected, no errors or warnings. > > > diff --git a/config/rte_config.h b/config/rte_config.h > > new file mode 100644 > > index 000000000..79b0db90f > > --- /dev/null > > +++ b/config/rte_config.h > > @@ -0,0 +1,50 @@ > > +/* > > + * BSD LICENSE > > + * > > + * Copyright(c) 2016 Intel Corporation. All rights reserved. > > + * All rights reserved. > > 2017 for license year Good catch, will fix in V2. > > > > Reviewed-by: Harry van Haaren