From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.droids-corp.org (zoll.droids-corp.org [94.23.50.67]) by dpdk.org (Postfix) with ESMTP id D31EC3770 for ; Mon, 4 Sep 2017 16:12:01 +0200 (CEST) Received: from lfbn-1-18623-73.w90-103.abo.wanadoo.fr ([90.103.154.73] helo=droids-corp.org) by mail.droids-corp.org with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1dosBz-0008Dj-GF; Mon, 04 Sep 2017 16:17:36 +0200 Received: by droids-corp.org (sSMTP sendmail emulation); Mon, 04 Sep 2017 16:11:54 +0200 Date: Mon, 4 Sep 2017 16:11:54 +0200 From: Olivier MATZ To: Santosh Shukla Cc: dev@dpdk.org, thomas@monjalon.net, jerin.jacob@caviumnetworks.com, hemant.agrawal@nxp.com Message-ID: <20170904141154.vpj3hhmzp7pkjpg3@neon> References: <20170720134759.4680-1-santosh.shukla@caviumnetworks.com> <20170815060743.21076-1-santosh.shukla@caviumnetworks.com> <20170815060743.21076-2-santosh.shukla@caviumnetworks.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170815060743.21076-2-santosh.shukla@caviumnetworks.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [PATCH v4 1/7] mempool: fix flags data type X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Sep 2017 14:12:02 -0000 On Tue, Aug 15, 2017 at 11:37:37AM +0530, Santosh Shukla wrote: > mp->flags is int and mempool API updates unsigned int > value in 'flags', so fix the 'flags' data type. > > Patch also does mp->flags cleanup like: > * Remove redundant 'flags' API description from > - __rte_mempool_generic_put > - __rte_mempool_generic_get > > * Remove unused 'flags' param from > - rte_mempool_generic_put > - rte_mempool_generic_get > > * Fix mempool var data types int mempool.c > - mz_flags is int, Change it to unsigned int. This bullet list makes me think that we should have at least 2 commits: mempool: remove unused flags argument mempool: change flags from int to unsigned int