From: Bruce Richardson <bruce.richardson@intel.com>
To: Jianfeng Tan <jianfeng.tan@intel.com>
Cc: dev@dpdk.org, xen-devel@lists.xenproject.org,
thomas@monjalon.net, john.mcnamara@intel.com,
oao.m.martins@oracle.com, jerin.jacob@caviumnetworks.com,
shahafs@mellanox.com
Subject: Re: [dpdk-dev] [PATCH 3/6] xen: remove xen dependency in app, examples, test
Date: Mon, 4 Sep 2017 15:24:57 +0100 [thread overview]
Message-ID: <20170904142457.GB11856@bricha3-MOBL3.ger.corp.intel.com> (raw)
In-Reply-To: <1504116634-115687-4-git-send-email-jianfeng.tan@intel.com>
On Wed, Aug 30, 2017 at 06:10:31PM +0000, Jianfeng Tan wrote:
> Signed-off-by: Jianfeng Tan <jianfeng.tan@intel.com>
> ---
> app/test-pmd/testpmd.c | 2 +-
> examples/ip_pipeline/app.h | 4 --
> examples/ip_pipeline/config_parse.c | 19 ---------
> examples/ip_pipeline/init.c | 5 ---
> examples/kni/main.c | 3 --
> test/test/process.h | 10 -----
> test/test/test.c | 4 --
> test/test/test_eal_flags.c | 81 -------------------------------------
> 8 files changed, 1 insertion(+), 127 deletions(-)
>
> diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
> index f8d02ae..d9c785c 100644
> --- a/app/test-pmd/testpmd.c
> +++ b/app/test-pmd/testpmd.c
> @@ -494,7 +494,7 @@ mbuf_pool_create(uint16_t mbuf_seg_size, unsigned nb_mbuf,
> "create a new mbuf pool <%s>: n=%u, size=%u, socket=%u\n",
> pool_name, nb_mbuf, mbuf_seg_size, socket_id);
>
> - /* if the former XEN allocation failed fall back to normal allocation */
> + /* if the former allocation failed fall back to normal allocation */
> if (rte_mp == NULL) {
> if (mp_anon != 0) {
> rte_mp = rte_mempool_create_empty(pool_name, nb_mbuf,
There is no former allocation here, so I think the previous patch, which
removed the #ifdef block should also remove this comment entirely, and
the "if (rte_mp == NULL)" too
next prev parent reply other threads:[~2017-09-04 14:25 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-30 18:10 [dpdk-dev] [PATCH 0/6] remove xen dom0 support in DPDK Jianfeng Tan
2017-08-30 18:10 ` [dpdk-dev] [PATCH 1/6] example/vhost_xen: remove Jianfeng Tan
2017-09-04 14:14 ` Bruce Richardson
2017-08-30 18:10 ` [dpdk-dev] [PATCH 2/6] net/xenvirt: remove Jianfeng Tan
2017-09-04 14:25 ` Bruce Richardson
2017-09-04 14:50 ` Bruce Richardson
2017-08-30 18:10 ` [dpdk-dev] [PATCH 3/6] xen: remove xen dependency in app, examples, test Jianfeng Tan
2017-09-04 14:24 ` Bruce Richardson [this message]
2017-09-04 14:51 ` Bruce Richardson
2017-08-30 18:10 ` [dpdk-dev] [PATCH 4/6] xen: remove xen dependency in drivers, ether, mempool Jianfeng Tan
2017-09-04 14:51 ` Bruce Richardson
2017-08-30 18:10 ` [dpdk-dev] [PATCH 5/6] eal: remove xen dom0 support Jianfeng Tan
2017-09-04 14:43 ` Bruce Richardson
2017-09-04 14:49 ` Bruce Richardson
2017-09-05 3:41 ` Tan, Jianfeng
2017-09-05 7:31 ` Thomas Monjalon
2017-09-05 8:07 ` Tan, Jianfeng
2017-09-05 8:34 ` Thomas Monjalon
2017-08-30 18:10 ` [dpdk-dev] [PATCH 6/6] eal: remove API rte_mem_phy2mch Jianfeng Tan
2017-09-04 14:52 ` Bruce Richardson
2017-08-31 8:44 ` [dpdk-dev] [Xen-devel] [PATCH 0/6] remove xen dom0 support in DPDK Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170904142457.GB11856@bricha3-MOBL3.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=jerin.jacob@caviumnetworks.com \
--cc=jianfeng.tan@intel.com \
--cc=john.mcnamara@intel.com \
--cc=oao.m.martins@oracle.com \
--cc=shahafs@mellanox.com \
--cc=thomas@monjalon.net \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).