From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id DDAD67CA9 for ; Mon, 4 Sep 2017 16:25:02 +0200 (CEST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Sep 2017 07:25:01 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,475,1498546800"; d="scan'208";a="131551176" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.221.24]) by orsmga002.jf.intel.com with SMTP; 04 Sep 2017 07:24:58 -0700 Received: by (sSMTP sendmail emulation); Mon, 04 Sep 2017 15:24:57 +0100 Date: Mon, 4 Sep 2017 15:24:57 +0100 From: Bruce Richardson To: Jianfeng Tan Cc: dev@dpdk.org, xen-devel@lists.xenproject.org, thomas@monjalon.net, john.mcnamara@intel.com, oao.m.martins@oracle.com, jerin.jacob@caviumnetworks.com, shahafs@mellanox.com Message-ID: <20170904142457.GB11856@bricha3-MOBL3.ger.corp.intel.com> References: <1504116634-115687-1-git-send-email-jianfeng.tan@intel.com> <1504116634-115687-4-git-send-email-jianfeng.tan@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1504116634-115687-4-git-send-email-jianfeng.tan@intel.com> Organization: Intel Research and =?iso-8859-1?Q?De=ACvel?= =?iso-8859-1?Q?opment?= Ireland Ltd. User-Agent: Mutt/1.8.3 (2017-05-23) Subject: Re: [dpdk-dev] [PATCH 3/6] xen: remove xen dependency in app, examples, test X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Sep 2017 14:25:03 -0000 On Wed, Aug 30, 2017 at 06:10:31PM +0000, Jianfeng Tan wrote: > Signed-off-by: Jianfeng Tan > --- > app/test-pmd/testpmd.c | 2 +- > examples/ip_pipeline/app.h | 4 -- > examples/ip_pipeline/config_parse.c | 19 --------- > examples/ip_pipeline/init.c | 5 --- > examples/kni/main.c | 3 -- > test/test/process.h | 10 ----- > test/test/test.c | 4 -- > test/test/test_eal_flags.c | 81 ------------------------------------- > 8 files changed, 1 insertion(+), 127 deletions(-) > > diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c > index f8d02ae..d9c785c 100644 > --- a/app/test-pmd/testpmd.c > +++ b/app/test-pmd/testpmd.c > @@ -494,7 +494,7 @@ mbuf_pool_create(uint16_t mbuf_seg_size, unsigned nb_mbuf, > "create a new mbuf pool <%s>: n=%u, size=%u, socket=%u\n", > pool_name, nb_mbuf, mbuf_seg_size, socket_id); > > - /* if the former XEN allocation failed fall back to normal allocation */ > + /* if the former allocation failed fall back to normal allocation */ > if (rte_mp == NULL) { > if (mp_anon != 0) { > rte_mp = rte_mempool_create_empty(pool_name, nb_mbuf, There is no former allocation here, so I think the previous patch, which removed the #ifdef block should also remove this comment entirely, and the "if (rte_mp == NULL)" too