From: Guduri Prathyusha <gprathyusha@caviumnetworks.com>
To: harry.van.haaren@intel.com
Cc: dev@dpdk.org, Guduri Prathyusha <gprathyusha@caviumnetworks.com>
Subject: [dpdk-dev] [PATCH] service: fix service lcore stop function
Date: Tue, 5 Sep 2017 14:23:33 +0530 [thread overview]
Message-ID: <20170905085333.8301-1-gprathyusha@caviumnetworks.com> (raw)
lcore_states store the state of the lcore. Fixing the invalid
dereference of lcore_states with service number
Fixes: 21698354c832 ("service: introduce service cores concept")
Signed-off-by: Guduri Prathyusha <gprathyusha@caviumnetworks.com>
---
lib/librte_eal/common/rte_service.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/librte_eal/common/rte_service.c b/lib/librte_eal/common/rte_service.c
index 7efb76dc8..2ac77cc2a 100644
--- a/lib/librte_eal/common/rte_service.c
+++ b/lib/librte_eal/common/rte_service.c
@@ -609,7 +609,7 @@ rte_service_lcore_stop(uint32_t lcore)
uint32_t i;
for (i = 0; i < RTE_SERVICE_NUM_MAX; i++) {
int32_t enabled =
- lcore_states[i].service_mask & (UINT64_C(1) << i);
+ lcore_states[lcore].service_mask & (UINT64_C(1) << i);
int32_t service_running = rte_services[i].runstate !=
RUNSTATE_STOPPED;
int32_t only_core = rte_services[i].num_mapped_cores == 1;
--
2.14.1
reply other threads:[~2017-09-05 8:54 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170905085333.8301-1-gprathyusha@caviumnetworks.com \
--to=gprathyusha@caviumnetworks.com \
--cc=dev@dpdk.org \
--cc=harry.van.haaren@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).