From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 134F82BF3 for ; Tue, 5 Sep 2017 15:18:40 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Sep 2017 06:18:40 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,480,1498546800"; d="scan'208";a="1169265940" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.221.24]) by orsmga001.jf.intel.com with SMTP; 05 Sep 2017 06:18:36 -0700 Received: by (sSMTP sendmail emulation); Tue, 05 Sep 2017 14:18:35 +0100 Date: Tue, 5 Sep 2017 14:18:35 +0100 From: Bruce Richardson To: Harry van Haaren Cc: dev@dpdk.org Message-ID: <20170905131834.GA21636@bricha3-MOBL3.ger.corp.intel.com> References: <1504616613-46803-1-git-send-email-harry.van.haaren@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1504616613-46803-1-git-send-email-harry.van.haaren@intel.com> Organization: Intel Research and =?iso-8859-1?Q?De=ACvel?= =?iso-8859-1?Q?opment?= Ireland Ltd. User-Agent: Mutt/1.8.3 (2017-05-23) Subject: Re: [dpdk-dev] [PATCH] buildtools: zero elf info variable in pmdinfogen X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Sep 2017 13:18:41 -0000 On Tue, Sep 05, 2017 at 02:03:33PM +0100, Harry van Haaren wrote: > This commit zeros out the elf_info struct at startup of the > pmdinfogen code. If it is not zeroed, later in the code gcc > produces "may be unused" prints. Clang does not report any > issue. > > This commit enables a simplification in the meson build > system, removing the requirement for "-Wno-maybe-uninitialized". > > Signed-off-by: Harry van Haaren It's worth adding to the commit message that this error only shows up in optimized builds, which is why the warning is not disabled by default in the existing makefile. > --- > > buildtools/pmdinfogen/pmdinfogen.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/buildtools/pmdinfogen/pmdinfogen.c b/buildtools/pmdinfogen/pmdinfogen.c > index ba1a12e..e73fc76 100644 > --- a/buildtools/pmdinfogen/pmdinfogen.c > +++ b/buildtools/pmdinfogen/pmdinfogen.c > @@ -397,7 +397,7 @@ static void output_pmd_info_string(struct elf_info *info, char *outfile) > > int main(int argc, char **argv) > { > - struct elf_info info; > + struct elf_info info = {0}; > int rc = 1; > > if (argc < 3) { > -- > 2.7.4 >