From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-BL2-obe.outbound.protection.outlook.com (mail-bl2nam02on0082.outbound.protection.outlook.com [104.47.38.82]) by dpdk.org (Postfix) with ESMTP id 9DB4D3DC for ; Wed, 6 Sep 2017 08:12:33 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=8ZJpFMs4MfA9S0hiTYkk0fFvJmCv5olZtb7s3PiZhAk=; b=PyJwmzynz3JfoWBP527K8XItor1V2B9sZs+kvjqW1+FidzLGvoMme0ZPSzLYWwInoL77xYxeoes8NacRfl5y+slAmdIrbfN+L+qa2cJVg6vdSA3Ptkq+rKrHr/YnPPwE1WvN4s0s7wJD/52Xhpa2zKbVwKgaaewIgmSLCmGru6s= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.JacobKollanukkaran@cavium.com; Received: from jerin (111.93.218.67) by CY1PR07MB2522.namprd07.prod.outlook.com (10.167.16.13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.13.10; Wed, 6 Sep 2017 06:12:30 +0000 Date: Wed, 6 Sep 2017 11:42:09 +0530 From: Jerin Jacob To: Tim McDaniel Cc: dev@dpdk.org Message-ID: <20170906061208.GA2883@jerin> References: <1504646088-3476-1-git-send-email-timothy.mcdaniel@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1504646088-3476-1-git-send-email-timothy.mcdaniel@intel.com> User-Agent: Mutt/1.9.0 (2017-09-02) X-Originating-IP: [111.93.218.67] X-ClientProxiedBy: BMXPR01CA0022.INDPRD01.PROD.OUTLOOK.COM (10.174.214.160) To CY1PR07MB2522.namprd07.prod.outlook.com (10.167.16.13) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b974cbff-3884-4b0a-9ae6-08d4f4ee4279 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(300000502095)(300135100095)(22001)(2017030254152)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:CY1PR07MB2522; X-Microsoft-Exchange-Diagnostics: 1; CY1PR07MB2522; 3:xu7OfDUetxWdUcrovjVgpRwTW7hK/O+VYCXYws8Rp339dgNaoCaMgBldU/MZtynk/1TUw8TFRmLownTNkUdH8opkpv3ePiez1eaSw5ult4VG6V9kuB4sAOhNK6R5XuUflawk9Nk7UjI/FvqCJD7FffnGSAmyTK9YnxVZY1wdX+5fLN2sErIy6RN2elK42eSo/1YDTRfjFKP964dDl7Aj5OTKZyu1xzB0gcXC3uMDQUnu5fVdK6+ic+u6XNnZ2LRP; 25:xb4lveqnz4lixbjdoo1nsCHNb2w2DhCGezzMBApH9h/2WYCXQrNB8Mh5hMLEmGjoiIddmlxQW+FOaELgO0y3uR8zeP1YsLKSh2I1NIlv6NlH8Begoaopk+u8P3+spk27OIqHfp6yE8z4LtDSR3fY8CjDShMW9ffAk5pjvcFR2KQgSXqvXIkxhbD49rI4evT9fJqgjZZquxVuNxwXCL1F92Kj7wn22fEqTCYyxDoVKPsQXvAzjS2PiYSCao8dF5bBBGDjtbK9W+2ML/2QTlnWQsuFEIpaVJeagd2QeJfWEFvgmFRg/695nRvzR+hgb/CXXxb3DQcTDmckrggTurj5lQ==; 31:sSBoHuEl02WKj0Pu45wlT3K5S2YJzoRoNGjYZIXcA+0/HVM9EaLXp0RKfMJJY6lYmiNQkqiorZASkKUi5Y/Vibpx+jZ9kWGPEmSlNteRyvEZkEnbkVrn0wJejR+4QivgGmmqzw7U6K72FT3nTQqdufaBXLE5jPB/fWNg+VQtJITzXid+9T8DHqoHNEtQsmhi2uc6aWhYqMc2o7D+LZemffbE1ibE6WVx36o4//hqUxo= X-MS-TrafficTypeDiagnostic: CY1PR07MB2522: X-Microsoft-Exchange-Diagnostics: 1; CY1PR07MB2522; 20:EObFLl9xhl+jikG7DWqzfq1Ook6BzHePw+JHl3jEC4rmYiWMg+gxrNkgVG5irEF+7egElqVSOctDlw68FkMV1EzYs01fxQwE8ap9xpEf/j3X2Qgxup8b5WS0jY2f3gkJ/sVAiplV++TFqBwyaBloT4KzqY3Jd8gY8t3PIFZ2OVrn48nKTMb6Wt0z1m6Y4THtoCzDvni98LaYq7aH/g1bcXmhcG7nYu2QTY9hG8QVSbQ72KTISMSFT2gLntzTGw6Ll5ZkxdNEci7SqKDaVDeEvWMOwn3MTQ5HTPLeJP1ndpILOc+sH7jQNZtXQG/jJhiqKTqDJTGas47r1K+GIeRz9CtpCzOOdMlYxxdzKp9srrj88Gr4ynYoVLMKKU6SMjjzKMktR3v+7hrRST8dEVKt3EHZKZQBxF+O8vvoYftHr53hzTAO/KfNHg5xAnFWw39FLKn30PtTwMLDsNPLtPLzs4vl3/nJ+NWqrrtnR67dYV2uO2Yd0MiBpktTyQdmdATmRkBmRGl5H58bC5hLB0nRivad3jAdzJxjjAH+Esfc+nKNq5FFNikbqWK/yJRevf/O3Li4Qj9syHjtBb0OND8K6MiYuLJXkuj0vDVtMGpLveQ=; 4:D+YGYjxP3NkqfUSLzxxfyGdynCKiYNFipRu47Mxb+yy3/gw93tPLu+2wHSTnJkNstsp8AT08cjbQP3EgyQz24ICdOdrtBrz1PQJri9Tw8DaHU314OUl/j6RuL0DqC4pmTnFOoFREBUPefkN5gpBKXVlkRENwpPpfzDcD6UIPzHaSyEEoJEJf14IasP5TIPiGqBeyeOj1gdwcocEW7bFmQzFPeuf+uN12MhPEghPJEaZwlLW9pVhmxwNFCLPTP2I9LCik6hbps5PcQOU3lWWa4mnGFdWmD/ZlJKlzpj8POtI= X-Exchange-Antispam-Report-Test: UriScan:(228905959029699); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(93006095)(3002001)(100000703101)(100105400095)(10201501046)(6041248)(20161123555025)(20161123564025)(20161123560025)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:CY1PR07MB2522; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:CY1PR07MB2522; X-Forefront-PRVS: 0422860ED4 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6009001)(199003)(13464003)(189002)(305945005)(8676002)(101416001)(189998001)(23726003)(33716001)(47776003)(25786009)(6116002)(3846002)(76176999)(54356999)(50466002)(50986999)(66066001)(229853002)(1076002)(53936002)(6916009)(6496005)(15650500001)(83506001)(81166006)(72206003)(68736007)(6666003)(81156014)(7736002)(2950100002)(4001350100001)(6246003)(97736004)(2906002)(110136004)(4326008)(42186005)(8936002)(5009440100003)(33656002)(55016002)(105586002)(42882006)(5660300001)(478600001)(9686003)(106356001)(18370500001); DIR:OUT; SFP:1101; SCL:1; SRVR:CY1PR07MB2522; H:jerin; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CY1PR07MB2522; 23:ocTlfUAqYjth0cftLHMPMi9OMD+kCE2uN5hlvJW3O?= =?us-ascii?Q?Q67ofDFSRh5yWeRIjnwI8kSM64Qxpn+uYMxvwRBdShLmh04kMd0jp9bxe1oZ?= =?us-ascii?Q?kq8sPKTouKUVdbj0vsJTiELrI9zWqVYRGyXwzF62YlP5F1p1i1N5pWvYrCUJ?= =?us-ascii?Q?YU0J+q1e31mGfdCJ66bsT+4SweksKCSEq6NAN7fgc4Hc9GNlaDkY+kIpw7Ur?= =?us-ascii?Q?UL2ZaBXljsCJQ8dsD1eyR0WZdSK2rXRtyrltt9WK7ET7E7p+ACzo4y1NyZUT?= =?us-ascii?Q?8mc54H1wl3KkYVbpgSWwbV38XIvKIW15uQgieZ5bfnl+qkE9xrHEzTPkqSwR?= =?us-ascii?Q?KUfSwwXYUWHfpnnHlI3aO1HxwD/KQPYgbHAfLAW5dYvccWG36yyDqqyZf8m7?= =?us-ascii?Q?VzZpAv5KtWan7bVSxoZ4rF+EpeH39+IrHm37oPXEx3COXFON+iVlkOE064Hd?= =?us-ascii?Q?hODifnN0N5kZcSoz1yATlsQIfGPhKCjVxlHV4Un7OeRWKowzLt/XWIc43VXp?= =?us-ascii?Q?63LiNtR0Ozq6K5NATHJzi3kb2DRccCLZ6ZAWDQIXPKkOU2oNVsgvw5TTdao+?= =?us-ascii?Q?45WBhG23LWxHdBx9SJEkl8tMrA9Lp869tFkOao34eGGeTlhpURJ16wTPvmXO?= =?us-ascii?Q?0tBFv8QLHiyT8RD/qQT7P//KctnR7a7RJerod5p7cN0VoC6Pwr1CzPK92KAN?= =?us-ascii?Q?1q5JmCF6VmJz6Z09ymhves7BETgpZ+4xyxF6M6Gnq+7XGhogT3w9pIj75pew?= =?us-ascii?Q?XrTL85bVh5LiRKCV0D9+yqIgW5MKY8FDUplk7giAVruEbzBwRKo17Sw9ajEP?= =?us-ascii?Q?MVq+gFKZgkSB5YyJMFY1SIPnUsZtKMn4uQ+fHiVOEADtEbtlxA/9WxZLvT/m?= =?us-ascii?Q?0Ir5lGG+frXN0UqZ3lb042543JxnwLrnrstHuiA/FiBHJJEVxw9hT4dAX4be?= =?us-ascii?Q?X6fg5clCAZIFtcPfQo9ZobSIaqBbE1eEqWVbcbJshXcS2GzkHJPqBW9qJNzb?= =?us-ascii?Q?ie9QzZ/RqYSQ6+L9FPXKtOGGGpqB4sreONp4DJYgPSBLn2qFo/yWdjvzm5Aa?= =?us-ascii?Q?NTLfUIKOtf0uGn5mP7n2aY2Eien/mS21IQ8e9/TcYh/jwf66F6ZzqvThrw1F?= =?us-ascii?Q?3TDSuPqpS8PjUci5cRkIaZDec6lRuAVdJPx43KtxmEQW1X15uVv6IoPOPO8F?= =?us-ascii?Q?rfXg/LnjCse5NmxQqlNbycZJozaW2FewNdetBv7oHf6BVLPWFs+FY24ow=3D?= =?us-ascii?Q?=3D?= X-Microsoft-Exchange-Diagnostics: 1; CY1PR07MB2522; 6:23tKYrr1UEuXJSRdjyEUZpcKWeEJVEkqjUF+iGBRCE5wd2t401V8zIo49XWQx8FUbNeJSbNMIB9fQVSNJQP147swWavUOFyiSN+wZchfKWSJ0YLU2JD1f1f1i/kH25lV9K4O+ie3tt8EYnCx7+0n1+RHkItOL+nvSM3VDXrZ2VaomrVZwR+oCkttfavRzVvv1E+c7QZre9EXyteBtRDfNsPlGjhGsxmM/83lPsB1v8QBBcEY0IrjH2GRBjdqk1zqfRkHLWYgQFAcNeiVRxTce6beAAAnv9G/A7uJwx6hx9lQvqKlfPaUhjT49klabEIoN2i/FOmJryeFc+juvQD1XQ==; 5:Cqd7+vUqf/B2sRkkl3J6+/QcIq7NptM6uUp50fCBQSZ06QgJ1kSqvR+uR45+916d5O0j2AS5ZErjbLekdRNpHrrRRtFJQzARWa/pSW5RcXT/eWnAzHKMmq0rp1XiO44c9Be9QBJ9ejQkV6RZGx1eTA==; 24:4oUZ4MP++IYeocuB9RPUtxYra0vjtiXe/jL+B9QZkFT8qdeVnkvQn4YLeCANycJ++y01i0AoYyWHYBBr9kMZC9Qt/s0IsXsfbzKC7GPTLt0=; 7:zgZyejJwmv9td4QDnV+uC+fR7ec8AtK5rGF3yTirawg8qjDuYDACctiNIEATiwe+1FbSaZ5/lffeYq0juyxVc52R/DmXr9+n8sMyyVDQuv/CiQen/F9M6aOhNKD3M0U6nOnt69URgR5+nXT6W3d5tk95Tcl9sp0nrCn34xOsHWIsSjVhNR3395Uhnj6I5omP+oHtTSG6h6CSXy+VPJgon0f9moJ5eZbclGA6HgFsCMQ= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2017 06:12:30.8710 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR07MB2522 Subject: Re: [dpdk-dev] [PATCH] eventdev: update doxygen X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Sep 2017 06:12:34 -0000 -----Original Message----- > Date: Tue, 5 Sep 2017 16:14:48 -0500 > From: Tim McDaniel > To: jerin.jacob@caviumnetworks.com > CC: dev@dpdk.org > Subject: [PATCH] eventdev: update doxygen It is better to update the log message with more appropriate comment. Something like eventdev: clarify .... usage > X-Mailer: git-send-email 2.7.4 > > Update doxygen to make it clear that RTE_EVENT_OP_FORWARD and > RTE_EVENT_OP_RELEASE may only be enqueued to the same port that the > original event was dequeued from. > > Signed-off-by: Tim McDaniel > --- > lib/librte_eventdev/rte_eventdev.h | 14 +++++++++++++- > 1 file changed, 13 insertions(+), 1 deletion(-) > > diff --git a/lib/librte_eventdev/rte_eventdev.h b/lib/librte_eventdev/rte_eventdev.h > index 128bc52..117eeb0 100644 > --- a/lib/librte_eventdev/rte_eventdev.h > +++ b/lib/librte_eventdev/rte_eventdev.h > @@ -882,7 +882,10 @@ rte_event_dev_close(uint8_t dev_id); > #define RTE_EVENT_OP_FORWARD 1 > /**< The CPU use this operation to forward the event to different event queue or > * change to new application specific flow or schedule type to enable > - * pipelining > + * pipelining. > + * > + * RTE_EVENT_OP_FORWARD must only be enqueued to the same port that the This text is under RTE_EVENT_OP_FORWARD. IMO, No need to explicitly mention the RTE_EVENT_OP_FORWARD again. Other than that the content looks good. > + * event to be forwarded was dequeued from. > */ > #define RTE_EVENT_OP_RELEASE 2 > /**< Release the flow context associated with the schedule type. > @@ -912,6 +915,9 @@ rte_event_dev_close(uint8_t dev_id); > * or no scheduling context is held then this function may be an NOOP, > * depending on the implementation. > * > + * RTE_EVENT_OP_RELEASE must only be enqueued to the same port that the > + * event to be released was dequeued from. Same as above. With above changes: Acked-by: Jerin Jacob