From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <rahul.lakkireddy@chelsio.com>
Received: from stargate.chelsio.com (stargate.chelsio.com [12.32.117.8])
 by dpdk.org (Postfix) with ESMTP id 0B572FFA
 for <dev@dpdk.org>; Wed,  6 Sep 2017 11:26:04 +0200 (CEST)
Received: from localhost (scalar.blr.asicdesigners.com [10.193.185.94])
 by stargate.chelsio.com (8.13.8/8.13.8) with ESMTP id v869PuJI010420;
 Wed, 6 Sep 2017 02:26:01 -0700
Date: Wed, 6 Sep 2017 14:55:40 +0530
From: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>
To: Congwen Zhang <zhang.congwen@zte.com.cn>
Cc: "dev@dpdk.org" <dev@dpdk.org>, Kumar Sanghvi <kumaras@chelsio.com>,
 Nirranjan Kirubaharan <nirranjan@chelsio.com>,
 Indranil Choudhury <indranil@chelsio.com>
Message-ID: <20170906092539.GA5654@chelsio.com>
References: <201709050902.v8592Tm3013413@mse01.zte.com.cn>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201709050902.v8592Tm3013413@mse01.zte.com.cn>
User-Agent: Mutt/1.5.24 (2015-08-30)
Subject: Re: [dpdk-dev] [PATCH] net/cxgbe: fix memory leak
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 06 Sep 2017 09:26:05 -0000

On Tuesday, September 09/05/17, 2017 at 14:16:57 +0530, Congwen Zhang wrote:
> In function t4_wr_mbox_meat_timeout(), Dynamic memory stored
> in 'temp' not free when the functon return, It possible memory
> leak.
> 
> Signed-off-by: Congwen Zhang <zhang.congwen@zte.com.cn>
> ---
>  drivers/net/cxgbe/base/t4_hw.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/net/cxgbe/base/t4_hw.c b/drivers/net/cxgbe/base/t4_hw.c
> index a8ccea0..013d996 100644
> --- a/drivers/net/cxgbe/base/t4_hw.c
> +++ b/drivers/net/cxgbe/base/t4_hw.c
> @@ -403,6 +403,7 @@ int t4_wr_mbox_meat_timeout(struct adapter *adap, int mbox,
>  			t4_os_atomic_list_del(&entry, &adap->mbox_list,
>  					      &adap->mbox_lock);
>  			t4_report_fw_error(adap);
> +			free(temp);
>  			return (pcie_fw & F_PCIE_FW_ERR) ? -ENXIO : -EBUSY;
>  		}
>  
> @@ -446,6 +447,7 @@ int t4_wr_mbox_meat_timeout(struct adapter *adap, int mbox,
>  							 &adap->mbox_list,
>  							 &adap->mbox_lock));
>  		t4_report_fw_error(adap);
> +		free(temp);
>  		return (v == X_MBOWNER_FW ? -EBUSY : -ETIMEDOUT);
>  	}
>  
> @@ -546,6 +548,7 @@ int t4_wr_mbox_meat_timeout(struct adapter *adap, int mbox,
>  			T4_OS_MBOX_LOCKING(
>  				t4_os_atomic_list_del(&entry, &adap->mbox_list,
>  						      &adap->mbox_lock));
> +			free(temp);
>  			return -G_FW_CMD_RETVAL((int)res);
>  		}
>  	}
> -- 
> 1.8.3.1
> 

Thanks for the fix!

Acked-by: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>