From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f180.google.com (mail-wr0-f180.google.com [209.85.128.180]) by dpdk.org (Postfix) with ESMTP id CA5A958F6 for ; Wed, 6 Sep 2017 17:14:24 +0200 (CEST) Received: by mail-wr0-f180.google.com with SMTP id o42so3995996wrb.3 for ; Wed, 06 Sep 2017 08:14:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=t4R7JeoOvvZijeOnYJScgN61auJZszB0YNF8ou2qUvg=; b=MfqdYGegQKeI4iXaDrQzXpTSCYs1MSQk2Dt5Llt9pNU8fM+wzrmDaHO5HjMywU7ePf gmj/F5okBeOZ0KS95HOdAdWDrxu3E5Z+0Futp7WSiWx3hBW4TBF94DG9xCyePGG6jw1K INqnAWVGV78rO0y+lXzknRfNueKN5ddPo4AxTitGn2Y0evGs2HcyGBIwSl/Jud1yEGO3 vH/qibybHjtzE+Pp3aJB9Rh7pkMzjSNv7r+f7EhD4Yep10kUTjRxoTV1rRT5INthayko zC3VmKjuQndq3CbL+wM6QUic7kxmXyBxdd+qfxKdl+JndvKrZIgL6F1d46vWO3tHcRp0 pfRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=t4R7JeoOvvZijeOnYJScgN61auJZszB0YNF8ou2qUvg=; b=F70uV+1iByfhZatcuykemDwC1Xl9bPwvkn2Ue4RoRh2G0+d5zx2Dk3Im30UUtH49GD RZ4y4LUdMr4vSzJBwT4+r6vBhnqLyHY+GU15VVVUrSZOFCz8uLQmD2juih3xEMt9Kbd9 5Ng0QLOREjCB/N5mUz6GiaKDCnE+BygNLJXBgsnucGgAuPkjial7DHVQMv8qk3Rfk5d6 z8nXbdF950nX1BgHmSZvD5aYuCzOC1pjVMSnsARuKoOdHXDqvyRQiG1zj+rZyxbW+/Hu 0XHXthNtsBR3VQ4Z+zTihcJQY5QW4Cl6yAlO2cNIEbrLSvxXSGkPYUuVpSfq1PxQvVZs UX2A== X-Gm-Message-State: AHPjjUhTVEPiWnDTF11OQCdKKmTlAyn37xZbVwgRuwkVvXUsGwymSFQO 5QZxbbKF48MISJ4x X-Google-Smtp-Source: ADKCNb7Tabedu7dvivhTD1VFPW23ZkoLCgmpd6D+S8v9JWGG91aTq3bWgcpN0p2a7AmUvI9t7wpE7g== X-Received: by 10.223.171.15 with SMTP id q15mr2189706wrc.23.1504710864559; Wed, 06 Sep 2017 08:14:24 -0700 (PDT) Received: from 6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id e80sm1318309wmd.45.2017.09.06.08.14.23 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 06 Sep 2017 08:14:23 -0700 (PDT) Date: Wed, 6 Sep 2017 17:14:14 +0200 From: Adrien Mazarguil To: Matan Azrad Cc: Nelio Laranjeiro , dev@dpdk.org Message-ID: <20170906151414.GY4301@6wind.com> References: <1504710238-25726-1-git-send-email-matan@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1504710238-25726-1-git-send-email-matan@mellanox.com> Subject: Re: [dpdk-dev] [PATCH v4 1/2] net/mlx5: link status update separation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Sep 2017 15:14:24 -0000 On Wed, Sep 06, 2017 at 06:03:57PM +0300, Matan Azrad wrote: > Link status is sometimes inconsistent during a LSC event. > When it occurs, the PMD refrains from immediately notifying > the application; instead, an alarm is scheduled to check > link status later and notify the application once it has settled. > > In the previous code the alarm callback calls to the interrupt > handler for link status recheck and may cause to unnecessary > interrupt events check. > > This patch separates the link status update and the interrupt event > handler to avoid the unnecessary check and arranges the interrupt > handler for more interrupt supports in the future. > > Comment was added in the new function to explain the inconsistent > link status reason. > > Signed-off-by: Matan Azrad Acked-by: Adrien Mazarguil -- Adrien Mazarguil 6WIND