From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-DM3-obe.outbound.protection.outlook.com (mail-dm3nam03on0076.outbound.protection.outlook.com [104.47.41.76]) by dpdk.org (Postfix) with ESMTP id E5D6547CD for ; Wed, 6 Sep 2017 17:53:48 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=x2u8kApcmUgC7vlZ6tcl2aOJaAbpN6+BHpQaO05ipAY=; b=fRE1GBWaLsHuUMv89vxVRPy0lrVpOBdxibvtuLPpaJhNK6kVO0TCglbJTY7LMm9uVUFvg6E4BEcne6Zlz2Xl/Eg2N4nRZD5T1dTBz8uvLhwr5OJnxI9yU5+0ra2QKWi4/1O3tCPhKnDdB1iYsAe4qyoETTopW3ZEuj1tx3vQSwI= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.JacobKollanukkaran@cavium.com; Received: from jerin (111.93.218.67) by BN3PR07MB2514.namprd07.prod.outlook.com (10.167.4.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.13.10; Wed, 6 Sep 2017 15:53:41 +0000 Date: Wed, 6 Sep 2017 21:23:20 +0530 From: Jerin Jacob To: Radu Nicolau Cc: Thomas Monjalon , Akhil Goyal , dev@dpdk.org, borisp@mellanox.com, declan.doherty@intel.com, aviadye@mellanox.com, sandeep.malik@nxp.com, hemant.agrawal@nxp.com, pablo.de.lara.guarch@intel.com, pathreya@caviumnetworks.com, andriy.berestovskyy@cavium.com, sunil.kulkarni@cavium.com, balasubramanian.manoharan@cavium.com, suheil.chandran@cavium.com Message-ID: <20170906155319.GA30919@jerin> References: <7834b3bd-0800-500c-1c89-3b89e2eb47fa@nxp.com> <7410549.rg854U5vhU@xps> <874c2bd0-d097-5082-8a9d-1f9341505ac6@nxp.com> <5392171.j1FdNZENvz@xps> <94a4b6b5-a80a-9884-244a-02131c695eff@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <94a4b6b5-a80a-9884-244a-02131c695eff@intel.com> User-Agent: Mutt/1.9.0 (2017-09-02) X-Originating-IP: [111.93.218.67] X-ClientProxiedBy: BMXPR01CA0018.INDPRD01.PROD.OUTLOOK.COM (10.174.214.156) To BN3PR07MB2514.namprd07.prod.outlook.com (10.167.4.139) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3bcc4684-187a-4a16-492b-08d4f53f7486 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(300000502095)(300135100095)(22001)(2017030254152)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:BN3PR07MB2514; X-Microsoft-Exchange-Diagnostics: 1; BN3PR07MB2514; 3:ivuzvyUIG2Pwg0ZnW6jfJFvF9dO6fjUef3SJLBrmk0WFh7sbBTXBUzxmIYtZSsFC/u0Nyql0c0ZnQmlrj4R2qU0VJVQHLA0f9vMudV2gMQE/Um6cfXco87dBYkHWo5Luzdct1dZh0/8c/5a14OzIXCM2SJmXgl0syYP3QRhwTZlcmJeANnK6OcoFM4DjjFRAUbLsNLruhzoGB6NVOsMVKeXPkHF1GQ0VRYvJ2hvz2TO/irQadELUcQtXcqQZwtbE; 25:w+rQUkVm3izIg52cO2ggNqD/RPVm1Pp8gjG5IA70gJZkklj+ZXPKDcr2jEHOFESjO+W2rV2NKlhznm8x7/esYHDU1ztBs+CtTyMNMh9vZ3J938ro8hPDPkvd7Fpmy2hzxg5tg34BSSXF2wPsgWbAYRhAKmO/hgA1EsFAnQ0yDuSTSsLnM1HwvS4Ev1tDIWiJ+MDZGHOhXMV6uDqIdt9oSw4NvVw4w2PSnqJ/qg6K99HyJAQikJPxtiLnudZ+5CVMaJKIX4rvFsn6s9mmfCouwpdaJNlSUzDa70ccDNbVb8gFVcj9MCJfOy7cgKO3q2ULVfhFD8PYu3bWUEeQss6RBw==; 31:A8SUchpmp14h1xhKCxUxClD81lfzTd2H2yCb2rxa7a8QTHZSxh8GWVvOx1vX+7Smteapu65b72GKMiRez8QzFkB7Q4DGg6xwKyM9+QIagyvZdbEcFHLGcQlq/6s9mJkhJlm2d96jgp3kdNTtbdNrb7I5IMp1sdkmaWSk3HJprgk9icEBZvXQEkW3yd+6bOvG2Ox7Q1ddzwlVtGwHCdLWSgQP5ilv6oKwWxY8tt3Hj9A= X-MS-TrafficTypeDiagnostic: BN3PR07MB2514: X-Microsoft-Exchange-Diagnostics: 1; BN3PR07MB2514; 20:O92aG8hP5k4JltZt/Uci5DA049nGy7mChlMFlTybXtPrF7wkX40yXUN2pMLGslBU3MxqMDOjjShGCA6Fov/mN1H0LaMRVG1o8VBd20Bz6SQKiUcfHKDG9DWvmYIdjk9P/xFo7gx3Lt3VXvZfJeKrW6CaMHRnIP86PaHlxRuTJiJE4bbsWCfg0iDQUulTjbicTtEwqpTtt1p6YlIpRqqzeSQmQxFvYvgQ8LQ5G3hxjNtma8bCcP0C8sZvt+KC6MIc5VGv0MKxx0bdT/opRjV7ojvae2E1U2gI8pM4gtFBzgiBc7vU5yyJQeLDcfN56rmIJTft2+I+VpBLPXl0s9QCTmp2gMH2UXHQkcrAjKw/263MLLXgEZ+S88YvzNlg/UiNsGfLdw/cPnpdigAJcv6ilsbscqwxdtCBbQH9uiTS0LuQADpcrB5bqIuJINsR4BA8ShjsJFxfjzRyhdoFw4T7f8p9e3RU52NwSXnHLwhKLvwpSBUv1INb5NLqI8u+fR4oxDszLVuGPz/Vhno9Y4HjAEhOg4tRIBRpx66khJ4KvrstCcVO2CmZxEcd3wclsqDJMnojRQmtMIvxkDjWM1fBIVwbEhJOwh863D5jibuI2xg= X-Exchange-Antispam-Report-Test: UriScan:(185117386973197)(155532106045638)(228905959029699)(17755550239193); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(93006095)(100000703101)(100105400095)(3002001)(10201501046)(6041248)(20161123555025)(20161123560025)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(20161123564025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:BN3PR07MB2514; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:BN3PR07MB2514; X-Microsoft-Exchange-Diagnostics: 1; BN3PR07MB2514; 4:nTbEiNqKTjWy8GvE+PAmKKc8Srw03Bdk3nk+3dZdFTlB4mvNr/rqKk/bW8tGCGgR9LU2acjvZg4eUclFBz7qx/QKlwfuqqJPkh12o7kxn2+VfXMYsiHj94rNkZDTESR/5+gCYYq0/h3px84kgMncdbaueLWwTxNbqF31l5Su12WGQaUCBYRuO+fLdKSK7ktGzcNnvqt0uKAA+gL6eAflnQObbcH6Gk+k/8eAH/UNUs/yzPdwNh/Q7DpODTFKzv/zoMgdLAaBo3bgjgLuWczx9wUw3WFljr6JW2tD4CjnMflnS77HZJQEdrBnixBGnxg9GWAkLKFz0bPwIsu8P3zAVhMEnUi6PfBJ2QVItsXqDcppOTIfCWxjiYtpzn4eek5Z82fSb84T1LJ9yh9gDgg+CA== X-Forefront-PRVS: 0422860ED4 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6009001)(13464003)(377454003)(24454002)(189002)(199003)(43544003)(106356001)(9686003)(42186005)(3846002)(50466002)(105586002)(42882006)(6916009)(2950100002)(110136004)(6666003)(23726003)(6116002)(54906002)(68736007)(81166006)(55016002)(478600001)(1076002)(107886003)(25786009)(97736004)(33716001)(6246003)(53936002)(5009440100003)(83506001)(6496005)(4001350100001)(81156014)(72206003)(6306002)(229853002)(2906002)(66066001)(561944003)(4326008)(54356999)(76176999)(50986999)(101416001)(7736002)(7416002)(8936002)(53376002)(305945005)(8676002)(93886005)(47776003)(966005)(189998001)(33656002)(5660300001)(8656003)(53546010)(18370500001)(217873001); DIR:OUT; SFP:1101; SCL:1; SRVR:BN3PR07MB2514; H:jerin; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BN3PR07MB2514; 23:0XXAZ1WdRIzOCSEq/sodEkKncirSLatWK0AvC1iBx?= =?us-ascii?Q?WMK7CZ2vDcdTc+PHYm3juFoWxrCNdasR+bDF2qLl6vVqkgF4WiLa/ak8PT+w?= =?us-ascii?Q?lC46WAGOmPGoa6smgko7ABPZPg1qS3DtVMxcW8u71nZj1A8IdXOil1eXZ2u4?= =?us-ascii?Q?j7mmhxxe+TjqVkcyVK9ZMe0pb220OZGaMVE4q/h3RCY6hsCGNfRtiPRdA30w?= =?us-ascii?Q?at8533wmSpc3DVqUzhj2IVeGGZe6A1i2gBRtTkrLy25zvIpkL5hu1op5M5sB?= =?us-ascii?Q?ScbzW+dPs0xMk+9tcR9XP+i6JGiZlBs0xqncGmjktP9Uuy5rP8+vtIM+Achm?= =?us-ascii?Q?rauOsRE5mKw7hogovIBtsi3+AgqlPAhfgKwwaNwPjgRXigE89yavY1dsO4Jm?= =?us-ascii?Q?BbKliZx2VFemGzwFlACk/IJOhNEhW4JIsy88loJEgy7yOurZo2+RQooErh91?= =?us-ascii?Q?VAvz4WRVGAPdOtrOUar+CHHnbCsEWFF1+/9bqyi71B7og3Dn1QzEomnWUZkG?= =?us-ascii?Q?tdwDkxAYN0Ast2YsnRyVpjct54oNE1NduNcZbF0czX1EFtNa+ObK2NLhxoeT?= =?us-ascii?Q?gRG+axbJP59pv6rB1hn6kUrB470JsEGgxYVcRKcVOdFc2Cy9xqFOiEltHlLl?= =?us-ascii?Q?Qf6I/3J/Koa7xu5E8eI2QEw/EsZWftKlSOKkMM9OjF5ZWr/L00sF0V7mNZ58?= =?us-ascii?Q?NMAleMWz9naX38vf6nRQ4L2LM6ayz9tjCnCghcviaXW3QGE5TmEoYq0W6v3L?= =?us-ascii?Q?/WgSDR9qejtZJiNZOBeRYtdm0fkcPnuGFM5bKr+7dZEMqEzVF1HFiLMPd7FX?= =?us-ascii?Q?81iJLd/1PcxKpd+nxtYx0Yl4DrIaStxfmdr9DI38SHit9KM1CXWU7R19vDQR?= =?us-ascii?Q?IYGr2aW7cBvtNLUy1v/N6jiffspZOlyoufkjakzt1YQAGtqDgaDv1YgqF9Z/?= =?us-ascii?Q?3sCMu0y6fS/MMfEYfXnp+979k9Ienb9vq3HuxVb1h1Jbt5y0+m3Jf/F1fLZh?= =?us-ascii?Q?j0GAEvaZoL1RNdfg8d8esHVMKEdCJh7jGj2St403yKl9GTLM2A+QhKb7jCnV?= =?us-ascii?Q?QebJoxatDfwXFVjSSs1iqpzisHzRHWYmvrBUE6idYeZztj5hts15X28nx+PW?= =?us-ascii?Q?2aw3Cx54BK9wM03PyTAv64fnn+W498cEvOYcRKZyHwVvEYmeClTPNOH/FD3E?= =?us-ascii?Q?A4N1AbE9qQyrsQQu0J1Rih40vHn0x0NCqFC2TB0RO9tk/OBTCTT1S6iK8FTs?= =?us-ascii?Q?pOei+mamT917449scp1EwT3RPxZZe/NsITV99l1Bf1H/2XRPLLvUQ8oqcMra?= =?us-ascii?Q?mt02bIGrj3ChBS8iBST3Fd1I8ifkerZiJT5aepPsrTOr+3FbirMFMpsc5Kir?= =?us-ascii?Q?UdR3abDYN5yXFLxNY57E57kXhACf187zObAxkqtBERE4SvC/I/hImk33DAI1?= =?us-ascii?Q?61L6qJWqjLU4B0YSoti0PHf9jDEieqWwgFmXB2Qa6MYrlIWq7YmPNNR9VM5l?= =?us-ascii?Q?iRabWzAhwu+kw=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1; BN3PR07MB2514; 6:RcqXqncxeJoNNYQ/3+HOGF4S315cR465ApYx6Irs+yuwuMgaBXodSXZcG7eKBM3DA86pIJtQgSJxcRJSlcoVC70rsT+tHQp/1h+9KNOl8L5l9jcwvNGFY34KM5Of3Kxhj3RpVfr9FcMfJxJX26hJzqrX6GTgktwYQPL3i6n6Lq10QtGMG5xlT2wcqMb44or2kMUywhoZPkxUvUbmp+NyPivaXPrzuxnv3R+YC6cvdqmdj4ANhmYveQG8ZOvbLejOkLHinJbZabeqLm9ZfgEBnJeR6kb1BdNPKDMT728USN/uY+bligMgd51Hc17HpwBaRQrvqy63IsR+zcURwCghlA==; 5:dgd9WWvd+HdJdU/nbPMElMHwsB5TgxHRb6MK7R7hJF/RbDKpONKbkMcV+5Vt7ZYgQvi3TAIanBQkrYd+XSWvelEyKcwKl7hBmhg3b88ZmjZl85IpPJn48DWkjLNxPIu9U7x86Ow3SnksycRvCHmr7A==; 24:6opjhYCS8t8q5rsIrKmHkIDYh2sQEjEOiI/q3S/1zJR7WnfOAG3/Qc5N7QRQDEwxlcuBINTYnxXBHprC+oDclCJUj2587WB/93avQNN4mFA=; 7:gXgKIPMx++W3RkfzxuMaEHYfgWtCZNvAGrVJygUejtYGy0PMeN0zC8PbCFMr2oUgqwO2wc1iBzF620GF2n44eMLPa7BzMau4L8J+xmpvixijV3brW3l6ebjQRe/JZGTAQKVoZcFjFtI5qf1SYVn06uPiQgEBiHhatPMQ6F4qLtEQACk0Rs/Ok7epoA0aynB1ltvf1yKg65VeOKPn+ZZ4XATcH7u2VGproaiDrc8sosY= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2017 15:53:41.4659 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR07MB2514 Subject: Re: [dpdk-dev] [RFC PATCH 0/1] IPSec Inline and look aside crypto offload X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Sep 2017 15:53:49 -0000 -----Original Message----- > Date: Thu, 31 Aug 2017 15:09:45 +0100 > From: Radu Nicolau > To: Thomas Monjalon , Akhil Goyal > CC: dev@dpdk.org, borisp@mellanox.com, declan.doherty@intel.com, > aviadye@mellanox.com, sandeep.malik@nxp.com, hemant.agrawal@nxp.com, > pablo.de.lara.guarch@intel.com > Subject: Re: [dpdk-dev] [RFC PATCH 0/1] IPSec Inline and look aside crypto > offload > User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 > Thunderbird/52.1.0 > > > On 8/31/2017 2:14 PM, Thomas Monjalon wrote: > > 31/08/2017 12:52, Akhil Goyal: > > > On 8/31/2017 3:36 PM, Thomas Monjalon wrote: > > > > 31/08/2017 11:37, Akhil Goyal: > > > > > On 8/29/2017 8:19 PM, Thomas Monjalon wrote: > > > > > > 25/07/2017 13:21, Akhil Goyal: > > > > > 2. Ipsec inline(RTE_SECURITY_SESS_ETH_INLINE_CRYPTO) - This is when the > > > > > crypto operations are performed by ethernet device instead of crypto > > > > > device. This is also without protocol knowledge inside the ethernet device > > > > If the ethernet device can act as a crypto device, this function > > > > should be offered via the cryptodev interface. > > > yes this could be thought of but the intent was to keep cryptodev and > > > ethdev separate, as this would create confusion and will become > > > difficult to manage. > > I think the reverse: it is confusing to do crypto operations through > > ethdev interface. > > If a device can do "standalone crypto" and networking, it should appear as > > 2 different ports in my opinion. > > > > > > How is it different from mode RTE_SECURITY_SESS_NONE? > > > In RTE_SECURITY_SESS_NONE - crypto device is used for crypto operations. > > > In RTE_SECURITY_SESS_ETH_INLINE_CRYPTO - ethernet device is used for > > > crypto operations. > > > For details of the data path of this mode, refer to the covernote of RFC > > > patch from Boris. > > > http://dpdk.org/ml/archives/dev/2017-July/070793.html > > > > > > For implementation of this mode, see patches from Radu, > > > http://dpdk.org/ml/archives/dev/2017-August/073587.html > > Boris RFC uses rte_flow. > > Radu implementation does not use rte_flow. > > So I still don't understand the big picture. > > Boris asked the question and had no answer. > I'll answer here: it was an omission from my side; v2 of the will include > rte_flow usage, derived from Boris RFC. Cavium would like to contribute to the definition of this specification as our HW supports the IPSec offload. I was trying to review the latest patch. But it looks like there are multiple versions of the header file floating around. like, http://dpdk.org/ml/archives/dev/2017-August/073587.html http://dpdk.org/ml/archives/dev/2017-August/073738.html Can some one tell which one is latest one to review? Previously for rte_flow, rte_eventdev specification, etc we had some header file sign off before jumping to the RFC implementation. IMO, That model was useful where all the vendors could make inline comments on the proposal instead of maintaining in the draft repo. So it possible for sending the latest revision of the header file patch on the mailing list for the inline comments. Akhil, Based on your v2 version, we could map a lot with our HW. However, there are three top level quires for the further review. 1) Some HW cannot offload all types of packets(like IP fragmented packets) and/or there may have back pressure momentarily from IPSec offload engine (like Queue is full) etc. So in that case what is the expected behavior a) Is it an offload driver responsibility to take care of that or b) Is it passed to application as encrypted packets(in case of inbound) and the application has to take or of them. 2) In case of inbound traffic, What is the packet format from offload driver. i.e a) Will ESP header will be removed from the packet area after the decryption. 3) We have a few feature like, anti-replay check, SA expiry((byte/time) notification, etc from HW/FW. So it is not clear from the specification on the contract between between offload driver vs application responsibility? Can you give some insight on that? Especially the error notification scheme if it is an offload driver responsibility. This questions will help us to review your proposal and make forward progress. Thanks, /Jerin