From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 74A5FFFA for ; Fri, 8 Sep 2017 10:59:03 +0200 (CEST) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga105.fm.intel.com with ESMTP; 08 Sep 2017 01:59:02 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,360,1500966000"; d="scan'208";a="149598916" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.221.24]) by fmsmga006.fm.intel.com with SMTP; 08 Sep 2017 01:59:00 -0700 Received: by (sSMTP sendmail emulation); Fri, 08 Sep 2017 09:58:59 +0100 Date: Fri, 8 Sep 2017 09:58:59 +0100 From: Bruce Richardson To: Neil Horman Cc: dev@dpdk.org Message-ID: <20170908085859.GC35580@bricha3-MOBL3.ger.corp.intel.com> References: <20170901100416.80264-17-bruce.richardson@intel.com> <20170907170719.GC18344@hmswarspite.think-freely.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170907170719.GC18344@hmswarspite.think-freely.org> Organization: Intel Research and =?iso-8859-1?Q?De=ACvel?= =?iso-8859-1?Q?opment?= Ireland Ltd. User-Agent: Mutt/1.8.3 (2017-05-23) Subject: Re: [dpdk-dev] [dpdk-dev, 16/17] build: add option to version libs using DPDK version X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Sep 2017 08:59:04 -0000 On Thu, Sep 07, 2017 at 01:07:19PM -0400, Neil Horman wrote: > On Fri, Sep 01, 2017 at 11:04:15AM +0100, Bruce Richardson wrote: > > Normally, each library has it's own version number based on the ABI. > > Add an option to have all libs just use the DPDK version number as > > the .so version. > > > > Signed-off-by: Bruce Richardson --- > > drivers/meson.build | 8 +++++++- lib/meson.build | 8 +++++++- > > meson_options.txt | 1 + 3 files changed, 15 insertions(+), 2 > > deletions(-) > > > > diff --git a/drivers/meson.build b/drivers/meson.build index > > d7a614f83..76d610a5b 100644 --- a/drivers/meson.build +++ > > b/drivers/meson.build @@ -92,6 +92,12 @@ foreach > > class:driver_classes depends: [pmdinfogen, tmp_lib]) endforeach > > > > + if get_option('per_library_versions') + > > so_version = '@0@.1'.format(version) + else + > > so_version = meson.project_version() + endif + > > I'm not sure this is a good idea. If we default to using the defined > project version number, we commit to, by default incrementing the > library version number on each release, even if the ABI hasn't > changed, which means that the purpose of versioning (creating > compatibility between library releases), is rendered useless. > Yes, I agree on the compatibility, so the default for this option is to have individual .so versions, as right now. This option itself was added at the request of some distros [1][2], who wanted to just use a single version number across all DPDK. /Bruce [1] http://dpdk.org/ml/archives/dev/2017-August/072969.html [2] http://dpdk.org/ml/archives/dev/2017-August/072976.html