From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 66C91377E for ; Fri, 8 Sep 2017 11:03:49 +0200 (CEST) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Sep 2017 02:03:48 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,360,1500966000"; d="scan'208";a="149600352" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.221.24]) by fmsmga006.fm.intel.com with SMTP; 08 Sep 2017 02:03:46 -0700 Received: by (sSMTP sendmail emulation); Fri, 08 Sep 2017 10:03:45 +0100 Date: Fri, 8 Sep 2017 10:03:45 +0100 From: Bruce Richardson To: Stephen Hemminger Cc: dev@dpdk.org Message-ID: <20170908090345.GE35580@bricha3-MOBL3.ger.corp.intel.com> References: <20170907130956.157969-1-bruce.richardson@intel.com> <20170907105152.4faa7110@xeon-e3> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170907105152.4faa7110@xeon-e3> Organization: Intel Research and =?iso-8859-1?Q?De=ACvel?= =?iso-8859-1?Q?opment?= Ireland Ltd. User-Agent: Mutt/1.8.3 (2017-05-23) Subject: Re: [dpdk-dev] [PATCH] eal: cleanup strerror function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Sep 2017 09:03:49 -0000 On Thu, Sep 07, 2017 at 10:51:52AM -0700, Stephen Hemminger wrote: > On Thu, 7 Sep 2017 14:09:56 +0100 > Bruce Richardson wrote: > > > + /* BSD puts a colon in the "unknown error" messages, Linux doesn't */ > > +#ifdef RTE_EXEC_ENV_BSDAPP > > + static const char *sep = ":"; > > +#else > > + static const char *sep = ""; > > +#endif > > This is seems unnecessary to me just have the message be different. I'd rather keep it consistent for the sake of the couple of lines of code. What would be better is if there was a C variable we could use for this to avoid macros, but I not aware of one right now that could work. Again, open to suggestions on that. Even with keeping the macros, this is still cleaner than the previous version. /Bruce