From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id B174C377E for ; Fri, 8 Sep 2017 11:07:17 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Sep 2017 02:07:16 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,360,1500966000"; d="scan'208";a="1170299375" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.221.24]) by orsmga001.jf.intel.com with SMTP; 08 Sep 2017 02:07:14 -0700 Received: by (sSMTP sendmail emulation); Fri, 08 Sep 2017 10:07:14 +0100 Date: Fri, 8 Sep 2017 10:07:13 +0100 From: Bruce Richardson To: Xiaoyun Li Cc: dev@dpdk.org, helin.zhang@intel.com Message-ID: <20170908090713.GF35580@bricha3-MOBL3.ger.corp.intel.com> References: <1504841332-120361-1-git-send-email-xiaoyun.li@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1504841332-120361-1-git-send-email-xiaoyun.li@intel.com> Organization: Intel Research and =?iso-8859-1?Q?De=ACvel?= =?iso-8859-1?Q?opment?= Ireland Ltd. User-Agent: Mutt/1.8.3 (2017-05-23) Subject: Re: [dpdk-dev] [PATCH] mk: add silvermont to replace atom as a target X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Sep 2017 09:07:18 -0000 On Fri, Sep 08, 2017 at 11:28:52AM +0800, Xiaoyun Li wrote: > The -march=atom flag is for older atom CPUs and don't support SSE4 which > is the minimum reqiurement for DPDK. And in fact, the current atom CPUs > support SSE4. So this patch removes atom as a target for DPDK builds and > adds a silvermont replacement instead. > > Signed-off-by: Xiaoyun Li > --- Ideally this should be posted as a v2 replacing the previous patch solution you proposed so that it's threaded with that email discussion. However, that doesn't affect the patch itself which looks reasonable. Acked-by: Bruce Richardson