From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-BY2-obe.outbound.protection.outlook.com (mail-by2nam03on0086.outbound.protection.outlook.com [104.47.42.86]) by dpdk.org (Postfix) with ESMTP id D7D571B53 for ; Mon, 11 Sep 2017 08:21:42 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=7X3p6h8EJ8I5BIrhQgtG7sFVr/aGM2JU4O19t1RB69E=; b=ebvtoUxWkBThIaiZH+DijDOeZS0496G+TcWCQoUX8UgTvVFkqUJ5qaNBFgbQot7MGr08udws5rQzWbSHxSaLAYfMPa15NX3CcFIk0BFLmmhFEdFqaMCdvG+db2n2al5pUXpE4I/tnxtHUuboytuuTpmhkrHoJPQWR29S5duJ8ok= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.JacobKollanukkaran@cavium.com; Received: from jerin (14.140.2.178) by CY1PR07MB2521.namprd07.prod.outlook.com (10.167.16.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.13.10; Mon, 11 Sep 2017 06:21:37 +0000 Date: Mon, 11 Sep 2017 11:51:20 +0530 From: Jerin Jacob To: Shahaf Shuler Cc: Stephen Hemminger , Thomas Monjalon , "dev@dpdk.org" Message-ID: <20170911062119.GA9342@jerin> References: <20170910104827.11da9230@xeon-e3> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.0 (2017-09-02) X-Originating-IP: [14.140.2.178] X-ClientProxiedBy: BM1PR01CA0116.INDPRD01.PROD.OUTLOOK.COM (10.174.208.32) To CY1PR07MB2521.namprd07.prod.outlook.com (10.167.16.12) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b3953dbf-325d-4732-43f1-08d4f8dd5d4e X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:CY1PR07MB2521; X-Microsoft-Exchange-Diagnostics: 1; CY1PR07MB2521; 3:uZpcILvd+02aiVtmWqW586gUqaWIlFmziI92ZaRcCFyqeBnLVs+lZ7SOLJ3Fmz25HHshnjK0TF/K9S+F4WtBTLcXQ40AJjNLKneRe5f4hW3SKzQT3tgdaWoDeEU/OwSWGJlRjUALAvHM5OkTOYpwvzUv8pEurJbWLHjr6dz49WIxyCPRBvGNf9oukjQAMCuZ09nJ9qX9PELgo6KBXdZr3WgSvDvwHfCCU4IEFjyYDeYx2uOZ2YoJ2ZsGiEQUtB8w; 25:6eqkDzVPC3jr/DUmAPGpAii3YduWPWmrrFbIHnfx4uJJDHqYRFZ3Ts54kK8Ej/BXyiBzOhAe0TWIOioFrB4mga51lnvKwymZ8JkNmQczhYzP4m/l+dFHy+zuIuZGLKsN4OTV6nPE12mRkytj6rdyiyTS60P1luVPM0nFNZ4h2Ew5F0wxSDzK3t/E7qtitctHDHolrIrUzE/B5+cjeNcRz8Lp7ITjohlLhfp7d9AkWSkDF7DjdSl9d63yxph05UFo7zJ780M8MC4Jf31D82D9gasIG59ZRuEYSlEh3qZP26rC9F0DRr/Hpk91fxmgi9FebKwTbowY8UVC4GQsHq0AvQ==; 31:7bRP6r1ictfPfqPxT5h1yynTCrkpBWmQcjZIahr+OOvV7CSF5QdxxZdju4lp88eBLQX6WcenbXFykhsaLhMNrA3KTaXZEeQR0l4/9tfJpNUTH10CoiVdQaHtY9dxycb2TPDV5MOgsEIxIg/9hTCCI10LKC1eNduolLrfTa4++y5F/lemgcSOGmsgmC+QeGEuY2zumA14bL7Oi4/lsF5v/vwKna+FNaC4MX2GbvJShGc= X-MS-TrafficTypeDiagnostic: CY1PR07MB2521: X-Microsoft-Exchange-Diagnostics: 1; CY1PR07MB2521; 20:gjWjT9AlPEhbRZPDUumZ/Z2+FFnM4VgNotGxZeSCGaxnad+sPyK2HayE+87NOy764hLJkgoIxide8YSEuCK0rTIPJMOE2H3Ytv0O67HwVlrGxdAMacFVlMqNUcpix0dLkKaHacl0g9hReOB/UFzma+YQDUMA0M7V2QoOXaSog0DgQnpJHPHf9hhVfgtzdgMwxOCxC+g6eKWIVUCSuLlFOEQo5fDIRl5gt5geO3QMUHqYgx81bTZkbiiIWiT8b/u2E1WglNKwL/79FpIuJR/nivCPES6RHtSiOy9Km+VuD/bdySgT70xlHctq3JaRom5uRT8CY3FY4IlOFQdcGu6oonqcSGsx148C7qY/5FjuO2SB2NKpkJ/guTCJVzrbHDAWvDUEOZVShWXjlFYvPAidJq4TnJWYwigiNqD8igoBhwelm/nfZ/NKDt3MXuoX8MenG6+KXK2FH3C/rDqMsVYhTieXDoA50YgNhWiTk8ec3DkPQ/plJ+gEAp7SYMz/GcciWB7EDboRKr2YIdKMTq++0eSYrV6VWpllnpz+fF8lEGPwzWe9Sxzjrc8XjVFnz+pppP9ykQhmT8hCSBC83gT+wtSd/ySpE52hSEti2/DhuS8= X-Exchange-Antispam-Report-Test: UriScan:(20558992708506)(278428928389397); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(3002001)(10201501046)(100000703101)(100105400095)(93006095)(6041248)(20161123564025)(20161123562025)(20161123558100)(20161123555025)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:CY1PR07MB2521; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:CY1PR07MB2521; X-Microsoft-Exchange-Diagnostics: 1; CY1PR07MB2521; 4:CoulIzOplY8Y0mvEMAQUlwkzjHn9lLS9EuIYahDQcbDL+3NGWPxm6ypiL74fKRqUcR+teaPFo0myf9T4UMs5xNoAb/CNmoWUiRDXWJoMxODHkEOXSxGnklf5j5YBofEhgcs/il2R/SKwndvvDY6cmF78Bxg5Ph1hw62i18VaolU28S+GgTwpMNoY59oHMkVeILilMWJH1N93u00ES7X1SggahlM0J5XovHmjKbXQ9whstNfnpPkuPguGLZ1Bv/r0WOMkBdMOTtwa9wkN5A3TxnGrUsHDKUV0qZaC1wuAbqOR7RV8tbuAbxG52C/CiE6DfSrYu4VXIFLdXi9GiYa7Ow== X-Forefront-PRVS: 04270EF89C X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6009001)(13464003)(199003)(189002)(377454003)(24454002)(23726003)(72206003)(83506001)(42882006)(6916009)(47776003)(66066001)(105586002)(8936002)(97736004)(5009440100003)(54356999)(110136004)(53376002)(42186005)(33716001)(33656002)(2950100002)(189998001)(6666003)(8676002)(54906002)(6246003)(229853002)(6306002)(50466002)(4326008)(305945005)(68736007)(4001350100001)(1076002)(101416001)(55016002)(966005)(81156014)(5660300001)(6116002)(478600001)(53936002)(76176999)(93886005)(106356001)(3846002)(25786009)(2906002)(7736002)(81166006)(6496005)(9686003)(50986999)(110426004)(18370500001); DIR:OUT; SFP:1101; SCL:1; SRVR:CY1PR07MB2521; H:jerin; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CY1PR07MB2521; 23:abop7og5kkKEh/ZLQmqNexe5pHdoG5TUfSLWags3y?= =?us-ascii?Q?z/TEDrOO1BGgGbR+3Qhoabg2gLTUJ6r6ebBcX5LVtFRvrN7rHbVdUBNNu/PY?= =?us-ascii?Q?QljfDUk225S6ORvfqEP9KiJiMnA1pMWDH+u+xwfWLZ0GP7hbP5Gw0nd28jU9?= =?us-ascii?Q?gSYz1nIhINuYoeyo4zDCcuZeRZDqvvM3/QifIgRvtJpHxVC1iCQd3QydrO4+?= =?us-ascii?Q?AER+CZSDSBV5uHGok7hbgghVswbE7aM5pRklNkT3GaKV/OOc7ieOiYRHhBmj?= =?us-ascii?Q?r4pjrfDatmu6e4SZBrPmTwGPNNftmnwoIgf0qnvoJeVfBXkp8i5wmzfRYH4a?= =?us-ascii?Q?pX4dlP4jhFjrl7pfIEQmkeOHDqY8RRL6oMB/evSDS5HTroPchtECeMYs6Ljc?= =?us-ascii?Q?QJglr+nIRCZgcEjE1YTOYawN2P79JPofKVUa3/JnHXo3hqrzXiLc+bvBQZsG?= =?us-ascii?Q?lZwTdFw0h3ew2BsCoSsUe8kvCXbVaWRf10hWocRw+yrrzdFAKRFP62GpnW9Y?= =?us-ascii?Q?q3yx5g1Mq5QnubXHZEdAQ2Ddid4M90s/6ZshoPsVE/AbyC78v4KbCht6tZBW?= =?us-ascii?Q?O8/AjKexQNYu+jxokQwLcL6CzHB7EvQgW5xSJAjvDUMFaWjJnijQ1X/7VO6P?= =?us-ascii?Q?YRkE4rhhxCEmt1pgCt9jMlHkIOMlxs0us44YnofXsQHaKRVUCvK1cAT4R0GL?= =?us-ascii?Q?JlZt2o0+pKhYdWmHr3COnrBW23V7a7D/8f07Z/vGG9Z1k3/xqxWjXi5D6Kt3?= =?us-ascii?Q?wWf9wgkk4/j7LQO5EaJOoV2MrUdYXZ4yHvBM3CiXTZdL761bVhSGg/zMWbih?= =?us-ascii?Q?cH3R86oGzBJAzeTpIgtzWQOr4lHZ97azvlPgrbg3Vld0H5CZP49XotFpBgNQ?= =?us-ascii?Q?ILKIwQBEKNxB9s+JXe5xAZGVrF9mWhizXba3BKEwcsdhX1MVam1asMxCbWJm?= =?us-ascii?Q?5Z2Uvh1l8wsYIbGHuv7Qt0cWTRAcxWe5vUgCtnuCWIn5INhoMESQrwCN4cJA?= =?us-ascii?Q?ivDpKXl1ibtHZCT6S6aUt5F/10PF48uDbr/pHZzBuBlcX7M67F3+nFJV8tdt?= =?us-ascii?Q?rraAzdazFB3fhbj92+frtuiPZvl8aNRhiR8Z9rb8LgB846foNoUC04vxadaU?= =?us-ascii?Q?i3kKMXXI+9pBfAj3BGK8RYyGfc52IMYpf6e2jhOr/SdGSltpZ3wnimSXMD/E?= =?us-ascii?Q?Tqu0YAs1dxY+eql6bE11PBuL/tVbVswUB3cHPJbHRYr5RTnI2Wm7tIUuasPw?= =?us-ascii?Q?kSPvN7v5Dqjgrzq5Lb3EWRQr9Qoc8CVuHUIFiovU13xRqZlfxCR23Y/CqFuX?= =?us-ascii?Q?REce0pbCqj0/myKi/4cqz3CSU4/im9WzLFfciMWUDLt5Vo5i6SWDFY6/6yX4?= =?us-ascii?Q?Gconn4sTWwE0eLhzxzOO2Y+rhI=3D?= X-Microsoft-Exchange-Diagnostics: 1; CY1PR07MB2521; 6:s8seReymHTHRHC4NWwDG4K5muYAj7FivbfzhY4U5fE8LdZEm8mnFHJGJczNBQGlyO+ylgFagyYkhuTyLGvx1BTAauTp4QCkSPirRcf4AxU7RDfjxi3Cgud8E0SxFIP42uXK1aQ9yr6dCOSdoHgrfvIBl5gSBh2CfpTj2Z4JtAVHhrR31ko5GvqgFYynPPfz/GyBhdRZlEpEcU+feo3atIODLJhD3CuVaosHRfnU16UQ5P7ngaSdkPOBDV57IkUpg9qjS9KhYB6J+GqY8MyGMn/fkQ7UNm2JxvW3wMT1IiJtc0xYt0q30SOAH16OOA/cDCDVRlKLpGHlOc/6xQc/JuQ==; 5:zUYMyElX1Rj7mpyxSe/J5tSXT0R+xibXfZGbdY/8+brSysaHr0gAcZiRbtG85ONQEvYjobOUtvu0MQcC8kz9QTrOJpI8WAOsZ4ARJ5WcM5Lex2jiiNoPU6VmznTE4gp/t11FEpi8Dl01EhyTT+63Hg==; 24:JEPD1P3IfqMn5jx7LE0BCB0FD62J81Yg0dBclkXAXmSSL6bxA78ssxxxNn9qeBfb/rK1pzZo/F4m/cIBkZwFMQfelqtGyKrjKL0+QAy4PDQ=; 7:Zh9treRMvpiGKd8LldzfdWr+CbhIEtT1H/S6Ag/E0DasUvaFlJfhnlZAGM4J0UWkQmY3D8eMnKHqKl1Hrc41MrIWTANfwcaXcm2/Y5t4MNI8fl4BeCA5GYpieK+I1zERFbwN1NSuLHRz/AuJgedFFvp5Om8DzBGaIf18ufDLAq6fWpVnmPr/AQpqRFsIFiQqi+AvBPd1LO8QSYW4TVLIGn3ZMFb1VlGxc2n7eM6r2Ig= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Sep 2017 06:21:37.8266 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR07MB2521 Subject: Re: [dpdk-dev] [PATCH v2 2/2] ethdev: introduce Tx queue offloads API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Sep 2017 06:21:43 -0000 -----Original Message----- > Date: Mon, 11 Sep 2017 05:52:19 +0000 > From: Shahaf Shuler > To: Stephen Hemminger > CC: Thomas Monjalon , "dev@dpdk.org" > Subject: Re: [dpdk-dev] [PATCH v2 2/2] ethdev: introduce Tx queue offloads > API > > Sunday, September 10, 2017 8:48 PM, Stephen Hemminger: > > > > On Sun, 10 Sep 2017 15:07:49 +0300 > > Shahaf Shuler wrote: > > > > > Introduce a new API to configure Tx offloads. > > > > > > In the new API, offloads are divided into per-port and per-queue > > > offloads. The PMD reports capability for each of them. > > > Offloads are enabled using the existing DEV_TX_OFFLOAD_* flags. > > > To enable per-port offload, the offload should be set on both device > > > configuration and queue configuration. To enable per-queue offload, > > > the offloads can be set only on queue configuration. > > > > > > In addition the Tx offloads will be disabled by default and be enabled > > > per application needs. This will much simplify PMD management of the > > > different offloads. > > > > > > The new API does not have an equivalent for the below, benchmark > > > specific, flags: > > > > > > - ETH_TXQ_FLAGS_NOREFCOUNT > > > - ETH_TXQ_FLAGS_NOMULTMEMP > > > > > > Applications should set the ETH_TXQ_FLAGS_IGNORE flag on txq_flags > > > field in order to move to the new API. > > > > > > The old Tx offloads API is kept for the meanwhile, in order to enable > > > a smooth transition for PMDs and application to the new API. > > > > > > Signed-off-by: Shahaf Shuler > > > --- > > > > Agree on a conceptual and hardware level, that this is a property that could > > be per queue. But is there really an application that would want to have > > refcounting on one queue and not another? If application is cloning mbuf's it > > needs refcounting. One could even argue that for safety these should be > > library wide. That way if an application tried to manipulate ref count on an > > mbuf and refcountin was enabled it could be panic'd. > > Actually the refcount and multi mempool flags has no equivalent on this new API. They are not counted as offloads rather some guarantees from application side, which I agree that probably needs to by library wide. > In the current API you cannot set those per queue nor per port. I think there is intention to move those flags to some other location following this series [1] I don't think that is in following this series. It should be in this series, if we are removing a feature then we should find a way to fit that in some location as there is a use case for it[1]. Without an alternative, this patch is NACK from me. [1] http://dpdk.org/ml/archives/dev/2017-September/074475.html > > [1] > http://dpdk.org/ml/archives/dev/2017-September/074475.html > > >