Re: [dpdk-dev] [PATCH v2 2/2] ethdev: introduce Tx queue offloads API

[Jerin Jacob <jerin.jacob@caviumnetworks.com>]

-----Original Message-----
> Date: Mon, 11 Sep 2017 07:56:05 +0000
> From: Shahaf Shuler <shahafs@mellanox.com>
> To: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> CC: Stephen Hemminger <stephen@networkplumber.org>, Thomas Monjalon
>  <thomas@monjalon.net>, "dev@dpdk.org" <dev@dpdk.org>
> Subject: RE: [dpdk-dev] [PATCH v2 2/2] ethdev: introduce Tx queue offloads
>  API
> 
> Monday, September 11, 2017 9:21 AM, Jerin Jacob:
> > 
> > I don't think that is in following this series. It should be in this series, if we are
> > removing a feature then we should find a way to fit that in some location as
> > there is a use case for it[1]. Without an alternative, this patch is NACK from
> > me.
> > 
> > [1]
> > https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdpd
> > k.org%2Fml%2Farchives%2Fdev%2F2017-
> > September%2F074475.html&data=02%7C01%7Cshahafs%40mellanox.com%7
> > C6ce00422e1db4075f9f808d4f8dd5f39%7Ca652971c7d2e4d9ba6a4d149256f46
> > 1b%7C0%7C0%7C636407077062635613&sdata=INJMOfiL9iwSboWuTVhnVvllu
> > e2gS1%2FVB4Aj9XP09No%3D&reserved=0
> 
> I don't understand.
> From the exact link above, you explicitly say that *you* will move this flags once the series is integrated. Quoting:
> 
> " 
> > Please Jerin, could you work on moving these settings in a new API?
> 
> Sure. Once the generic code is in place. We are committed to fix the
> PMDs by 18.02.

Yes. I will take care of the PMD(nicvf) side of the changes. Not in ethdev or
mempool. Meaning, you need to decide how you are going to expose the
equivalent of these flags and enable the generic code for those flags in
ethdev or mempool. The drivers side of changes I can take care.

> "
> 
> What has changed?
> 
>