DPDK patches and discussions
 help / color / mirror / Atom feed
From: Olivier Matz <olivier.matz@6wind.com>
To: dev@dpdk.org
Subject: [dpdk-dev] [PATCH 01/10] net/bnxt: fix compilation with -Og
Date: Mon, 11 Sep 2017 17:13:24 +0200	[thread overview]
Message-ID: <20170911151333.5727-2-olivier.matz@6wind.com> (raw)
In-Reply-To: <20170911151333.5727-1-olivier.matz@6wind.com>

The compilation with gcc-6.3.0 and EXTRA_CFLAGS=-Og gives the following
error:

  CC rte_pmd_bnxt.o
  rte_pmd_bnxt.c: In function ‘rte_pmd_bnxt_set_all_queues_drop_en’:
  rte_pmd_bnxt.c:116:6: error: ‘rc’ may be used uninitialized in this
                        function [-Werror=maybe-uninitialized]
    int rc;
        ^~

This can happen if both bp->nr_vnics and bp->pf.active_vfs are 0.
Fix it by initializing rc to -EINVAL.

Fixes: 49947a13ba9e ("net/bnxt: support Tx loopback, set VF MAC and queues drop")

Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
---
 drivers/net/bnxt/rte_pmd_bnxt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/bnxt/rte_pmd_bnxt.c b/drivers/net/bnxt/rte_pmd_bnxt.c
index c343d9033..484a1cb63 100644
--- a/drivers/net/bnxt/rte_pmd_bnxt.c
+++ b/drivers/net/bnxt/rte_pmd_bnxt.c
@@ -113,7 +113,7 @@ int rte_pmd_bnxt_set_all_queues_drop_en(uint8_t port, uint8_t on)
 	struct rte_eth_dev *eth_dev;
 	struct bnxt *bp;
 	uint32_t i;
-	int rc;
+	int rc = -EINVAL;
 
 	RTE_ETH_VALID_PORTID_OR_ERR_RET(port, -ENODEV);
 
-- 
2.11.0

  reply	other threads:[~2017-09-11 15:13 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-11 15:13 [dpdk-dev] [PATCH 00/10] " Olivier Matz
2017-09-11 15:13 ` Olivier Matz [this message]
2017-09-11 15:13 ` [dpdk-dev] [PATCH 02/10] net/qede: " Olivier Matz
2017-09-11 18:22   ` Patil, Harish
2017-09-11 15:13 ` [dpdk-dev] [PATCH 03/10] net/virtio: " Olivier Matz
2017-10-05 23:17   ` Ferruh Yigit
2017-10-05 23:28     ` Ferruh Yigit
2017-10-06  6:43   ` Maxime Coquelin
2017-10-06 18:43     ` Ferruh Yigit
2017-09-11 15:13 ` [dpdk-dev] [PATCH 04/10] net/i40e: " Olivier Matz
2017-10-05 23:24   ` Ferruh Yigit
2017-10-11  6:20     ` Wu, Jingjing
2017-10-11  7:52       ` Olivier MATZ
2017-09-11 15:13 ` [dpdk-dev] [PATCH 05/10] uio: " Olivier Matz
2017-09-11 15:13 ` [dpdk-dev] [PATCH 06/10] cmdline: " Olivier Matz
2017-09-11 15:13 ` [dpdk-dev] [PATCH 07/10] metrics: " Olivier Matz
2017-09-11 15:13 ` [dpdk-dev] [PATCH 08/10] lpm6: " Olivier Matz
2017-10-06  0:18   ` Ferruh Yigit
2017-10-26 10:42     ` Bruce Richardson
2017-10-26 18:54   ` Ferruh Yigit
2017-09-11 15:13 ` [dpdk-dev] [PATCH 09/10] app/test-crypto-perf: fix memory leak Olivier Matz
2017-10-05  9:29   ` De Lara Guarch, Pablo
2017-09-11 15:13 ` [dpdk-dev] [PATCH 10/10] app/test-crypto-perf: fix compilation with -Og Olivier Matz
2017-10-05  9:36   ` De Lara Guarch, Pablo
2017-09-11 15:28 ` [dpdk-dev] [PATCH 00/10] " Bruce Richardson
2017-10-06  0:26 ` Ferruh Yigit
2017-10-06  7:31   ` Olivier MATZ

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170911151333.5727-2-olivier.matz@6wind.com \
    --to=olivier.matz@6wind.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).