From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-DM3-obe.outbound.protection.outlook.com (mail-dm3nam03on0075.outbound.protection.outlook.com [104.47.41.75]) by dpdk.org (Postfix) with ESMTP id 18E742B84 for ; Mon, 11 Sep 2017 18:35:40 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=ynGvdALR4jJaiWmNAJzTit7GCYxq31bh0BgAQYuTVOo=; b=S8a2Qxlu8pMbBLrwcBV1ICHh51EZdAvmOgTb0SWpk28hPBwit2QZf0cl/IpL3Gp+W3+GcvfPykXGc2DyxqI9C1ybGNlJGWjckxWoq/E4xQ+ACMJsKhb4+C18KY6n1NB9KVmIGR4ykeOUVzNz525Lur2xxzTnNz/27MWhQmXPQBU= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.JacobKollanukkaran@cavium.com; Received: from jerin (14.140.2.178) by SN2PR07MB2528.namprd07.prod.outlook.com (10.167.15.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.13.10; Mon, 11 Sep 2017 16:35:36 +0000 Date: Mon, 11 Sep 2017 22:05:18 +0530 From: Jerin Jacob To: Harry van Haaren Cc: dev@dpdk.org Message-ID: <20170911163517.GB21422@jerin> References: <1504883894-43451-1-git-send-email-harry.van.haaren@intel.com> <1504885015-44642-1-git-send-email-harry.van.haaren@intel.com> <1504885015-44642-2-git-send-email-harry.van.haaren@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1504885015-44642-2-git-send-email-harry.van.haaren@intel.com> User-Agent: Mutt/1.9.0 (2017-09-02) X-Originating-IP: [14.140.2.178] X-ClientProxiedBy: BM1PR01CA0097.INDPRD01.PROD.OUTLOOK.COM (10.174.208.13) To SN2PR07MB2528.namprd07.prod.outlook.com (10.167.15.6) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4533641f-0af4-4e74-ee0f-08d4f93322b3 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(300000502095)(300135100095)(22001)(2017030254152)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:SN2PR07MB2528; X-Microsoft-Exchange-Diagnostics: 1; SN2PR07MB2528; 3:PoGh1FZZH4SCkQNZ57ZlTC9wzzphzvN7NuA4stWQY+fAHu2jIukINURUBz/rVEBJngF2+hEcaI4Qn1Gxynfjq1SFGvUy1b3E7MMF0AtkkFT4D5R98owEOiNkLSStWkB7p8s/JerIzfv/94+0/zgDA8Plt64IRlM2uTnvjIBtFBxKBghW35bbnJJh8XQXaAy8Z+0D7z1SfCzQ8jWMUwhZJqMbAnsux93H8GBpTBbaIYnDxx9BOZblSFWFeQTKBWDf; 25:ML8qmUQCtoT2LrBrI4uaA9oaUCScWKB7Oen6BJKuLoZFJK1MvZuMJqegE5rKic+FF2DEEqSXsTFvHvdrILXrayzqFQOJQr3x/DMsOCO6F0dEnA76ZSmZ5UX89PXj2Ij8VDilclWqqro/KZdp2hHfxT7DGugpM71Ph38YlzftzidIe9WjcX+sEmRHsVVIsxmxUSkwIEknNhMBEPfI23+FSEVOEkR5XiInXhcibZqqePRzTH6t+VMLtAPFph2CaLyIwdC2N7F+uOBKLGPPxgVO1VJXoOpIPBdzapvz3zz7EKmDbAe6TTfBaOeRLrLMb6PX7dHXkZBmrHyXs5iC91WkIQ==; 31:A+LgxI34Vp9s/ZrOCJiy+ag2Dt6bmj4x9xWT0hN1FN82zzUMVTX6rKS3jzVpCewLbQI+WdYqh25ObQNMjEu0Uqf8u9yShtNewcEw2gM1oawtf9JMuIN2EyvSwjzQEtoOPrnglyseWP2GLF3lwB98i5xzGIH1AfN8xnoHq+0GG8UuRX8+YqNQG/nzfh55EUqm1nf7JJJBoECZpl5VzOfAsTpYYdgwD373nGA3r4SZh0w= X-MS-TrafficTypeDiagnostic: SN2PR07MB2528: X-Microsoft-Exchange-Diagnostics: 1; SN2PR07MB2528; 20:LXqwpDwlxzYVf9Hl8stcqn9O9vB4xljwav1JtLX9pudlIhNE+UcCZjhB/4CrjgrGYjeFnPfZUgxMzLQ3v3NhLRbpgfkqPzRGj3JRmfF2aGN+gg9jIX/NPgxIDZRuZmkePz5JyZZmy2jjizWD2fy5t+h2yEKPVihXbZMkeJ007n5zoawC13VF7d/FjjkuPd5fzc866AQdjZJGkxbZGMD06fcdIzop7V6m7unIbUSm6k1XssMB/yxRcEoXMEmNofTp5VsVydE9VXtn6knAvKAIDbD7DWFqhNr+asL5h4w7ICnalJSDwtVLl/ppsAj/G+sPglO7AAgUkcrf409TonE6btpb27DdXY7wpanLF+p4O5EMAP1Vov1pXBjBYSkdlGAlmvCFbD31wF2q9N+KT8f5DKYp7kHDoZ7Fv7b+0QR/Y51iBI3Sk+awB1lhky85qRgp1XJD2C/KyafMEjDbip0fnnsZPUumuzuzBoNu6ifZxtgr96wSbVj8u5hbIW0tvaPLv6N5SdmLLLE30FQRv3i96i2Q6pk4QfD8PqZTUb3QngohnnnOlE4Kzd8nU6pRVvm3oX4eCyfddQNTC/AB7oYINm9SNE0PVcy2xfrQUD2xBhU=; 4:fb58JsHR1mSXDWzVi7uL3yQgZcyYAbQ7Y9VSAXpuwJxGcKTbDln1cp4RWJk3mmZWt9Xm0RA9QewQVC6E2FjdlJo6b53ymKay4mx5o82kQkfFm7aWShupFL9A6SN78osnUjb7iVQwYbeeyv44RLyZV/Ag61Q/HjJR4eYRgm2y3A/Rg8R/y4foViAY38gB6m1eOzVPt0QQ1Y1SDB2/mZhg0vTt+tsgrME9lQC9K9+SVMnRVPRMHQtvPHS1leBqHORceGJkwZantNcalwZng4fIMuoRjBjOQqIBSBNwPfcTKHk= X-Exchange-Antispam-Report-Test: UriScan:(228905959029699); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(93006095)(10201501046)(3002001)(100000703101)(100105400095)(6041248)(20161123562025)(20161123555025)(20161123558100)(20161123560025)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:SN2PR07MB2528; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:SN2PR07MB2528; X-Forefront-PRVS: 04270EF89C X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6009001)(189002)(199003)(13464003)(97736004)(42882006)(54356999)(23726003)(7736002)(76176999)(50986999)(81156014)(6666003)(4326008)(6916009)(478600001)(8676002)(2950100002)(6496005)(305945005)(8936002)(42186005)(72206003)(110136004)(6246003)(101416001)(3846002)(83506001)(81166006)(25786009)(55016002)(2906002)(68736007)(33716001)(9686003)(189998001)(4001350100001)(5660300001)(105586002)(5009440100003)(575784001)(53936002)(229853002)(1076002)(47776003)(66066001)(106356001)(50466002)(6116002)(33656002)(110426004)(18370500001); DIR:OUT; SFP:1101; SCL:1; SRVR:SN2PR07MB2528; H:jerin; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; SN2PR07MB2528; 23:24dSkonrfWqruM721VXra7Z3A+XH4l/2bZatCvZ19?= =?us-ascii?Q?lOqm4YNCg1RfzZaZRdovUn9trAiMQG0I5bMk6OI9cJ/dOZdEZyqUm3UR5ItY?= =?us-ascii?Q?vIlzR9zUlukNyADoGJE5NhGPno2e4DrCCRk8RApgtGXdA3gYJNH0F5bbQFuR?= =?us-ascii?Q?t2hE9Gmy0OPs2oKRcpyedfLc2cxQQp5K96UYuMu80eROEWS5rRHgIfGGP/qS?= =?us-ascii?Q?akJoFkESiRys5UvMqU5qNUPi1khVJI4vpRCSn/DkH/GGFpbTS8EHhuJkPTjY?= =?us-ascii?Q?o72MPGb23Sqxbupa37UEuWodhXlsSEQSUfhFEPEqzJ0RfsFPiINOp3magQfn?= =?us-ascii?Q?kqsiWGrJqoCbxrHX+DJvynst7piX6j/vC5/Khk0HeQ5BAAIcLWB8B2rid2T4?= =?us-ascii?Q?Oeyw2lrtG10HjX6qbvVrw0RPOEFons9adfllk3nAJYOEdtoeduxIkM/j7zPg?= =?us-ascii?Q?UPDlNCZkxlxAMUuuG6pf/UlDQOZ2qQRVSbk421yMFaJ4f87HFUjbi8DXlNUr?= =?us-ascii?Q?A46RyFJUIuaqNZxGe2JBkmuf4+EneLpvecuXPx76T3yCWqV37IdQflTM6yDQ?= =?us-ascii?Q?dVDDJIRTsxD3J/UqZ8UlYoqhxaKNl6QvnejA6GkPwSsJ7Yl6gK9V8BE/j6bR?= =?us-ascii?Q?cW82c7eHVsE248giUdoBMziIdaxwiRFrk9imnKnh934z6mIrRlZkbdFlBnny?= =?us-ascii?Q?wKTLnsI3nS56pfMGRWOhBl0h48DmkcrjOil68eJH86hC47r/uQiz8Tz9H2O8?= =?us-ascii?Q?T/2A59ISMlVAACc35pS39R8var/cQPyUuD5zJooqWW1c/+vyNTeJFLaMiCmW?= =?us-ascii?Q?HnzVdGTSQmibZZAo8pK/utKwvUjZ5NW5RMOhrlMyCsh0EkioDYTx2v7sOC5P?= =?us-ascii?Q?j1w6A52FkC1jjamgCthmTfTh1wTcaFKQD0k2gtOk/+44Ogry6HpNiyOcJDXc?= =?us-ascii?Q?rv3GUejdEJldQxYmur8DHheC9Pgm5zW47k+OLbCBZfCI1HPjaoyxvxR5Sh7m?= =?us-ascii?Q?ao7+Dfx8fnElVBT1xD3/qk/9SlAspxa/se5/3N9C9VylTqIGUHuKPeECjx68?= =?us-ascii?Q?71EGKWDh4E/sABZtC2XA/7+j7druBQ/fDrxmSqjNHU8Xlorf/qLcjgmYJK8A?= =?us-ascii?Q?v5lhqOHKdd7sVzfgsiULhp8kmiCas7Y8xiQjlrXtJMYUQC3arvT8LE5i4AWj?= =?us-ascii?Q?Nz4icCgfI3Agp20SGd42IiFkaZ44+TuxjxZ1R9UcfgEKSVs69q5WC6Hcf1NQ?= =?us-ascii?Q?oLL6t2ib2CA12OgG6M=3D?= X-Microsoft-Exchange-Diagnostics: 1; SN2PR07MB2528; 6:D6rBw5idtqWzLK1aAEMrZ5KZ4EmP+ESW+/OS/lT+RLHPBA4cBeBtqlKszP1+t/FXfR4tUI4zgOWqH36lPcVllO4rttdYpHyGg4B15mW7eQw4fAqhIG7FO6Q0AN9mfepOge6SAPoU9zjft3OjYJNEX1BSfaa391rSlNu7NhOfgxotQhc4RCqnsyRqgH/LtIQQfYWoOPVGn9pHjrtA3r8CmYt+d4RFsw28fsbczmub9vmnckounJhTb5bpZZ2H8RkQw+Ao02lu2aEY3Qf54rUPgHAKBMN6+b2XcBc8PrymkHmzoQmjaUyOfR3ByTdPkVs8GKa0HfRvbEw2T9Eyeo8EYg==; 5:6aiAWhkN+l7q3cBw3L1Yu71izgo2g83q1onrSaIwE0cnDR5pDYA+jLH3Ku88bvoSQh3WU1UzcToYYBYxytyivRRm66ZjVEBGmGXcpjByivDtKYXjcxk2G3gn4hlmxU2JcWvr1oiG3WNmTwxeFCK2wQ==; 24:i+jp9qeTvakmy5w7yCLEvhXBaU2+W05YUh1gP4kyaTT/ufX+vrxgHyUX+ktA6FAnYqcC1uIQAXm41xCleSk2uif+xT0kBITrxBCcXW2rmvc=; 7:N+wK+IWwf0DOZKCNVHHKLktEzvdKH16PV6R3BLqltd+G98CihYp4TQhejIKaQeLT4cp8Wynn0uOrAJO8OrkYjzyBBsk4gAF3/KQ2nt6Klv+5FdfobksaeLrVSUxbJqZBsD7UNFRqU3/3Yb6hqRPPb4zWBpRAtHqNUgVXuF/DV0wvlQHMvDC0T1OWEXXLp66EM2zB1vRhRRCAh9dJ2n6J+SkVRtfqC07uvmEkded/1bQ= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Sep 2017 16:35:36.9604 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN2PR07MB2528 Subject: Re: [dpdk-dev] [PATCH v3 1/4] eventdev: add port attribute function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Sep 2017 16:35:40 -0000 -----Original Message----- > Date: Fri, 8 Sep 2017 16:36:52 +0100 > From: Harry van Haaren > To: dev@dpdk.org > CC: jerin.jacob@caviumnetworks.com, Harry van Haaren > > Subject: [PATCH v3 1/4] eventdev: add port attribute function > X-Mailer: git-send-email 2.7.4 > > This commit reworks the port functions to retrieve information > about the port, like the enq or deq depths. Note that "port count" > is a device attribute, and is added in a later patch for dev attributes. > > Signed-off-by: Harry van Haaren > --- > lib/librte_eventdev/rte_eventdev.c | 33 +++++++++++-------- > lib/librte_eventdev/rte_eventdev.h | 49 ++++++++++++---------------- > lib/librte_eventdev/rte_eventdev_version.map | 7 ++++ > test/test/test_eventdev.c | 16 ++++++--- > 4 files changed, 59 insertions(+), 46 deletions(-) > > - > -uint8_t > -rte_event_port_count(uint8_t dev_id) > -{ > - struct rte_eventdev *dev; > + if (!is_valid_port(dev, port_id)) { > + RTE_EDEV_LOG_ERR("Invalid port_id=%" PRIu8, port_id); > + return -EINVAL; > + } > > - dev = &rte_eventdevs[dev_id]; > - return dev->data->nb_ports; > + switch (attr_id) { > + case RTE_EVENT_PORT_ATTR_ENQ_DEPTH: > + *attr_value = dev->data->ports_enqueue_depth[port_id]; > + break; > + case RTE_EVENT_PORT_ATTR_DEQ_DEPTH: > + *attr_value = dev->data->ports_dequeue_depth[port_id]; > + break; IMO, We should have "default:" case here to detect invalid attr_id here and return the error code accordingly in the header file as well. > + }; > + return 0; > } > /** > * Start an event device. > diff --git a/lib/librte_eventdev/rte_eventdev_version.map b/lib/librte_eventdev/rte_eventdev_version.map > index 4c48e5f..a0adde3 100644 > --- a/lib/librte_eventdev/rte_eventdev_version.map > +++ b/lib/librte_eventdev/rte_eventdev_version.map > @@ -51,3 +51,10 @@ DPDK_17.08 { > rte_event_ring_init; > rte_event_ring_lookup; We should delete the remove functions from here. like rte_event_port_dequeue_depth() and rte_event_port_enqueue_depth; > } DPDK_17.05; > + > +EXPERIMENTAL { Note sure we need to add EXPERIMENTAL here.(i.e other section don't have this) > + global: > + > + rte_event_port_attr_get; > + > +} DPDK_17.08;