From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-BY2-obe.outbound.protection.outlook.com (mail-by2nam03on0053.outbound.protection.outlook.com [104.47.42.53]) by dpdk.org (Postfix) with ESMTP id 046BD2B84 for ; Mon, 11 Sep 2017 19:36:37 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=vSQOy8ijNg17pkcTQRt/zR/iLis90Iiz3cAI9J3+US4=; b=fv9Qdu6jdwmN08xhQU5KeCSSdA5PHKkkQB5bfYDyntCL92kklt7KhZxKtkSfvTsTlF+NIOqS382jE46PRB2mfA0TupGYFzngl1hRj2e1mPaVP9hTiVof1omkKef/4WXBhfbg61gakoHIgKa3pY6RxYpyPtLRU+JKJjFOat0zGqQ= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.JacobKollanukkaran@cavium.com; Received: from jerin (106.201.102.0) by SN2PR07MB2527.namprd07.prod.outlook.com (2603:10b6:804:6::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.13.10; Mon, 11 Sep 2017 17:36:34 +0000 Date: Mon, 11 Sep 2017 23:06:17 +0530 From: Jerin Jacob To: Harry van Haaren Cc: dev@dpdk.org Message-ID: <20170911173616.GA26002@jerin> References: <1504883894-43451-1-git-send-email-harry.van.haaren@intel.com> <1504885015-44642-1-git-send-email-harry.van.haaren@intel.com> <1504885015-44642-4-git-send-email-harry.van.haaren@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1504885015-44642-4-git-send-email-harry.van.haaren@intel.com> User-Agent: Mutt/1.9.0 (2017-09-02) X-Originating-IP: [106.201.102.0] X-ClientProxiedBy: MA1PR01CA0104.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a00:1::20) To SN2PR07MB2527.namprd07.prod.outlook.com (2603:10b6:804:6::27) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 179229c4-cad4-4223-381a-08d4f93ba6ae X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(300000502095)(300135100095)(22001)(2017030254152)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:SN2PR07MB2527; X-Microsoft-Exchange-Diagnostics: 1; SN2PR07MB2527; 3:UWJiu1071NdHJzUjR7EpNTh6OlMk2vlQx0CBUQhm8HEQ0Xx7bXCBUanQH9w8bsa8qv4b+7h5h403SbUtl4uTgLSKo6Zi07xBRgKsw8SvA48xQ2+KJS+OxtgG6xGTIoBdrDsZkomua8xJnqqdf9JAkX37Ch6U299rpNAR5GJuEsajhNkWOBnjyGPymE8pMUpNeSII87u3qynq7nc9D38aYS0I4dF79M0kFulHobs+/yxJzeFjvM3+80RcnPU9qPA8; 25:PC2nl8o1wnrVxp3MeNHHPCwvNrDAFSamDT1Denn69fpzgMb5txgkfaOzMF4ip/SaoilYyedeZUR99myGDe+uz94nrizs4BfC0s5B1yf/85ERyQNTtXb3qxvuXN6S2UPM4QcuB7BAGGbVdJdMIltRCu5UlTpMJkdmRWAI/XMk+g7sFmWwi3oF7K294hRR5Rahi5MONFwWYWO8/h5np8qLBCbDoJx/gdxWtGCxrLRjv+D12rPVQtL1DD7aaoq3hD/rKDquPB5pj0jt8i4/fORdRnA1IlavvWO7kWh1y8ObcphAvHkIpYRf8pkCC/ibfywWoiKtC8QTfELOSIlV0G54ag==; 31:P1pcOrQcBiNsherWy/nu9nSq9UoKeUdSfhLQ6mcTaDsMFt5n0/VYh6eOQxwjDWQOpRx8wDYvPcS4rvPx3BhstnoUjCuwXM6lXJ3Z80gJdW7Jd6hea+2/aKtoOzUX4ccuHqpetCrCBpMyUl/vnJp7jUB8PVU1ZZHwH7NB71+G1C5BYg+QRczHlDcRXmzUiSnby8BPNfTJbIRCv8+1PPwSz3lh3UCuAQTVc4eQnwBTlL0= X-MS-TrafficTypeDiagnostic: SN2PR07MB2527: X-Microsoft-Exchange-Diagnostics: 1; SN2PR07MB2527; 20:antoVoRx/ro3qoiRHe/kz6H8XPIzy+BzpdmNErigXVX7NhXQ8hK7cSshKvr5g1GLclp2lS/b5E/WUZgg2At79NVHd0segMTyAE5wzOJZfTZVK6rg7/WopM4f6jH3pNQW0xKK6yiNncU4c8zlo+IpWe4UZRq35d4Gx76dEWbP9h+FqhF2hACHk1QGy3vpjsBLu11kl3luv3e4uNa95MoUnf4d2m2ZTzmzdYKRFPgNGNa79yh1/EkqVlr0tpvr8A3bexUoEj1HkLD1nlX0PMpNmduKLjePimq1tTt2p//ftZdssa39i+2wSqdGae21RdS8jU4/HDmD8XWDND2x0eNcg9bOQz1fXJN+qkS7tCsYCCNn+mNsuImNeLuzIgjwLHhuYFcQwbPavhcIVkhkoRjmifaahwdIjOU4JKYuSi/ewDMRkgxDzJ1Wo2QPSz2hiPM9saAj5cq1ZSBmyE5uIhu1/hoDhf9kor4FZ9ewcXMp0ebLPSLYnJOaO8Ysl4rJykLjB9iaWk3NrBFKSe0h281sdl1yjc+OodT994FDSYHw3Ya8YW6F0pFECJOka4nbqn9xY+2rdEwyCTx9QetEcG9s8V4LRa6u1/70pbJupjnoUOo=; 4:YvV7sSNmYjl76h5cf2im9LBmIs94v/ijhchpDgmvakNim9ZC93Klx2tz2OkfjaPjgbvo1YJTisYHEy+OSkF1+Z6Fg6+D7bwwusPPP31b2m8aY3yEmWJpSxpl5iTno2Cz8I4SF4XAyvlhNMcFgFqAyAzDbMbsr1hHb3itdb3pcOq1NavjGZFs988vT1rEcZccvONZRMZE1cLOiR2+2RgwIjl+3BonG+7uy02qRrHqLg0WwZ76k0mGFqoT7lqPZvPuSpM49vhxFsjI06rn9Oa/su6hFXkmGVVkUwmCIf0M3fk= X-Exchange-Antispam-Report-Test: UriScan:(228905959029699); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(10201501046)(100000703101)(100105400095)(3002001)(93006095)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(20161123558100)(20161123560025)(20161123564025)(20161123555025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:SN2PR07MB2527; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:SN2PR07MB2527; X-Forefront-PRVS: 04270EF89C X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6009001)(13464003)(189002)(199003)(72206003)(42882006)(2906002)(110136004)(229853002)(101416001)(6246003)(189998001)(2950100002)(55016002)(8936002)(97736004)(305945005)(6916009)(105586002)(4001350100001)(4326008)(25786009)(7736002)(478600001)(50466002)(54356999)(76176999)(6496005)(6116002)(81156014)(81166006)(47776003)(23726003)(5009440100003)(1076002)(68736007)(33656002)(50986999)(9686003)(42186005)(53936002)(66066001)(33716001)(6666003)(575784001)(8676002)(106356001)(83506001)(5660300001)(3846002)(18370500001)(7756004); DIR:OUT; SFP:1101; SCL:1; SRVR:SN2PR07MB2527; H:jerin; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; SN2PR07MB2527; 23:45SCKPg7gWStS4xo8XhRq2+5ZlVrO9ijr5oqwIYYI?= =?us-ascii?Q?d+zPoyyM+ZWZRzMqaftzuiT8qqJyfc8+MnFENJB6O6kRghFtTb6eAgq7j8fY?= =?us-ascii?Q?3qnSgzC3WTD/yyOSN6QPOijVcac837T7UnVvct31p8ZY1LhcsuzFYeX1a2Ao?= =?us-ascii?Q?LnDgVUbxUDJcHMYZNWHmmE83b9zTnKZ8JADGIvqxF74mxvehrdTGhvUUuW5j?= =?us-ascii?Q?E5w5oPwfxCMEYkOwq/TM5+doXS58gKbuGCUWMgpwEd9+SgHiYRSMl4FLpGj+?= =?us-ascii?Q?a8YVbI3JZ0+4HaBhZZcctO+rEg4JlU/ykL/hWlj6FybWxOIf8GTXI1ofhYcw?= =?us-ascii?Q?asIflD/7RdPg9ake7kvFc0Aags57pUcjKA0qcP7abcJyq+fU746hB7ymTO9N?= =?us-ascii?Q?QsDdLnxC9AdeDirXVmcgNB58IWIWEHWIb4VESsokKvzBockX8SQBcF82xKqf?= =?us-ascii?Q?GmdHhbZ7oCbTf1cLm4wP3ZbS94SDr4a+oGGwWo7H/3unubyxokpbZgbc30/z?= =?us-ascii?Q?bLcQf9LseefMSTVkQ7b+rB0uTIp4PJqYVauEy7osaqGwwaR6x5zMPhcEphA5?= =?us-ascii?Q?0wFOgifN10q6SIWFMCPiaB8v/yP6QeacNEwJgZucz7RhWrJMRxsXemYhfqxP?= =?us-ascii?Q?2trIGyvLr2Mdl3QAV+JaM0XGliRfH+jxj4UOGzPQf84eHKqPg+dsOeytUD5N?= =?us-ascii?Q?+HnIPNGrtwMpGmKuoP/V/kZAguIWR4UW+kGtr2TCB6CBvb93Phc8Fe8vUPXQ?= =?us-ascii?Q?40nTQyg2MopJr6QbhFSOZNW8Fra9ECtQgEevTE/+0PLlEhKFJac9DMhp1yPI?= =?us-ascii?Q?M37BRCu1HCECw2B/VR0qxVgnQHNGHdclTZJLcrH0leZ5mLRnnaCZ37sZdk3M?= =?us-ascii?Q?9CET8r3HI7xXON7oW+Dk86GZtbfAZaSYuJImFHKVRGHKd7JWqnXuto0CFkNi?= =?us-ascii?Q?brISb2aX5tGvIIaSEy+GRlI1PaN9MZpXrjyLAdyivhr4tjKRf1D0gVgeMX9t?= =?us-ascii?Q?XIpVHGdRCFVsAyDH+KCzgkD0/sevuf9sSbk5jZ83HLbDZizRuD0yKurvSNY2?= =?us-ascii?Q?bHmlxjwyxh0m1jgmc+Qg9aZzU9QgR4fN/aaJAJv4CSTHd2hrRmFOvfXply+4?= =?us-ascii?Q?bbG3tA2QgAYbLz9TdAwGqCJ620ZFXWfi/rf6Dn0ysWyaBMrIeifV4uTyIj4T?= =?us-ascii?Q?xxahHXKB/Lwby0N18fWOj0a4UgsGJjJnN8GghkrCiC1cG5SwdFGG0xAIYH5h?= =?us-ascii?Q?wn4x4GwAh14UFugDEI=3D?= X-Microsoft-Exchange-Diagnostics: 1; SN2PR07MB2527; 6:MCEkATiqVUAs/pD8Y5sIMkBe0EHxzed3Vvgc4cw0FKcxC98sKgtV9e7I3FozO+Kj5WMG0QdU4fvZ7UP4pD3xXJNOVGqnUOzJM5y8kpPnM2zslMiMV5+7eDxhiQeoVUCefubyb6azRLAopjdY9X76AXGRAGpTMTNJKtyYyh1321S7ZCARPKf6BMlkoeBc7dGo9fM+ryvSfEW5Se8YQ1R+fF5rvYLM+PJLq0K/Wkis81j1iyOjqFVTSUDiiYbgJkg32CzehhbKIWAhbJH1wX2/7OFeA0MxhG0PiNCA02D8CqxIZWVj/Gx9tp+WBFZeoM6LD82mfUDdcc24EK/pW3EDrw==; 5:RX/Wn8veEuYPf9RcHklLCwCRVg/QDxs7RMZdb9M9anJAIZdD7UcfT58ta7DVV5eI863AgoHdI720mUmhPJIG3ijGjFeRbxgrGXyW8j5q7nzROpqn52PnSPc/uuRIdEGM0cudP23A6aZfL7hThllctg==; 24:38cT91uWNZW0sltZI0ot60znEtrZQCXAwclHLuvuefQuc3KcjeHSJr8AciaCxtjzhcfmXbuFCFF31GF8EGVmkS4BgR0WZyAq5kFa6ODqPKA=; 7:O/Y/Y5v708pRXXEpbHvzKXLj4i2TuuiGXa7qXk+UutMiIIs+mNM2UesDnlmxO6rCG48dQroGNdSMq8e0A/lWL9ktXnMAZPrCQgEN3HSe4bgh/Das899JyRiO7UXBGpT3gmA1d2hm8J7n9ALzPF7Ov2fj1idjv7MUmhiBj+tcgT713mx0HW1Cmo7bSt6NPQjCgJi+C4Zme4Y1zG1y8+hgCa0UghubUEjp70vhDmk1Wo4= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Sep 2017 17:36:34.8404 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN2PR07MB2527 Subject: Re: [dpdk-dev] [PATCH v3 3/4] eventdev: add queue attribute function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Sep 2017 17:36:38 -0000 -----Original Message----- > Date: Fri, 8 Sep 2017 16:36:54 +0100 > From: Harry van Haaren > To: dev@dpdk.org > CC: jerin.jacob@caviumnetworks.com, Harry van Haaren > > Subject: [PATCH v3 3/4] eventdev: add queue attribute function > X-Mailer: git-send-email 2.7.4 > > This commit adds a generic queue attribute function. It also removes > the previous rte_event_queue_priority() and priority() functions, and > updates the map files and unit tests to use the new attr functions. > > Signed-off-by: Harry van Haaren > --- > lib/librte_eventdev/rte_eventdev.c | 47 ++++++++-------- > lib/librte_eventdev/rte_eventdev.h | 49 ++++++++--------- > lib/librte_eventdev/rte_eventdev_version.map | 3 +- > test/test/test_eventdev.c | 80 +++++++++++++++++++++------- > test/test/test_eventdev_octeontx.c | 75 +++++++++++++++++++------- > 5 files changed, 166 insertions(+), 88 deletions(-) > > diff --git a/lib/librte_eventdev/rte_eventdev.c b/lib/librte_eventdev/rte_eventdev.c > index 4b1c0be..3756ec7 100644 > --- a/lib/librte_eventdev/rte_eventdev.c > +++ b/lib/librte_eventdev/rte_eventdev.c > @@ -609,27 +609,6 @@ rte_event_queue_setup(uint8_t dev_id, uint8_t queue_id, > return (*dev->dev_ops->queue_setup)(dev, queue_id, queue_conf); > } > > static inline int > is_valid_port(struct rte_eventdev *dev, uint8_t port_id) > { > @@ -794,6 +773,32 @@ rte_event_port_attr_get(uint8_t dev_id, uint8_t port_id, uint32_t attr_id, > } > > int > +rte_event_queue_attr_get(uint8_t dev_id, uint8_t queue_id, uint32_t attr_id, > + uint32_t *attr_value /*out */) > +{ > + struct rte_eventdev *dev; > + > + if (!attr_value) > + return -EINVAL; > + > + RTE_EVENTDEV_VALID_DEVID_OR_ERR_RET(dev_id, -EINVAL); > + dev = &rte_eventdevs[dev_id]; > + if (!is_valid_queue(dev, queue_id)) { > + RTE_EDEV_LOG_ERR("Invalid queue_id=%" PRIu8, queue_id); > + return -EINVAL; > + } > + > + switch (attr_id) { > + case RTE_EVENT_QUEUE_ATTR_PRIORITY: > + *attr_value = RTE_EVENT_DEV_PRIORITY_NORMAL; > + if (dev->data->event_dev_cap & RTE_EVENT_DEV_CAP_QUEUE_QOS) > + *attr_value = dev->data->queues_prio[queue_id]; > + break; The same switch case comment. > + }; > + return 0; > +} > + > +int > rte_event_port_link(uint8_t dev_id, uint8_t port_id, > const uint8_t queues[], const uint8_t priorities[], > uint16_t nb_links) > diff --git a/lib/librte_eventdev/rte_eventdev.h b/lib/librte_eventdev/rte_eventdev.h > index e931eb2..cd3026d 100644 > --- a/lib/librte_eventdev/rte_eventdev.h > +++ b/lib/librte_eventdev/rte_eventdev.h > @@ -606,33 +606,6 @@ int > rte_event_queue_setup(uint8_t dev_id, uint8_t queue_id, > const struct rte_event_queue_conf *queue_conf); > > -/** > - * Get the number of event queues on a specific event device > - * > - * @param dev_id > - * Event device identifier. > - * @return > - * - The number of configured event queues > - */ > -uint8_t > -rte_event_queue_count(uint8_t dev_id); > - > -/** > - * Get the priority of the event queue on a specific event device > - * > - * @param dev_id > - * Event device identifier. > - * @param queue_id > - * Event queue identifier. > - * @return > - * - If the device has RTE_EVENT_DEV_CAP_QUEUE_QOS capability then the > - * configured priority of the event queue in > - * [RTE_EVENT_DEV_PRIORITY_HIGHEST, RTE_EVENT_DEV_PRIORITY_LOWEST] range > - * else the value RTE_EVENT_DEV_PRIORITY_NORMAL > - */ > -uint8_t > -rte_event_queue_priority(uint8_t dev_id, uint8_t queue_id); > - > /* Event port specific APIs */ > > /** Event port configuration structure */ > @@ -765,6 +738,28 @@ rte_event_port_attr_get(uint8_t dev_id, uint8_t port_id, uint32_t attr_id, > uint32_t *attr_value /*out */); We can remove explicit /* out */. > > /** > + * The priority of the queue. > + */ > +#define RTE_EVENT_QUEUE_ATTR_PRIORITY 0 > + > +/** > + * Get an attribute from a queue. > + * > + * @param dev_id Eventdev id > + * @param queue_id Eventdev queue id > + * @param attr_id The attribute ID to retrieve > + * @param[out] attr_value A pointer that will be filled in with the attribute > + * value if successful > + * > + * @retval 0 Successfully returned value > + * -EINVAL invalid device, queue or attr_id provided, or attr_value > + * was NULL > + */ > +int > +rte_event_queue_attr_get(uint8_t dev_id, uint8_t queue_id, uint32_t attr_id, > + uint32_t *attr_value /*out */); > + We can remove explicit /* out */.