From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 651C62B84 for ; Tue, 12 Sep 2017 11:56:07 +0200 (CEST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Sep 2017 02:56:05 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,382,1500966000"; d="scan'208";a="1013522528" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.221.24]) by orsmga003.jf.intel.com with SMTP; 12 Sep 2017 02:56:03 -0700 Received: by (sSMTP sendmail emulation); Tue, 12 Sep 2017 10:56:03 +0100 Date: Tue, 12 Sep 2017 10:56:03 +0100 From: Bruce Richardson To: "Van Haaren, Harry" , "dev@dpdk.org" Message-ID: <20170912095603.GA42500@bricha3-MOBL3.ger.corp.intel.com> References: <20170901100416.80264-1-bruce.richardson@intel.com> <20170901100416.80264-2-bruce.richardson@intel.com> <59AF69C657FD0841A61C55336867B5B0721D3217@IRSMSX103.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <59AF69C657FD0841A61C55336867B5B0721D3217@IRSMSX103.ger.corp.intel.com> Organization: Intel Research and =?iso-8859-1?Q?De=ACvel?= =?iso-8859-1?Q?opment?= Ireland Ltd. User-Agent: Mutt/1.8.3 (2017-05-23) Subject: Re: [dpdk-dev] [PATCH 01/17] build: add initial infrastructure for meson & ninja builds X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Sep 2017 09:56:07 -0000 On Fri, Sep 08, 2017 at 04:13:58PM +0000, Richardson, Bruce wrote: > > > > -----Original Message----- > > From: Van Haaren, Harry > > Sent: Friday, September 8, 2017 5:03 PM > > To: Richardson, Bruce ; dev@dpdk.org > > Cc: Richardson, Bruce > > Subject: RE: [dpdk-dev] [PATCH 01/17] build: add initial infrastructure > > for meson & ninja builds > > > > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Bruce Richardson > > > Sent: Friday, September 1, 2017 11:04 AM > > > To: dev@dpdk.org > > > Cc: Richardson, Bruce > > > Subject: [dpdk-dev] [PATCH 01/17] build: add initial infrastructure > > > for meson & ninja builds > > > > > > > > > diff --git a/config/meson.build b/config/meson.build > > > > > +# set the machine type and cflags for it machine = > > > +get_option('machine') dpdk_conf.set('RTE_MACHINE', machine) > > > +add_project_arguments('-march=@0@'.format(machine), language: 'c') # > > > +some libs depend on maths lib add_project_link_arguments('-lm', > > > +language: 'c') > > > + > > > +# add -include rte_config to cflags > > > +add_project_arguments('-include', 'rte_config.h', language: 'c') > > > + > > > +# disable any unwanted warnings > > > +unwanted_warnings = [ > > > + '-Wno-address-of-packed-member', > > > + '-Wno-format-truncation' > > > +] > > > > > > Feedback from usage while developing new features; > > - Mis-matched integer sign comparison doesn't cause a warning > > - And -Werror isn't set by default > > > Will fix the former in V2. > For the latter, I already have a patch for it that approximates the behavior of the existing system - i.e. a "developer build" setting, which is "off" by default, except when you are building from a git checkout in which case it defaults to "on". However, I don't think I'll include that in V2, as having Werror when we are not reasonably sure we have fixed all warnings in the code for all supported compilers and distros is a bad idea IMHO. > > > Adding these as per below fixes things... but for cleanliness "unwanted > > warnings" should probably be renamed, we want more warnings! :D > > > > # disable any unwanted warnings > > unwanted_warnings = [ > > '-Werror', > > '-Wno-address-of-packed-member', > > '-Wno-format-truncation', > > '-Wsign-compare', > > ] > > > Actually, I'd rather keep it as a list of warnings to disable for now. Enabling warnings should be handled differently, as we may only enable specific warnings depending on the build type being done. > On second-thoughts, for V2 I will do as you suggest and add in the extra warnings '-Wsign-compare' and '-Wcast-qual', to the existing warnings list. It simplifies the code and we can just split them out later if we want them only for certain build targets. For now, I don't think that is needed, so I'll keep it simple. /Bruce