From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dharton@cisco.com>
Received: from rcdn-iport-4.cisco.com (rcdn-iport-4.cisco.com [173.37.86.75])
by dpdk.org (Postfix) with ESMTP id 7436D2C2A
for <dev@dpdk.org>; Tue, 12 Sep 2017 15:02:16 +0200 (CEST)
X-IronPort-AV: E=Sophos;i="5.42,383,1500940800"; d="scan'208";a="294333762"
Received: from rcdn-core-2.cisco.com ([173.37.93.153])
by rcdn-iport-4.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
12 Sep 2017 13:02:15 +0000
Received: from cpp-rtpbld-31.cisco.com (cpp-rtpbld-31.cisco.com [172.18.5.114])
by rcdn-core-2.cisco.com (8.14.5/8.14.5) with ESMTP id v8CD2Fx4015621;
Tue, 12 Sep 2017 13:02:15 GMT
Received: by cpp-rtpbld-31.cisco.com (Postfix, from userid 140087)
id 47DB1595; Tue, 12 Sep 2017 09:02:15 -0400 (EDT)
From: David Harton <dharton@cpp-rtpbld-31.cpprtplab>
To: beilei.xing@intel.com, jingjing.wu@intel.com
Cc: dev@dpdk.org, David Harton <dharton@cisco.com>
Date: Tue, 12 Sep 2017 09:02:10 -0400
Message-Id: <20170912130210.18288-1-dharton@cpp-rtpbld-31.cpprtplab>
X-Mailer: git-send-email 2.10.3.dirty
In-Reply-To: <20170822222146.36912-1-dharton@cisco.com>
References: <20170822222146.36912-1-dharton@cisco.com>
Subject: [dpdk-dev] [PATCH v2] i40e: fix i40evf_add_mac_addr to permit
multicast addresses
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 12 Sep 2017 13:02:16 -0000
From: David Harton <dharton@cisco.com>
The i40e maintains a single MAC filter table for both
unicast and multicast addresses. The i40e_validate_mac_addr
function was preventing multicast addresses from being added
to the table via i40evf_add_mac_addr. Fixed the issue by
adjusting the check in i40evf_add_mac_addr.
Fixes: 4861cde46116 ("i40e: new poll mode driver")
Fixes: 97ac72aa71a9 ("i40e: support setting VF MAC address")
Signed-off-by: David Harton <dharton@cisco.com>
---
v2
* Removed multicast check in i40evf_add_mac_addr.
v1
* Removed multicast check in i40e_validate_mac_addr.
drivers/net/i40e/i40e_ethdev_vf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c
index f6d8293..5916d11 100644
--- a/drivers/net/i40e/i40e_ethdev_vf.c
+++ b/drivers/net/i40e/i40e_ethdev_vf.c
@@ -888,7 +888,7 @@ i40evf_add_mac_addr(struct rte_eth_dev *dev,
int err;
struct vf_cmd_info args;
- if (i40e_validate_mac_addr(addr->addr_bytes) != I40E_SUCCESS) {
+ if (is_zero_ether_addr(addr) != I40E_SUCCESS) {
PMD_DRV_LOG(ERR, "Invalid mac:%x:%x:%x:%x:%x:%x",
addr->addr_bytes[0], addr->addr_bytes[1],
addr->addr_bytes[2], addr->addr_bytes[3],
--
2.10.3.dirty