From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stephen@networkplumber.org>
Received: from mail-pg0-f52.google.com (mail-pg0-f52.google.com [74.125.83.52])
 by dpdk.org (Postfix) with ESMTP id EC8CEDE0
 for <dev@dpdk.org>; Tue, 12 Sep 2017 23:52:00 +0200 (CEST)
Received: by mail-pg0-f52.google.com with SMTP id d8so23679416pgt.4
 for <dev@dpdk.org>; Tue, 12 Sep 2017 14:52:00 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=networkplumber-org.20150623.gappssmtp.com; s=20150623;
 h=date:from:to:cc:subject:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=BYYC1ZHHeZr3xKEhzVqoIxT7LYldWVdpsSsGfIUQHEE=;
 b=McnlEeZm51vunRtBpVCFpC80KkxDIN+rUVAC/BKAqUMhOfEuh0d/615NFRa9c0QCRZ
 8OeYUZ94U1xCbGi0t8dErlofbX+eBpQMSk3BT26hTD6h0DNfCLxTv/diMQD8xveGtqzX
 kdugpClPhbQLSTBxaBAga23JG9IDsn/ZLp+x3lahcT5SpGNJuKSw5RMVFs4CaH1YqhEC
 rzkr6eH5EUtvmo3+fsy1F81qFQTP/3e/yXrjtrF7B2QzFTqN1WIqdATK5sHD2iOk0mWg
 KrvNCkaeQ7y9Fj/6BakOnhQ/3yUsxHAjA1dugMCk2vXCmVhgWSNLQ1n2clkbfYr24s40
 Ox/g==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=BYYC1ZHHeZr3xKEhzVqoIxT7LYldWVdpsSsGfIUQHEE=;
 b=Y/IczP++ATvCjd8CV7DSfrIATE18axb14cKs6gLAE0lQTv90nz5GvazAOfd1hWs5+m
 hyWkYzuTEf5BpmtrKfUoRcuYPNxFjROCwtwmezkk/8yNKMEPb76CBn8EDVZIAUSKG0j5
 /NwCR01kJmvocDkLYyeb9saCPqdT/oNnMFYbFeuIYhbmcByZR06gdwLQtnbiG1rHOzbn
 YE/ArrycceIDV+udC2AwlWSTw0guvAyWP4FTw//po3U1NPxe+zYz30c9bFZUT+R/lOQf
 /KX9564V/G11cJEn0LYBalF8cuUOG2dbvY/gfy0rwWRgPOugYNBJ5mzR+TYBTk2bpeRt
 9HKg==
X-Gm-Message-State: AHPjjUj7+V6f+sZLpk+P3O/JWbPHZk7a1avU5te/4IDtTOUDsgu2w3Qy
 Dvmxj6Qpag2Y69FOTjgvOg==
X-Google-Smtp-Source: ADKCNb7LEyyGEKNWgG1vuNU/0UXeUBJSFNOH2akk7iwpJSxTjw0aI1YuHTAgletVTe6iRNbmAc+Gzw==
X-Received: by 10.99.120.3 with SMTP id t3mr15767142pgc.388.1505253120160;
 Tue, 12 Sep 2017 14:52:00 -0700 (PDT)
Received: from plumbers-lap.home.lan ([12.145.98.253])
 by smtp.gmail.com with ESMTPSA id i87sm13734240pfi.184.2017.09.12.14.51.59
 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);
 Tue, 12 Sep 2017 14:52:00 -0700 (PDT)
Date: Tue, 12 Sep 2017 14:51:57 -0700
From: Stephen Hemminger <stephen@networkplumber.org>
To: Andrew Rybchenko <arybchenko@solarflare.com>
Cc: <dev@dpdk.org>, Ivan Malov <ivan.malov@oktetlabs.ru>
Message-ID: <20170912145157.0794e9f7@plumbers-lap.home.lan>
In-Reply-To: <1504880151-15394-1-git-send-email-arybchenko@solarflare.com>
References: <1504880151-15394-1-git-send-email-arybchenko@solarflare.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH 1/2] net/sfc: free mbufs in bulks on EF10
 native Tx datapath reap
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 12 Sep 2017 21:52:01 -0000

On Fri, 8 Sep 2017 15:15:50 +0100
Andrew Rybchenko <arybchenko@solarflare.com> wrote:

> +			txd->mbuf = NULL;
> +			if (m == NULL)
> +				continue;
> +
> +			if ((nb == RTE_DIM(bulk)) ||
> +			    ((nb != 0) && (m->pool != bulk[0]->pool))) {
> +				rte_mempool_put_bulk(bulk[0]->pool,
> +						     (void *)bulk, nb);
> +				nb = 0;
>  			}
> +

Why not add rte_mbuf_free_bulk (inline) to base code, rather than recoding
everywhere?