From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 8CB80F94 for ; Tue, 12 Sep 2017 17:46:22 +0200 (CEST) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Sep 2017 08:46:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,383,1500966000"; d="scan'208";a="310809603" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.221.24]) by fmsmga004.fm.intel.com with SMTP; 12 Sep 2017 08:46:19 -0700 Received: by (sSMTP sendmail emulation); Tue, 12 Sep 2017 16:46:18 +0100 Date: Tue, 12 Sep 2017 16:46:18 +0100 From: Bruce Richardson To: "Wiles, Keith" Cc: "dev@dpdk.org" , "nhorman@tuxdriver.com" , "luca.boccassi@gmail.com" , "Van Haaren, Harry" Message-ID: <20170912154618.GA39796@bricha3-MOBL3.ger.corp.intel.com> References: <20170901100416.80264-1-bruce.richardson@intel.com> <20170912103809.140473-1-bruce.richardson@intel.com> <384F7233-089F-4D6D-98C8-93FC26166254@intel.com> <20170912132416.GA24040@bricha3-MOBL3.ger.corp.intel.com> <0B16187C-2403-46D9-BCA6-A20659DF3CB8@intel.com> <3F7399EA-4714-457B-BA8F-04888773FE82@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <3F7399EA-4714-457B-BA8F-04888773FE82@intel.com> Organization: Intel Research and =?iso-8859-1?Q?De=ACvel?= =?iso-8859-1?Q?opment?= Ireland Ltd. User-Agent: Mutt/1.8.3 (2017-05-23) Subject: Re: [dpdk-dev] [PATCH v2 00/17] build DPDK libs and some drivers with meson/ninja X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Sep 2017 15:46:23 -0000 On Tue, Sep 12, 2017 at 03:00:13PM +0100, Wiles, Keith wrote: > > > On Sep 12, 2017, at 8:26 AM, Wiles, Keith wrote: > > > >> > >> On Sep 12, 2017, at 8:24 AM, Richardson, Bruce wrote: > >> > >> On Tue, Sep 12, 2017 at 02:21:22PM +0100, Wiles, Keith wrote: > >>> > >>>> On Sep 12, 2017, at 5:37 AM, Bruce Richardson wrote: > >>>> > >>>> V2 changes: > >>>> * fixed copyright notices, updated 2016 to 2017 > >>>> * removed dependency on kconfig file in kernel build tree > >>>> * marked pmdinfogen as a "native" binary, in preparation for future cross- > >>>> compilation work > >>>> * added in additional warning flags for compatibility with existing system > >>>> —— > >>> > >>> > >>>> Once reviewed and tested a bit, I hope to apply this set - or a new > >>>> revision of it - to the build-next tree, to serve as a baseline for others > >>>> to use and to add the missing functionality to. > >>> > >>> I would really like to see these patches in a build-next tree as it is much easier to work with and help with changes then patches on the master. > >>> > >>> When can we have a build-next tree created? > >>> > >> Tree already exists. I'm just waiting on a bit more review and ideally > >> an ack before I apply this set there. > > > > Not sure what you are waiting for as an ack is not going to make much of a difference IMO :-) > > I pulled down the dpdk-next-build tree and applied the patches, things work and build, but a number of compiler warns pop up. I think we can ack this one and I know a number of things need to be fixed. > > So I am going to ack this patch set for the dpdk-next-build tree. > > Acked-by: Keith Wiles > Yep, compiler warnings should hopefully be fixed by these patches which I submitted for inclusion in the main tree. http://dpdk.org/dev/patchwork/patch/28457/ http://dpdk.org/dev/patchwork/patch/28458/ Regards, /Bruce