DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] config: enable igb_uio on arm64 platform
@ 2017-09-14  3:00 Jianbo Liu
  2017-09-14  3:23 ` Jerin Jacob
  2017-09-14  3:53 ` [dpdk-dev] [PATCH v2] armv8/config: " Jianbo Liu
  0 siblings, 2 replies; 8+ messages in thread
From: Jianbo Liu @ 2017-09-14  3:00 UTC (permalink / raw)
  To: dev; +Cc: jerin.jacob, Jianbo Liu

The kernel patch was merged to support pci resource mapping.
https://patchwork.kernel.org/patch/9677441/

So enable igu_uio in the default arm64 configuration.

Signed-off-by: Jianbo Liu <jianbo.liu@linaro.org>
---
 config/common_armv8a_linuxapp | 2 --
 1 file changed, 2 deletions(-)

diff --git a/config/common_armv8a_linuxapp b/config/common_armv8a_linuxapp
index 880313a..6732d1e 100644
--- a/config/common_armv8a_linuxapp
+++ b/config/common_armv8a_linuxapp
@@ -44,8 +44,6 @@ CONFIG_RTE_FORCE_INTRINSICS=y
 # to address minimum DMA alignment across all arm64 implementations.
 CONFIG_RTE_CACHE_LINE_SIZE=128
 
-CONFIG_RTE_EAL_IGB_UIO=n
-
 CONFIG_RTE_LIBRTE_FM10K_PMD=n
 CONFIG_RTE_LIBRTE_SFC_EFX_PMD=n
 CONFIG_RTE_LIBRTE_AVP_PMD=n
-- 
1.9.1

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [dpdk-dev] [PATCH] config: enable igb_uio on arm64 platform
  2017-09-14  3:00 [dpdk-dev] [PATCH] config: enable igb_uio on arm64 platform Jianbo Liu
@ 2017-09-14  3:23 ` Jerin Jacob
  2017-09-14  3:53 ` [dpdk-dev] [PATCH v2] armv8/config: " Jianbo Liu
  1 sibling, 0 replies; 8+ messages in thread
From: Jerin Jacob @ 2017-09-14  3:23 UTC (permalink / raw)
  To: Jianbo Liu; +Cc: dev

-----Original Message-----
> Date: Thu, 14 Sep 2017 11:00:03 +0800
> From: Jianbo Liu <jianbo.liu@linaro.org>
> To: dev@dpdk.org
> CC: jerin.jacob@caviumnetworks.com, Jianbo Liu <jianbo.liu@linaro.org>
> Subject: [PATCH] config: enable igb_uio on arm64 platform
> X-Mailer: git-send-email 1.9.1
> 
> The kernel patch was merged to support pci resource mapping.
> https://patchwork.kernel.org/patch/9677441/
> 
> So enable igu_uio in the default arm64 configuration.
> 
> Signed-off-by: Jianbo Liu <jianbo.liu@linaro.org>

It has a check-git-log error.

➜ [master][dpdk.org] $ ./devtools/check-git-log.sh
Wrong headline format:
	config: enable igb_uio on arm64 platform

With above fix:

Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>

> ---
>  config/common_armv8a_linuxapp | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/config/common_armv8a_linuxapp b/config/common_armv8a_linuxapp
> index 880313a..6732d1e 100644
> --- a/config/common_armv8a_linuxapp
> +++ b/config/common_armv8a_linuxapp
> @@ -44,8 +44,6 @@ CONFIG_RTE_FORCE_INTRINSICS=y
>  # to address minimum DMA alignment across all arm64 implementations.
>  CONFIG_RTE_CACHE_LINE_SIZE=128
>  
> -CONFIG_RTE_EAL_IGB_UIO=n
> -
>  CONFIG_RTE_LIBRTE_FM10K_PMD=n
>  CONFIG_RTE_LIBRTE_SFC_EFX_PMD=n
>  CONFIG_RTE_LIBRTE_AVP_PMD=n
> -- 
> 1.9.1
> 

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [dpdk-dev] [PATCH v2] armv8/config: enable igb_uio on arm64 platform
  2017-09-14  3:00 [dpdk-dev] [PATCH] config: enable igb_uio on arm64 platform Jianbo Liu
  2017-09-14  3:23 ` Jerin Jacob
@ 2017-09-14  3:53 ` Jianbo Liu
  2017-09-14  5:23   ` santosh
  2017-09-14 11:31   ` Hemant Agrawal
  1 sibling, 2 replies; 8+ messages in thread
From: Jianbo Liu @ 2017-09-14  3:53 UTC (permalink / raw)
  To: dev; +Cc: jerin.jacob, Jianbo Liu

The kernel patch was merged to support pci resource mapping.
https://patchwork.kernel.org/patch/9677441/

So enable igu_uio in the default arm64 configuration.

v2:
  - keep headline format

Signed-off-by: Jianbo Liu <jianbo.liu@linaro.org>
---
 config/common_armv8a_linuxapp | 2 --
 1 file changed, 2 deletions(-)

diff --git a/config/common_armv8a_linuxapp b/config/common_armv8a_linuxapp
index 880313a..6732d1e 100644
--- a/config/common_armv8a_linuxapp
+++ b/config/common_armv8a_linuxapp
@@ -44,8 +44,6 @@ CONFIG_RTE_FORCE_INTRINSICS=y
 # to address minimum DMA alignment across all arm64 implementations.
 CONFIG_RTE_CACHE_LINE_SIZE=128
 
-CONFIG_RTE_EAL_IGB_UIO=n
-
 CONFIG_RTE_LIBRTE_FM10K_PMD=n
 CONFIG_RTE_LIBRTE_SFC_EFX_PMD=n
 CONFIG_RTE_LIBRTE_AVP_PMD=n
-- 
1.9.1

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [dpdk-dev] [PATCH v2] armv8/config: enable igb_uio on arm64 platform
  2017-09-14  3:53 ` [dpdk-dev] [PATCH v2] armv8/config: " Jianbo Liu
@ 2017-09-14  5:23   ` santosh
  2017-09-14  9:41     ` Ferruh Yigit
  2017-09-14 11:31   ` Hemant Agrawal
  1 sibling, 1 reply; 8+ messages in thread
From: santosh @ 2017-09-14  5:23 UTC (permalink / raw)
  To: dev


On Thursday 14 September 2017 09:23 AM, Jianbo Liu wrote:
> The kernel patch was merged to support pci resource mapping.
> https://patchwork.kernel.org/patch/9677441/
>
> So enable igu_uio in the default arm64 configuration.
>
> v2:
>   - keep headline format
>
> Signed-off-by: Jianbo Liu <jianbo.liu@linaro.org>
> ---

Perhaps remove v2 from desciption.
Acked-by: Santosh Shukla <santosh.shukla@caviumnetworks.com>

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [dpdk-dev] [PATCH v2] armv8/config: enable igb_uio on arm64 platform
  2017-09-14  5:23   ` santosh
@ 2017-09-14  9:41     ` Ferruh Yigit
  2017-09-14 10:05       ` Jianbo Liu
  0 siblings, 1 reply; 8+ messages in thread
From: Ferruh Yigit @ 2017-09-14  9:41 UTC (permalink / raw)
  To: santosh, dev

On 9/14/2017 6:23 AM, santosh wrote:
> 
> On Thursday 14 September 2017 09:23 AM, Jianbo Liu wrote:
>> The kernel patch was merged to support pci resource mapping.
>> https://patchwork.kernel.org/patch/9677441/
>>
>> So enable igu_uio in the default arm64 configuration.
>>
>> v2:
>>   - keep headline format
>>
>> Signed-off-by: Jianbo Liu <jianbo.liu@linaro.org>
>> ---
> 
> Perhaps remove v2 from desciption.

A quick tip, if you add changelog after "---" in commit log, this will
be visible in commit log and the patch itself, but will be removed
automatically by git am, making maintainer life easy :)

> Acked-by: Santosh Shukla <santosh.shukla@caviumnetworks.com>
> 

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [dpdk-dev] [PATCH v2] armv8/config: enable igb_uio on arm64 platform
  2017-09-14  9:41     ` Ferruh Yigit
@ 2017-09-14 10:05       ` Jianbo Liu
  0 siblings, 0 replies; 8+ messages in thread
From: Jianbo Liu @ 2017-09-14 10:05 UTC (permalink / raw)
  To: Ferruh Yigit; +Cc: santosh, dev

On 14 September 2017 at 17:41, Ferruh Yigit <ferruh.yigit@intel.com> wrote:
> On 9/14/2017 6:23 AM, santosh wrote:
>>
>> On Thursday 14 September 2017 09:23 AM, Jianbo Liu wrote:
>>> The kernel patch was merged to support pci resource mapping.
>>> https://patchwork.kernel.org/patch/9677441/
>>>
>>> So enable igu_uio in the default arm64 configuration.
>>>
>>> v2:
>>>   - keep headline format
>>>
>>> Signed-off-by: Jianbo Liu <jianbo.liu@linaro.org>
>>> ---
>>
>> Perhaps remove v2 from desciption.
>
> A quick tip, if you add changelog after "---" in commit log, this will
> be visible in commit log and the patch itself, but will be removed
> automatically by git am, making maintainer life easy :)
>

Thanks a lot! It's really a great help...

>> Acked-by: Santosh Shukla <santosh.shukla@caviumnetworks.com>
>>
>

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [dpdk-dev] [PATCH v2] armv8/config: enable igb_uio on arm64 platform
  2017-09-14  3:53 ` [dpdk-dev] [PATCH v2] armv8/config: " Jianbo Liu
  2017-09-14  5:23   ` santosh
@ 2017-09-14 11:31   ` Hemant Agrawal
  2017-10-06 21:39     ` Thomas Monjalon
  1 sibling, 1 reply; 8+ messages in thread
From: Hemant Agrawal @ 2017-09-14 11:31 UTC (permalink / raw)
  To: Jianbo Liu, dev; +Cc: jerin.jacob

On 9/14/2017 9:23 AM, Jianbo Liu wrote:
> The kernel patch was merged to support pci resource mapping.
> https://patchwork.kernel.org/patch/9677441/
>
> So enable igu_uio in the default arm64 configuration.
>
> v2:
>   - keep headline format
>
> Signed-off-by: Jianbo Liu <jianbo.liu@linaro.org>
> ---
>  config/common_armv8a_linuxapp | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/config/common_armv8a_linuxapp b/config/common_armv8a_linuxapp
> index 880313a..6732d1e 100644
> --- a/config/common_armv8a_linuxapp
> +++ b/config/common_armv8a_linuxapp
> @@ -44,8 +44,6 @@ CONFIG_RTE_FORCE_INTRINSICS=y
>  # to address minimum DMA alignment across all arm64 implementations.
>  CONFIG_RTE_CACHE_LINE_SIZE=128
>
> -CONFIG_RTE_EAL_IGB_UIO=n
> -
>  CONFIG_RTE_LIBRTE_FM10K_PMD=n
>  CONFIG_RTE_LIBRTE_SFC_EFX_PMD=n
>  CONFIG_RTE_LIBRTE_AVP_PMD=n
>
Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [dpdk-dev] [PATCH v2] armv8/config: enable igb_uio on arm64 platform
  2017-09-14 11:31   ` Hemant Agrawal
@ 2017-10-06 21:39     ` Thomas Monjalon
  0 siblings, 0 replies; 8+ messages in thread
From: Thomas Monjalon @ 2017-10-06 21:39 UTC (permalink / raw)
  To: Jianbo Liu; +Cc: dev, Hemant Agrawal, jerin.jacob

14/09/2017 13:31, Hemant Agrawal:
> On 9/14/2017 9:23 AM, Jianbo Liu wrote:
> > The kernel patch was merged to support pci resource mapping.
> > https://patchwork.kernel.org/patch/9677441/
> >
> > So enable igu_uio in the default arm64 configuration.
> >
> > v2:
> >   - keep headline format
> >
> > Signed-off-by: Jianbo Liu <jianbo.liu@linaro.org>
> Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>

Applied, thanks

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2017-10-06 21:39 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-14  3:00 [dpdk-dev] [PATCH] config: enable igb_uio on arm64 platform Jianbo Liu
2017-09-14  3:23 ` Jerin Jacob
2017-09-14  3:53 ` [dpdk-dev] [PATCH v2] armv8/config: " Jianbo Liu
2017-09-14  5:23   ` santosh
2017-09-14  9:41     ` Ferruh Yigit
2017-09-14 10:05       ` Jianbo Liu
2017-09-14 11:31   ` Hemant Agrawal
2017-10-06 21:39     ` Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).