From: Zhiyong Yang <zhiyong.yang@intel.com>
To: dev@dpdk.org
Cc: Wodkowski, PawelX <pawelx.wodkowski@intel.com>,
Kulasek, TomaszX <tomaszx.kulasek@intel.com>,
Declan Doherty <declan.doherty@intel.com>,
Zhiyong Yang <zhiyong.yang@intel.com>
Subject: [dpdk-dev] [PATCH] test: fix wrong assignment operation
Date: Fri, 15 Sep 2017 10:16:16 +0800 [thread overview]
Message-ID: <20170915021616.34428-1-zhiyong.yang@intel.com> (raw)
It should be an comparation operation rather than an assignment
operation.
Fixes: 5e41ab250dfa("app/test: unit tests for bonding mode 4")
cc: Wodkowski, PawelX <pawelx.wodkowski@intel.com>
cc: Kulasek, TomaszX <tomaszx.kulasek@intel.com>
cc: Declan Doherty <declan.doherty@intel.com>
Signed-off-by: Zhiyong Yang <zhiyong.yang@intel.com>
---
test/test/test_link_bonding_mode4.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/test/test/test_link_bonding_mode4.c b/test/test/test_link_bonding_mode4.c
index 8e9e23db5..e246f0148 100644
--- a/test/test/test_link_bonding_mode4.c
+++ b/test/test/test_link_bonding_mode4.c
@@ -661,7 +661,7 @@ bond_handshake(void)
TEST_ASSERT_EQUAL(all_slaves_done, 1, "Bond handshake failed\n");
/* If flags doesn't match - report failure */
- return all_slaves_done = 1 ? TEST_SUCCESS : TEST_FAILED;
+ return all_slaves_done == 1 ? TEST_SUCCESS : TEST_FAILED;
}
#define TEST_LACP_SLAVE_COUT RTE_DIM(test_params.slave_ports)
--
2.13.3
next reply other threads:[~2017-09-15 2:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-15 2:16 Zhiyong Yang [this message]
2017-09-15 2:42 ` Yang, Zhiyong
2017-09-15 2:35 Zhiyong Yang
2017-09-18 19:25 ` Ferruh Yigit
2017-09-18 19:27 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170915021616.34428-1-zhiyong.yang@intel.com \
--to=zhiyong.yang@intel.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=pawelx.wodkowski@intel.com \
--cc=tomaszx.kulasek@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).