From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <Shijith.Thotton@cavium.com> Received: from NAM03-BY2-obe.outbound.protection.outlook.com (mail-by2nam03hn0216.outbound.protection.outlook.com [104.47.42.216]) by dpdk.org (Postfix) with ESMTP id 0D98E1041; Fri, 15 Sep 2017 11:31:46 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=Zz2L9QC+vtjmVoCIJ0SxMqB3AYvDPpi2/lldC7D6Cy0=; b=B2MtJnZHgOCh/PLUe8OxcFwgwfi+7lpDlhfgwwVsOZqrNP9oe9TqWgZJIAmgZlqX8Q+YbH7RIdaiIZj4fv8hwBu5PPCHoZcsYm99KRdt6ZcmpdlhoSVFU+4aLE43jnEFuqEg7aUyqI89Om7tTM3VZ/nveFfoJbDZlvUUko76+tQ= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Shijith.Thotton@cavium.com; Received: from localhost.localdomain (14.140.2.178) by DM5PR07MB3066.namprd07.prod.outlook.com (10.172.88.140) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.56.11; Fri, 15 Sep 2017 09:31:36 +0000 Date: Fri, 15 Sep 2017 15:01:19 +0530 From: Shijith Thotton <shijith.thotton@caviumnetworks.com> To: "Yang, Qiming" <qiming.yang@intel.com> Cc: Thomas Monjalon <thomas@monjalon.net>, "dev@dpdk.org" <dev@dpdk.org>, "Tan, Jianfeng" <jianfeng.tan@intel.com>, "Thotton, Shijith" <Shijith.Thotton@cavium.com>, "Hu, Xuekun" <xuekun.hu@intel.com>, "Yigit, Ferruh" <ferruh.yigit@intel.com>, "Patil, Harish" <Harish.Patil@cavium.com>, Gregory Etelson <gregory@weka.io>, "stable@dpdk.org" <stable@dpdk.org> Message-ID: <20170915093118.GA6367@localhost.localdomain> References: <F5DF4F0E3AFEF648ADC1C3C33AD4DBF16F7E0E71@SHSMSX101.ccr.corp.intel.com> <D5DED7B9.160793%Harish.Patil@cavium.com> <F5DF4F0E3AFEF648ADC1C3C33AD4DBF16F7EA3EB@SHSMSX151.ccr.corp.intel.com> <1836615.UbEDzhAzGh@xps> <F5DF4F0E3AFEF648ADC1C3C33AD4DBF16F7EA492@SHSMSX151.ccr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <F5DF4F0E3AFEF648ADC1C3C33AD4DBF16F7EA492@SHSMSX151.ccr.corp.intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Originating-IP: [14.140.2.178] X-ClientProxiedBy: PN1PR01CA0101.INDPRD01.PROD.OUTLOOK.COM (10.174.144.17) To DM5PR07MB3066.namprd07.prod.outlook.com (10.172.88.140) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e6d965c5-dd3e-41c4-ea65-08d4fc1c93ed X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:DM5PR07MB3066; X-Microsoft-Exchange-Diagnostics: 1; DM5PR07MB3066; 3:4iDbrBxiTXaznuxJgS8NIIIOK7kYv3Q4qVtW7v4RzasVxfFrZTdVnKKHO1lg8Jh5csSxkB6LfvY3pWz45KdM05YP2JRCgdw1/3YYlmqQsrh3NYZCiMqWyAk/kS2tKlFYyHzfWtujjooiWdRGw5nH+X1iqmIlGHXEF7LUm+NVH5YUa4NYuNSCgRX/Nt8ZKGZHzLNsL6qwUNs+GyQ6oR4wHTebljFA3rmn575AnlHfmeeELk+PRfOOnVhaTyyFKdXp; 25:RA1SJTGoO6bv0Vx5KLsSnS51nJtxV8/QBCWwH/l8lmpGHCnd3H2isy8fBAAi0eqdDbTKqV+Gd2jhY8icOKnoNah8a0peCxLf2lmSSAzO5UVn7+M0ZJdkzXGgZ3nCsqRqeDgrYfdyxyp02qkBceun4rsSZimHtOOSTcc+pTf8f+688BinP967qz2aourMmWeXDmz6KgEMGu7rZhwY1FJdStin+MKMxzuOv4l5h3bOlnwkvv11WQ3IWiC1rAkuMfQwkg92ay+JG7N7Q6h0B5zMJd3/SauTRxgP3gGZS1l5F97VHegwzQuaoB8rZgITc6Pk9u9x3pGBV4+FfAvdLsQAXQ==; 31:gCT236On2lg40MoRDKn0ReB3lbq19fVe7RnbYOe2kcbvE9L5gqrUqpf5n1siNoyE4JPFSxd4OsKno0SuwuySz9y9ievGWrk16SAohX5ZK2zq31eazGHkC8Mk2u3Ghdv1g8Sh5/90g3Bx86pPQgLnVc7eVFgRoc1Hc9xSTx0k42Ujb555z39oZsdd7+Y5XHTL4y8bprpmTOasYuhihElEvdVsKdmi6PbsaKLQrh/SxO4= X-MS-TrafficTypeDiagnostic: DM5PR07MB3066: X-Microsoft-Exchange-Diagnostics: 1; DM5PR07MB3066; 20:XEvXQFhjKP57BdiEGask4pADADJM4nRBXI9KrUCROFDSB4AmUHbYUMq2sb5ZLlsA7I3uSD46Z16qOaba/lzLbMa9+fEffETL7ki+A1efUrQvmFf4S7IP0EdBoyiAqi+fHdJZidUmcNhPHUxCurgmVYxLph+7/W5nWV5tF8dW2QTRlV8UFwBja1wmthRW0DgSCR6XQOwiE63sq/4+iGwsgMRbccIbNZvbmPnKB/rYWCVR3R7eQgO/7O18X8XEvQExM0YGyjugBo0GA9VOLgdIHB7U9WRTS9P7NAkWJd5DstlLHAxDGs5BmWwdMZWLz1O+KOC8uF6J3ysnOVgU4KWFrkoWkPMk2afqXkpBpywWIb/ODKwTicHiGH1LiyrCEY6kWBf0Qufs6Prj+YxNFWnolQ2zLLLGF2fmM+DJTa+X3ykfIMrf5fzljZ0YE2ko7z0MPcPuvs9j367dcEjMKWdY/SO3geG7ga3U9N+DbVVv3JUdCO8xCsya18ZPuRuXvzETv69/M6PuGy6AJfZ+07vtNrmdnr2e1CmnDSw+MYxey33WiSYwQ6QqsgrxZegSYI8fLqPGG725YNInxYPbC5sd2fQT+/Cov0+eOOdnpheyJfo=; 4:PBmAiDv77pnmyZ9+HvNqblt1oJCO8uH0AbEm+U7bM8UsEVnnD9YXIc2owpxD7pEktDD6/fQASyEzd01Di26JSJO+AfZCtgdwgbGLHpzxkCGwSiTPtwTFEeza5t07oKYz54nBc4bIiluH0vhABWunWb+B2DoDUhV5GVSnIeaOqKDPRETSxYfGEUwrm2IAMyrixP4yTnNt+y4agoF9CEPwY1S/ynnVm19g0crZLlgMuiKcSncvq+QaT2dX3ZM8dhPPUiCTKQsAATQOJ7pQQBYpKwi1sd12SY0+Dty43jIeZpg= X-Exchange-Antispam-Report-Test: UriScan:(228905959029699); X-Microsoft-Antispam-PRVS: <DM5PR07MB3066A1AA23BF93C5795E8D86816C0@DM5PR07MB3066.namprd07.prod.outlook.com> X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(100000703101)(100105400095)(93006095)(3002001)(10201501046)(6041248)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(20161123562025)(20161123555025)(20161123564025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:DM5PR07MB3066; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:DM5PR07MB3066; X-Forefront-PRVS: 0431F981D8 X-Forefront-Antispam-Report: SFV:SPM; SFS:(10009020)(6069001)(6009001)(346002)(376002)(199003)(24454002)(13464003)(189002)(377454003)(2950100002)(189998001)(23726003)(50986999)(76176999)(54356999)(6116002)(3846002)(53376002)(1076002)(53936002)(50466002)(6246003)(4326008)(55016002)(97736004)(101416001)(5009440100003)(110136004)(72206003)(33656002)(54906002)(5660300001)(6306002)(9686003)(68736007)(81156014)(7736002)(81166006)(2906002)(8676002)(229853002)(105586002)(16586007)(83506001)(93886005)(966005)(316002)(305945005)(6506006)(25786009)(16526017)(61506002)(53546010)(66066001)(8936002)(47776003)(478600001)(58126008)(42882006)(6666003)(106356001)(6916009)(533714002)(110426004); DIR:OUT; SFP:1501; SCL:5; SRVR:DM5PR07MB3066; H:localhost.localdomain; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DM5PR07MB3066; 23:oWpzQwXIiwS5l9viR8aBVuqokGHx39ASaSWn/Oi/Y?= =?us-ascii?Q?rzYZUydsazc2LUeqQrnk4pZdWCLMmAEAIEKodHuWsY+vN1wtbsUtYZKpFVO/?= =?us-ascii?Q?hrf2DVMBi3HDKKPDiV2klufS8Jm7+eVqwm6noW+0Pjkr4dAQkisF0z43H525?= =?us-ascii?Q?3R8KMcgDhsBAqhWufQTu3arOhWqA5oW2E//jQ5jZj0Fvvxx8/HXPyyz+ndoc?= =?us-ascii?Q?WIMKZIEApRHNO8WimoVV+sQniC25Req8GlRvlo0f2wMkdGvyemr25/Jr3iOY?= =?us-ascii?Q?MsHy0xHhkv6U0HqtmpKMiaN++BmsATOQo1YPR1LtcO3c2ZQYcKhg1VCC8M/i?= =?us-ascii?Q?OUmFTaXA4TapRLX/L51PnG2IgQgQ9Gnh/Vyvv/7oXe6QSHNlmwbR1XEwFkKR?= =?us-ascii?Q?sInrS+FetNkWR2RgPTFrWhrKsth1zIBRjA8E5BAyBcyQ8cLFmLVOIYWqIbCC?= =?us-ascii?Q?an7SYRyfb7ToFd+quzL5vs1yGoMj9Z4mTG4Nf1Nik4ywfC3HYyrwDoxctItY?= =?us-ascii?Q?yDUk7HCjvIl89UujyvH4rb+/PS16H3JXjFlN/HjeTx4o6OnIKS8TBqSJaBPU?= =?us-ascii?Q?36vajUe/5VZOTNY1rc8t3PJI7PaoOyEt8g/o/3s6hiBsPfHw44gZxzHV7ySR?= =?us-ascii?Q?jifLSoXeK/w0eausnPFWTxKBFbf5PdslRKnG/YfkCQ+k3pF2SbPDAAwipcy5?= =?us-ascii?Q?DSepFJTcOfu8TlNugeqY2FlF7o5PXibbrVbiU+WE/X7HopG0Hj/GYWGCv+2B?= =?us-ascii?Q?5CLDOUoNuQ3Bmd+Kif4xmxYzZFGCKNMaqit5REdst8jBAnCDOegYWPlzKDYv?= =?us-ascii?Q?sue6Nzrvzgdv+g0krndr5ChwsPSHQ07rfyjMnhLmVdKIUkqmY5RD2c62xIf8?= =?us-ascii?Q?PO7bPnuJNtZLx7OQUYeqVtkR2pDkrqfd/2cUE1CJuTXO4cAS8u5RPxTAcjB0?= =?us-ascii?Q?BoogkZ1VSqpAx1prkZv11ti+7uAkQH19m8YXT4hXMdnLR9UfA7pSXVQwT3pZ?= =?us-ascii?Q?ph2NAHlk8bEr0DIomKjZ2myfCwCDCK15/0Q6XPV1u/94YJVVIc82u/sdhF9k?= =?us-ascii?Q?FoksiDlH/tNkPNGRep490VYiz6J/U7EkfAy00vb1rsedPz2PuoU2HJHYGIPw?= =?us-ascii?Q?lysYkLR35dNBABBQavtm634Ur8L13l18NM9FPeptjeCrlg3q4NVZx9mwSyx8?= =?us-ascii?Q?n6IWswPP+WDtNc37Z4pTXSv3bfCqOiTU4Fr6eSBldUDQxDLSjK5IuVgqg8Kd?= =?us-ascii?Q?8vPcVf8fNIw2HkGMGvIC57R1xm1JLIW9mrojJtW1LhLxq8UOyJkUCGY+2ijM?= =?us-ascii?Q?8JK/avgs4QYBQ0aHgPM7vcM0vFie1rnzzSghpYTefSAxHoj5qygap238RdHi?= =?us-ascii?Q?G5IqD+B0E/uL7zgiMViU9EtmDrpfqZ6hIobm3JWHB9hPRRQhJPwbiTjRNh4E?= =?us-ascii?Q?9eSVrJadI1mKHsGMdQbicsd0ISSu/y9+grCPxdfaQ81spqyLeaJ2Nr9eN+HF?= =?us-ascii?Q?niQp1pBEqeSjd3ksT3Z5rKDvbDwVdb/bZU=3D?= X-Microsoft-Exchange-Diagnostics: 1; DM5PR07MB3066; 6:3OoYarVErNcigPuaOkcaV3XjB08izqH1JwZdRUC+YALOI7nC4GfbBCwndMTG9PDf9JKnO97FlCiCqg4w9nZ7HVBr71cpkZ1Aj3lceRgxdN3T51YbpIsvz/2hzPWcDPjihAq8JxmtUfyzhcOb3hJyJfYZa7sHlj6Y0CCsxfflUisViIqWZCn3Lw+AgBLWCv++jJBcyyE5t/UUoVnDaClb7V6DQtSmXdTD8zAscjx5lfgC7XrUfQISwig4f+3qCiS29Tafg2SXipWRf25NlWcC8T7ln4FEjzM8bX/SeI0+WJxXv9nf1r0hJYpr55g1eJXqhAPsuWV8+3iTRKN9h9qtrw==; 5:bWiTXmqUWEE+w8aChM/CFgTEm/HbhZw4rfVi+4n7MGFkOxU1aVcgCthm2bNtAsExbShJmk7DwJwT4qk9dHQ2wvA+Gc9tf3Sf3WNMT+bxSXheVkwp0cA1QRajgmhQq/OF3+voZN9dcGZf68lvoC6ZDQ==; 24:/SoMON9oJ5dPlJN/u7GLLhtqx2EbhBmwNSp6cqWAWDWEM0foFITz4S9BeUlNvTJiGOOobC0y15P1EuhjtsmILA==; 7:rULtt57YrTJuDXvo4MOEt2GkN4/zl4ettGd1EMPPjz1Lv1/fT2V+doZTOejokB30JWU5KqUyLv3mhq/kEJU1FNkvGpRmLfSNWIyD1pQVpDYDJWBooeQ+vJ/fskwiLTjb3M3v3gy+qwx9d7kLnHNdjY9/92XmNrIDoeuxtZFHYD4Cp7ahevS121gWR8G7PNz1+eEMFZc22aprnsoZF3qhV+RUpsilqEI3qmWfcU2QdKI= SpamDiagnosticOutput: 1:22 X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Sep 2017 09:31:36.0177 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR07MB3066 Subject: Re: [dpdk-dev] vf init issue with patch igb_uio: issue FLR during open and release of device file X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Fri, 15 Sep 2017 09:31:46 -0000 On Fri, Sep 15, 2017 at 09:18:00AM +0000, Yang, Qiming wrote: > > -----Original Message----- > > From: Thomas Monjalon [mailto:thomas@monjalon.net] > > Sent: Friday, September 15, 2017 4:43 PM > > To: Yang, Qiming <qiming.yang@intel.com> > > Cc: dev@dpdk.org; Tan, Jianfeng <jianfeng.tan@intel.com>; Thotton, Shijith > > <Shijith.Thotton@cavium.com>; Hu, Xuekun <xuekun.hu@intel.com>; Yigit, > > Ferruh <ferruh.yigit@intel.com>; Patil, Harish <Harish.Patil@cavium.com>; > > Gregory Etelson <gregory@weka.io>; stable@dpdk.org > > Subject: Re: [dpdk-dev] vf init issue with patch igb_uio: issue FLR during open > > and release of device file > > > > Hi > > > > 15/09/2017 10:04, Yang, Qiming: > > > Hi, Thomas > > > We meet a urgent issue because of Shijith's patch. > > > When use DPDK version 17.08, DPDK VF driver and kernel PF driver, i40e, ixgbe > > and qede(Harish said) VF all meet initial failure. > > > > This patch has been integrated in DPDK 17.08-rc2 (2 months ago). > > Why a so obvious issue is discovered only now? > > > > > This issue only occurred when use 17.08 igb_uio, vfio-pci and 17.05 igb_uio all > > works well. > > > Considering this issue will block our vf driver develop and test work, could we > > revert this patch first and find another appropriate way? > > > > We need to be sure the revert is the right solution because it will be backported > > to the stable 17.08 release. > > > > Shijith suggests to "try removing pci_reset_function from igbuio_pci_open." > > Can we try this first? > > Are we sure the bug is not in new firmwares? > > I have tried to remove pci_reset_function, it works in my environment, but it doesn't work in someone's enviroment. > And removing this function won't it changes the original purpose of his patch? So I'm not sure it is a good solution. > This bug is not a firmware version related issue, we can reproduce stably with older firmware. > There is a reset during release which was suggested as a fix by Gregory for an issue he faced with i40e VF[1]. Removing it can cause problems for him. 1. http://dpdk.org/ml/archives/dev/2017-May/066317.html