* [dpdk-dev] [PATCH v2] net/liquidio: fix uninitialized variable
@ 2017-09-15 11:48 Yong Wang
2017-09-18 6:27 ` Shijith Thotton
2017-09-19 6:45 ` Shijith Thotton
0 siblings, 2 replies; 4+ messages in thread
From: Yong Wang @ 2017-09-15 11:48 UTC (permalink / raw)
To: shijith.thotton; +Cc: dev, Yong Wang
In func lio_dev_link_update(), "link.link_autoneg" is used in func call
lio_dev_atomic_write_link_status(), but is uninitialized.
v2:
* Modify the initial value of 'link.link_autoneg' from 'ETH_LINK_FIXED'
to 'ETH_LINK_AUTONEG'.
Signed-off-by: Yong Wang <wang.yong19@zte.com.cn>
---
drivers/net/liquidio/lio_ethdev.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/liquidio/lio_ethdev.c b/drivers/net/liquidio/lio_ethdev.c
index 479936a..30119d2 100644
--- a/drivers/net/liquidio/lio_ethdev.c
+++ b/drivers/net/liquidio/lio_ethdev.c
@@ -939,6 +939,7 @@ struct rte_lio_xstats_name_off {
link.link_status = ETH_LINK_DOWN;
link.link_speed = ETH_SPEED_NUM_NONE;
link.link_duplex = ETH_LINK_HALF_DUPLEX;
+ link.link_autoneg = ETH_LINK_AUTONEG;
memset(&old, 0, sizeof(old));
/* Return what we found */
--
1.8.3.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH v2] net/liquidio: fix uninitialized variable
2017-09-15 11:48 [dpdk-dev] [PATCH v2] net/liquidio: fix uninitialized variable Yong Wang
@ 2017-09-18 6:27 ` Shijith Thotton
2017-09-19 6:45 ` Shijith Thotton
1 sibling, 0 replies; 4+ messages in thread
From: Shijith Thotton @ 2017-09-18 6:27 UTC (permalink / raw)
To: Yong Wang; +Cc: shijith.thotton, dev
On Fri, Sep 15, 2017 at 07:48:28AM -0400, Yong Wang wrote:
> In func lio_dev_link_update(), "link.link_autoneg" is used in func call
> lio_dev_atomic_write_link_status(), but is uninitialized.
>
> v2:
> * Modify the initial value of 'link.link_autoneg' from 'ETH_LINK_FIXED'
> to 'ETH_LINK_AUTONEG'.
Please remove change log from commit message[1] and use --in-reply-to option
while sending new versions of a patch.
1. http://dpdk.org/ml/archives/dev/2017-September/075426.html
>
> Signed-off-by: Yong Wang <wang.yong19@zte.com.cn>
> ---
You can move change log here.
> drivers/net/liquidio/lio_ethdev.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/liquidio/lio_ethdev.c b/drivers/net/liquidio/lio_ethdev.c
> index 479936a..30119d2 100644
> --- a/drivers/net/liquidio/lio_ethdev.c
> +++ b/drivers/net/liquidio/lio_ethdev.c
> @@ -939,6 +939,7 @@ struct rte_lio_xstats_name_off {
> link.link_status = ETH_LINK_DOWN;
> link.link_speed = ETH_SPEED_NUM_NONE;
> link.link_duplex = ETH_LINK_HALF_DUPLEX;
> + link.link_autoneg = ETH_LINK_AUTONEG;
> memset(&old, 0, sizeof(old));
>
> /* Return what we found */
> --
> 1.8.3.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH v2] net/liquidio: fix uninitialized variable
2017-09-15 11:48 [dpdk-dev] [PATCH v2] net/liquidio: fix uninitialized variable Yong Wang
2017-09-18 6:27 ` Shijith Thotton
@ 2017-09-19 6:45 ` Shijith Thotton
2017-09-19 7:27 ` Ferruh Yigit
1 sibling, 1 reply; 4+ messages in thread
From: Shijith Thotton @ 2017-09-19 6:45 UTC (permalink / raw)
To: Yong Wang; +Cc: shijith.thotton, dev
On Fri, Sep 15, 2017 at 07:48:28AM -0400, Yong Wang wrote:
> In func lio_dev_link_update(), "link.link_autoneg" is used in func call
> lio_dev_atomic_write_link_status(), but is uninitialized.
>
> v2:
> * Modify the initial value of 'link.link_autoneg' from 'ETH_LINK_FIXED'
> to 'ETH_LINK_AUTONEG'.
>
> Signed-off-by: Yong Wang <wang.yong19@zte.com.cn>
Acked-by: Shijith Thotton <shijith.thotton@caviumnetworks.com>
> ---
> drivers/net/liquidio/lio_ethdev.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/liquidio/lio_ethdev.c b/drivers/net/liquidio/lio_ethdev.c
> index 479936a..30119d2 100644
> --- a/drivers/net/liquidio/lio_ethdev.c
> +++ b/drivers/net/liquidio/lio_ethdev.c
> @@ -939,6 +939,7 @@ struct rte_lio_xstats_name_off {
> link.link_status = ETH_LINK_DOWN;
> link.link_speed = ETH_SPEED_NUM_NONE;
> link.link_duplex = ETH_LINK_HALF_DUPLEX;
> + link.link_autoneg = ETH_LINK_AUTONEG;
> memset(&old, 0, sizeof(old));
>
> /* Return what we found */
> --
> 1.8.3.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH v2] net/liquidio: fix uninitialized variable
2017-09-19 6:45 ` Shijith Thotton
@ 2017-09-19 7:27 ` Ferruh Yigit
0 siblings, 0 replies; 4+ messages in thread
From: Ferruh Yigit @ 2017-09-19 7:27 UTC (permalink / raw)
To: Shijith Thotton, Yong Wang; +Cc: shijith.thotton, dev
On 9/19/2017 7:45 AM, Shijith Thotton wrote:
> On Fri, Sep 15, 2017 at 07:48:28AM -0400, Yong Wang wrote:
>> In func lio_dev_link_update(), "link.link_autoneg" is used in func call
>> lio_dev_atomic_write_link_status(), but is uninitialized.
>>
>> v2:
>> * Modify the initial value of 'link.link_autoneg' from 'ETH_LINK_FIXED'
>> to 'ETH_LINK_AUTONEG'.
>>
>> Signed-off-by: Yong Wang <wang.yong19@zte.com.cn>
>
> Acked-by: Shijith Thotton <shijith.thotton@caviumnetworks.com>
Applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-09-19 7:28 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-15 11:48 [dpdk-dev] [PATCH v2] net/liquidio: fix uninitialized variable Yong Wang
2017-09-18 6:27 ` Shijith Thotton
2017-09-19 6:45 ` Shijith Thotton
2017-09-19 7:27 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).