From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-BL2-obe.outbound.protection.outlook.com (mail-bl2nam02on0071.outbound.protection.outlook.com [104.47.38.71]) by dpdk.org (Postfix) with ESMTP id 800F1DE3 for ; Mon, 18 Sep 2017 08:27:42 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=Qy1k8nC2TMNA9ibvkQV5emsM/BYvQsUdOBlvcgRJUNg=; b=Uwc8yzNf28eUV/5iZ4p0R+1OoFaRG0TwRRVJOGcNbSp+zznHxupy1nC7Sce4hZ1RL3m2wu4mUYakUz8wGI9glJUs0UZxE0uea9OGzgNTKGDqE7gN/FQVdVvw6P8GFzLt07sWXlNAN5vUSc5L8Og3dHD69wxDdu5GESI5JASaGo0= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Shijith.Thotton@cavium.com; Received: from localhost.localdomain (14.140.2.178) by DM5PR07MB3066.namprd07.prod.outlook.com (10.172.88.140) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.56.11; Mon, 18 Sep 2017 06:27:38 +0000 Date: Mon, 18 Sep 2017 11:57:22 +0530 From: Shijith Thotton To: Yong Wang Cc: shijith.thotton@cavium.com, dev@dpdk.org Message-ID: <20170918062721.GA6037@localhost.localdomain> References: <1505476108-11005-1-git-send-email-wang.yong19@zte.com.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1505476108-11005-1-git-send-email-wang.yong19@zte.com.cn> User-Agent: Mutt/1.5.21 (2010-09-15) X-Originating-IP: [14.140.2.178] X-ClientProxiedBy: PN1PR01CA0085.INDPRD01.PROD.OUTLOOK.COM (10.174.144.153) To DM5PR07MB3066.namprd07.prod.outlook.com (10.172.88.140) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 47796aad-db5c-40cf-c8e5-08d4fe5e5cb9 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:DM5PR07MB3066; X-Microsoft-Exchange-Diagnostics: 1; DM5PR07MB3066; 3:xiOL5fBi0yI93OKhnm52GEW7BiTY2pB/0I69C2hH0lVziWQf5LWAnfGEfIGWuBkOfhtAgCtK3SZp/QLhHB/te2stWu5RrMrrIIJx+uUfZ4aFhWdyjQc8zZAbLrxY6UgelbhqUASDYlN2MzgfUR/a9yz6ThRlo9x5LL60jfOC2exoj+/p8JJ7US95t8T4fzyov+myoY6TAJeAunWE1YaUDejS/qmtynFA59cipwmcBmlneg8zeqc6ggB7YzospXu/; 25:BqUlUCNxvdB9mEHAwiJBeVUlN9n/98/WVjF5hSzFoTygmSJMFl/jnZBlVEGEkqnHZOoyVLxvV0Uq1EOia0wFYZAh6U45ieRxb4h4YYBcKplfArHhnZibZouyyqd51YfxemW0Tdputi0W3Jbtpi4sbnlkI/wYiz28CdvnNLFD5jX0zz5CtTIaOLlEQeejwRyi9Q4/b18mkQhnqYptYUiq86g/Ij4LP5gUoguwY/IvtjakNKM8kdul3J6Kvh/mbjqLWxhEMfUMRBRrKDZgMUwhTdGcX6x6ahLKxBrbpPDU9KIl4ONk1skgYauup70VhbBQrb0f68muiuBK/+OozpoRSA==; 31:1zCxofw8CvCTH+mF3hNjZ4lSv5B6N4sZbOTJUsmfM4j8eZiBxop1tjQFJu1LuYlasRbl2lsjPZ+Az/UPcf9sYTjgDxxVIXgBFxtEEPkIZpvjEyRAuRmMMYQ6UdPhl3zOtA5pk4DNEqjhixmN5vRUCEa522OswbPbsc/y41nd2QvPrHWL4OUo2xexcgtDE6P9yguKJw0gIFmHLFzNcswdGpnLjQpZ4QG6ZkbITK5Fvvo= X-MS-TrafficTypeDiagnostic: DM5PR07MB3066: X-Microsoft-Exchange-Diagnostics: 1; DM5PR07MB3066; 20:j5FtS/IkzaTVfb/W/GYD2kmZpZ79w0MX7pmeP1hPrZXDyC18U+7LaJH1Y4oa5YNLGjAAG+vMGExUww/l6mso/TlrUdjEBhQTyD9phg9VS64EbcA/hkwJlK6NpXewDl8xfgTmSdemheVCPQRgkJz9DrF+yumqeflKWZcJhX72p0DBcYStXMXbnKY+Vjg9qXYj1E+1488uKayMYv1kqLwCa/9Q0cBKDj3zQXtXNfv9VwMoFBhv7jOHgl9G/o7TH+2CCXiEyC+zmZVltoUVGS9e0Fhja6nw05PvD2E0OsI8Pc5qlrFPSmEYKs6QSksDrPrTe+Fazldm7V9VHAyF3cBz4pV/6Du5WrtYua3lDYK7evfeXDp+Jxp7MUExp83cy82FsUTEO6zLnkHZxBOBYb1uXixQvJw41WDyigmrsRW8OXlHRcI7Bv2gRejzL+gJ+PJeG0ch6qsER3GDcGGIYrsTChN/f7/WWIAL34OzjrYuS9rAEEZD6wsQnINBsVmnD58B5RbZ+7xKujtuDIoKdNYziYlp3pWNzqYiid/1v+4/Kx/NTNU8lMRjLF0zmHD8Gu3PIBJOXWNwd6wwhyrLkwkwYwAqQ7KkOOJN7nZezNrXH58=; 4:szESfd4u3D3aRlXtaeMcBsm2jk5fBFOyURQE16dqwE9LsdJ9XYUIiP36ff16Dw1aVjHKsH+HAJgjMBcdJHmRisMBhNm5gW3nVE94NDzE9ViipAXXUuluS/gwztX845fAbzpQWDEAL3M7vykiT+S2i1RXagw+z1Oc0f9zTryUc8sGGqI/tldXGmZwAWmZNZbiq/N0dMl6uKlLq7Bei2GQkvE5/6Dtqh908Lsud9oYD7d6fM8ZEJF8rmRiu7LbFVZW X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(3002001)(93006095)(100000703101)(100105400095)(10201501046)(6041248)(20161123558100)(20161123555025)(20161123564025)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:DM5PR07MB3066; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:DM5PR07MB3066; X-Forefront-PRVS: 04347F8039 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6069001)(6009001)(346002)(376002)(199003)(24454002)(189002)(54534003)(76176999)(61506002)(6506006)(229853002)(50466002)(25786009)(110136004)(6246003)(53376002)(53936002)(4326008)(101416001)(33656002)(97736004)(9686003)(16586007)(106356001)(105586002)(47776003)(6306002)(305945005)(189998001)(5660300001)(478600001)(6916009)(2950100002)(42882006)(6666003)(66066001)(55016002)(2906002)(7736002)(58126008)(68736007)(81156014)(50986999)(81166006)(54356999)(316002)(966005)(3846002)(5009440100003)(16526017)(8936002)(83506001)(6116002)(8676002)(1076002)(72206003)(23726003)(110426004)(18370500001); DIR:OUT; SFP:1101; SCL:1; SRVR:DM5PR07MB3066; H:localhost.localdomain; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DM5PR07MB3066; 23:wIetgXUBBvizZMj4qtcdleESaFJYvoECAifITVwDm?= =?us-ascii?Q?RnyOVWUzCXLUm16fau4GVN7m+Lsb/f42ptN1Z1vdiJJgCLKi3oi0FjnawEZY?= =?us-ascii?Q?YtHX7zxJIt1YlFzRuxkk+QFoejY3GhzvfjWkiVV+F7SYILmtrjjpvIObFhWD?= =?us-ascii?Q?Rhu7+n6XWlWN6dG3GGQ6BFQNTyhCCMunz0Rn5HsH1OSeyDcu1VQJ8mycriJh?= =?us-ascii?Q?VZ+nyzax2Q7jN+gm+qPxoK91QZTC21OPIkPjL9I+YL6PJRbDd8IowL3Pzjfw?= =?us-ascii?Q?0KfkD2ryVWv8LatB8kvUIQoOsWd8+Zfv6D44ulaM2SK0241jxEnRfRLQpnO9?= =?us-ascii?Q?rxqjotHZfEWFOjsPSa2ssDtSwqNQwVyPcE1Nnv4uU0zdTnB2Oe3XGtgjzIDa?= =?us-ascii?Q?jQaAe03bhatYMcjJBMxpmWLIrIqxQCvh6OWXI4ER5iz0lT+RmuvgFHcjwVv9?= =?us-ascii?Q?Sd/FE6vP59CMWRLxu2i0c1J4LlIWaAF5jIlhrq2Ftw2oAOLBNlverDgasFkC?= =?us-ascii?Q?4OQ751H3nv/A+GMeyjKrj/u2KOhPv1PUgeWsxngNSbYRR0R9yI5/bVrjT1Jk?= =?us-ascii?Q?wPhUXBnq4wiBnasTebxykFWHl3jqwbECjX6jyfoQJSLZShGYfIa04NGMatyf?= =?us-ascii?Q?6DnQ3qCQ0XWwuruMrMcgKCWTJrhukOuhRVv8QOoZ1Iw6ZzQovKvWtj9SL9OB?= =?us-ascii?Q?NLncZsG5zSvSb3DjS2QFJIFr+nj0RhvpVdj1uzI3eFAtCIis8ai+929sqdNe?= =?us-ascii?Q?FvY6031YzFIBLqWoqBBpvLPZa2ZYuau/qwakVanZK/vqaMixt9xfNMFGUBsd?= =?us-ascii?Q?O3UVj9WXWbV4jFXXCdKvsh/ZDom2+UgPZ2mrhnpAIf5arkNaVqO8Ju7PdQRT?= =?us-ascii?Q?PxWavdX+utDz4lHJo5d0SccAfvimmcuxUMfLwvM/nHpHACfDWAa1mTUFY1Hs?= =?us-ascii?Q?6O1aHcOfQv7fRB+H8zrdWlpBuEwcipVKbLZ4jiHt7J+bRGZBZvoqoOp+6Wx8?= =?us-ascii?Q?ItVsOpqo4Yzmp8AQFmWHYUd9mFLx2WXeXZcwdpCWTV6JbNYg+43QSmZvtwnq?= =?us-ascii?Q?F2ge5px0zV+uYaXHZZsOzbLh6cUzxpEDT2gbxy1bBIH9l1nchU3rFcSfz0qV?= =?us-ascii?Q?BVCYyYT4KHjjlEIHVPxlz7uQcOZzQw2+Lk0Iq40TzBDj7guy3Aqv0gIDMH8q?= =?us-ascii?Q?v+a8owGDqOB99gkteDvPzRFjI/BDfGk9F8STQk4KBw+Nb/Cb69loA3Ljf80z?= =?us-ascii?Q?weB1Y9WcRU7BG439zQ2i9ATcETkxkMJ5KTN2V6y4Af1cTrXvtLoElWYNnJyK?= =?us-ascii?Q?vs5RbgrYXkh1FSmwGSbDylbTBSNXoauyrnnbhSuTdQaHhGCu2XG8eY0gxj+m?= =?us-ascii?Q?Tp87swTu5p7juHpIssXQxO1drE=3D?= X-Microsoft-Exchange-Diagnostics: 1; DM5PR07MB3066; 6:VwY3zXsAOY66f8iUOxoLLaohgsgLEFt7ZjWSLMH/a6hAdrXWIM4rrtQw8UC+Z7tjd84o+Rs3qgNQRIXqSqeHP/h3EJgXLjyJoAxCTXhgTjNpxS4zStpkb1XnQW9wQJhFdNhe9COYyWyvzQ7PbdmUbGdgz77OiPtMH6ft8kn5fKal+rcw8JiCo5njDf6quQikGOcgn9Igb8bpr348L/Mscagwo3jX7wYlXWv2obRTRMpUNXy0kpJJ68tDOSNWxuh/kX5r85wxeIEgrtTiWko6OEBW2mYMc7FerNIQ2PKwOxXngQwvpauVcCOPqMsoZ9/3tEZXhTGuaH77sIGo9oZfPA==; 5:p+UcLp4TXFNU+0mWktHjBpeDUn84PrPY6o7qTeJIyvJB8XNOWF6Vz1QFBbfvh+hk6WtK1zTa9hCN/zqvbuPC2eP8LOfzOa7ikcsKLryl6RM81/mDUD9yvelxFYnmAtCVBljjgJSgYZNuSkNhFrSn5g==; 24:Ieyr7ZBsazDlQC2k96AA3+WXQojlZPQq9nIbajcNoXGcSqSZ60eG19a3h3gE9Exnz6tyh2zEB/seeLppbLEttAqoYhMG8wtr717QwHGtMF4=; 7:/JW77SnAT3RE/mV8wJDfLi4EZqlLmrw3exhWGxxUvEup3lnDzu4cv33Icd9HxrfiabkZuknSSVFSeXz9hJ/1gOzafiULSOJgYnUQ+pO/vfBy+BuDyOKXOw7nmqUkFBF+ecJZW7DV8nskMMQgXpDx2BYdLWcn4VhVOSXq0z/YqTVI/pnvCWTjxVHlpqLHcimgPqt+iPQSNy/PuihHcIWGeeTTxdnsaMsYxYT1DpwjKXs= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Sep 2017 06:27:38.8236 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR07MB3066 Subject: Re: [dpdk-dev] [PATCH v2] net/liquidio: fix uninitialized variable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Sep 2017 06:27:42 -0000 On Fri, Sep 15, 2017 at 07:48:28AM -0400, Yong Wang wrote: > In func lio_dev_link_update(), "link.link_autoneg" is used in func call > lio_dev_atomic_write_link_status(), but is uninitialized. > > v2: > * Modify the initial value of 'link.link_autoneg' from 'ETH_LINK_FIXED' > to 'ETH_LINK_AUTONEG'. Please remove change log from commit message[1] and use --in-reply-to option while sending new versions of a patch. 1. http://dpdk.org/ml/archives/dev/2017-September/075426.html > > Signed-off-by: Yong Wang > --- You can move change log here. > drivers/net/liquidio/lio_ethdev.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/liquidio/lio_ethdev.c b/drivers/net/liquidio/lio_ethdev.c > index 479936a..30119d2 100644 > --- a/drivers/net/liquidio/lio_ethdev.c > +++ b/drivers/net/liquidio/lio_ethdev.c > @@ -939,6 +939,7 @@ struct rte_lio_xstats_name_off { > link.link_status = ETH_LINK_DOWN; > link.link_speed = ETH_SPEED_NUM_NONE; > link.link_duplex = ETH_LINK_HALF_DUPLEX; > + link.link_autoneg = ETH_LINK_AUTONEG; > memset(&old, 0, sizeof(old)); > > /* Return what we found */ > -- > 1.8.3.1 >