From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on0040.outbound.protection.outlook.com [104.47.36.40]) by dpdk.org (Postfix) with ESMTP id DEECBF04 for ; Mon, 18 Sep 2017 08:50:16 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=f5C1yxrDIeeD8KoVVSOMA67b+wZt+UXVsmaWi7PULps=; b=M05d7SIOGblzLQ6n+Pdj36VKoPi269/g3qfNgsqLixQF8KeF+h0d/6ataGT6/TsY1AeQhNla7GIKYN905X79QHB4EPilMyQs34LzfuH5a8xFt7pooFmNdNotfNQsz2g4l74j0KdvrykXZ2ekjj4ELNzQqU8uhS0YjWH/TzRWwdc= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Shijith.Thotton@cavium.com; Received: from localhost.localdomain (14.140.2.178) by BN6PR07MB3058.namprd07.prod.outlook.com (10.172.106.140) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.56.11; Mon, 18 Sep 2017 06:50:12 +0000 Date: Mon, 18 Sep 2017 12:19:58 +0530 From: Shijith Thotton To: "Yang, Qiming" , "Patil, Harish" Cc: "Zhang, Helin" , Gregory Etelson , "thomas@monjalon.net" , "dev@dpdk.org" , "Tan, Jianfeng" , "Thotton, Shijith" , "Hu, Xuekun" , "Yigit, Ferruh" , "Li, Xiaoyun" Message-ID: <20170918064957.GB6037@localhost.localdomain> References: <2430472.fsKqsvm3Ry@polaris> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-Originating-IP: [14.140.2.178] X-ClientProxiedBy: BMXPR01CA0004.INDPRD01.PROD.OUTLOOK.COM (10.174.214.142) To BN6PR07MB3058.namprd07.prod.outlook.com (10.172.106.140) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7f5ba0b6-4133-4d2e-85b8-08d4fe61846e X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:BN6PR07MB3058; X-Microsoft-Exchange-Diagnostics: 1; BN6PR07MB3058; 3:GTuSZxIasimuyf4A76HKRZjxdc/t4jjGIIzPo+E6wayu88VzChPmDLGveUK+SFf8IoFklw2XS7UttaBSEgIjhLts1Fozry/mXfi4jhC8BCgN0DSaSiIQyfxWZkdMlp2zzzE+OkoTKAp5qS4imBxIXOCKo6HhKvACEGTuCR5HxLBUsynyJo2R+ubqaUKsA0RL9Ey+8fBNFWXHE2RV3QIFCuP93NJVn3pbAKZQ+mox4eED0YlayBiblrTG28zHIInT; 25:N0pQROnNaSaFQiNnaXNIk031FhmeYtJI4r0JM9DTgDglgEshhDi4SEEH02Yj/DEfG5WMC3A1zmHTW0iSZf+NIBXRKOdgT7f8yKWSbGW1E+ugE+Gu35FAeDYaI3kZf+pgDXjAbddgkGqugGF3rEN9TElv7XturEGx2uFsoJSXOKoSSDUSkJDR8cyFN5uzuKPsTCmGvclNDwUd0imbmB+nu5dsvw6d8V0G63nHD/0aVjNqXlrsYki8AW7v5j/ramw1K/qMQoOUUMXmVBB2OGajNi3CM+pa8MlEpHladg/S5q16EpQ7eOI9so/+2Xkd9xmTake0aXfW41u/goIqRWvg6Q==; 31:AzV0XeI5XnbxbB80GKrdjp7gLspMUhJ7DNIv9cGKhl5R2ynyFgBipOxMH0yz8exAangbduUBjRxI09CYkWpLZjFT6B07gWhMbjGYtQ+Gju+FhlzyuccObaByzwBahM6JbbdS24GliY5/dMJSi//+zlR1LTruZ1N71TFGlEj+521VocMGWbherfPxkZgZU62syeXRy5dIquncPf5RjEo2hBsrIhmzDugQx6e2PWibPW0= X-MS-TrafficTypeDiagnostic: BN6PR07MB3058: X-Microsoft-Exchange-Diagnostics: 1; BN6PR07MB3058; 20:+VTk/gzJeC225j1+hxMJFrrL36I/3TIvz+J5d1tOLsiZzuXMJgEkgDgSJyk9Sb9kXiVxE0TqsEHWnPcmzXQoCb98CZxK8vzh8g/46l23bdjI5kJw+Dwcj17y4CWaCZDr46/sSYTJhK7WTtLjnJa7cC7LTtoZ/kiVAZQsbUo3BGM5rcNvUJ9lE2hz9eKlm3U4NWxoHczEFj5PsCt+/BrG7WhglWt3JwdTeXrx3NyNtBrU1CyYDWdKEe6KAHJ9F9pctH/WJWzys04YBBtzM1DwBgl4/WkTGhS5IDQt5viIlgfpUHHx1mU8Vuwupduk5VF9XjkxLQ9BVas9fvqFg3eJJWAJjKB3ThJAKMVGDdchVWWHkcU+4sQDqnyK5K5CyFIP/K39CFaHFXH/igbrAKnjgAdI+1+Ap6xGPQTpvDwO2114lgHfFGFEHWaNtsZXq+LGLH20th1VZMBTrQhyfTXhi59HrfzXXXHkYbdM31YbR8tBq9ciE+wLpJvhVO4zwNmhEek+tZuBHQLcQxRCpbQoqvFUwlppZ7+lpg0jOSpdpoUKIjROVjzt29Q8aVPjFZT4EyhkldZwocmpOej0vVu9UvOlNj+VpEH+O+80shn4Ynk= X-Exchange-Antispam-Report-Test: UriScan:(265634631926514)(228905959029699)(17755550239193); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(100000703101)(100105400095)(10201501046)(3002001)(93006095)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(20161123558100)(20161123555025)(20161123562025)(20161123560025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:BN6PR07MB3058; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:BN6PR07MB3058; X-Microsoft-Exchange-Diagnostics: 1; BN6PR07MB3058; 4:M3RsXULwocFnK9000KO+29TNbPiY82lP5s3LJmI3WDLLsH2qyC6JNmzVcVg1UThQNDE/GzDCm0VbRpz3onVO4W7HxpRuBWZA3kI/rPYlB0JwFy6CjJUcK1h+YwDtljVbzvqu397YveGytIBeNRYtOaw+FqgWCgCIFxmRgAX5H4hAyhzwYjh5w/jnC3wkT+bilBbX9o+O88amjDiePH7TUDje6H3IFcnOpQ+xB4gisgZ+6mt2rg1ieCF1udVwCODyBnwkz5X3/iYBhsnJkX4X+jnPhNiQwnTSwhjU2DMxLni4doW16uGg//7SWw8AlieCWr1LO0Kolyms+aIZxW9BkflLWsYqDKHPdJCW9HmkU1jdaCN+UPq3vO/N9Fzc18bU X-Forefront-PRVS: 04347F8039 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6069001)(6009001)(346002)(376002)(24454002)(13464003)(43544003)(199003)(189002)(377454003)(6246003)(5009440100003)(189998001)(33656002)(1076002)(50466002)(101416001)(2950100002)(42882006)(6116002)(105586002)(9686003)(6666003)(54906002)(3846002)(106356001)(55016002)(53936002)(2906002)(76176999)(54356999)(50986999)(23726003)(83506001)(305945005)(25786009)(7736002)(93886005)(8936002)(53546010)(66066001)(97736004)(478600001)(72206003)(47776003)(4326008)(81166006)(5660300001)(81156014)(229853002)(61506002)(16586007)(58126008)(16526017)(316002)(8676002)(68736007)(6506006)(110426004)(18370500001); DIR:OUT; SFP:1101; SCL:1; SRVR:BN6PR07MB3058; H:localhost.localdomain; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BN6PR07MB3058; 23:LtRc/EeN1KASTsnDrZn5SaPiGGvKgAPPkQDgrp2pV?= =?us-ascii?Q?JwSuusNbg54LaO5Pl3IEFp0m+GcENQcpuF3/WTM9xztjFR7PbsZdrPswW63I?= =?us-ascii?Q?yH/qNmUiiUc1EqZVgB/n3jb9XfIMmBp1TUYqsS8iJ7e1ySQEl6qG2vGuDk0U?= =?us-ascii?Q?nJWw/sq0lICcEd1Nl/Ybel900p0++bTRncrRNhKCts26SwspRtN8H5yAkm8p?= =?us-ascii?Q?eyfl2kenJ2l8yKOqUNnFLFVKIk56kBX6FxUmFN98OURTeXBDFpR/b1HoJ4UQ?= =?us-ascii?Q?c7q5V+jmqMvvX/JPbXQ5R6dmdF2d3G7LIckK+2VCeEAWpLJ21g6hbCYEwpDw?= =?us-ascii?Q?pea6z7Gd1mVtT4ZCLAMs3vxyemBS6OQ2sBtNhmXER62A+0bPRqjD9YLV/srd?= =?us-ascii?Q?fE7L/1Z+8NlSupcwvjrpVAY+iUwgmSX4ElA48w2feKbQcucUUlwt7ch/0e7j?= =?us-ascii?Q?xBzXNaCmuxtAzTUOYQOx+KSS43ay0mXnLyR9nnfq+MMUj+6tA8ORnQ01w1VG?= =?us-ascii?Q?n3kFsX6/wH2MsbPl2ytpSB5/NxVtXSZ1Ji4+r4bqY2DqHe8JFVa7lKchF0LD?= =?us-ascii?Q?wJJ+8PRTkFp2EPt7MJ5KDbgnps4H+1dwECGr1USh7Udmacm73Col0YzImoew?= =?us-ascii?Q?0fycIxAgBLCVysgNjU+9Od/jMYwTQ/QvkKS5/7fEmgd5fXuKQJm5xCBnYhVY?= =?us-ascii?Q?7r5fwThmgEQ/LLTetQN/ObgALekwD9hOkjCGbzxMXfUzRbqlHe6RiRNBd536?= =?us-ascii?Q?CXysbnoqdCNMoDgWnlRoJsZtBhumBuLnSavh/RZ0kKYFL5atWPZhWyieNwJH?= =?us-ascii?Q?JAg2ZgNzmKZZfVLdCJHp7wcYTcL7N4we/fMeiAwXVuXcBVYj37CLyZocKMGd?= =?us-ascii?Q?tDZAkf5YzqOnTRGPjkICNe4IZvjm4/MAWVXLH+Ug53wUbetMVQgNJOlwx7I3?= =?us-ascii?Q?LzUyrfPcKKtLqLRtbZq0KisFx/+VBlDcvRq1pCgPeF9rJBKhDYi4UsxGBwcs?= =?us-ascii?Q?3pRm8JN4YTVnEc2T4vstDn6ZLyhb5UCmJlG6BwGWTOnHYkhKnpc75lLR3j3A?= =?us-ascii?Q?qUxxlJawBCCegRf34Yc88vB/A8L8MejdVKbRHDy4pcf4goUS4DxRwqAgb/3a?= =?us-ascii?Q?QGg0dmYSLdH0V8/9txXiopJLDePPOlTVEDjh9hV8Jde3cSA8DTsRHHL8QYOg?= =?us-ascii?Q?+rvB+6PJFeomNmA2+j/Wm7uFYFQek1ZsbxcbpB0V/XdUOmbQl9q2ctFWKh5L?= =?us-ascii?Q?bFhzXTyxsFcfqSViq4mGJmPlVguwn+6pERaYLrnnXoIDra07BGOa1uwj+Vvd?= =?us-ascii?Q?n+zPRY544EwA835vfU0FkwAu4jSiXijwdcSDvOU9NNWmfjbYEirIjWE2Wfpi?= =?us-ascii?Q?xsHYj49pBqOapDwU/LeDmBelqtwBGbHDHg/sw632DTsf8Bi?= X-Microsoft-Exchange-Diagnostics: 1; BN6PR07MB3058; 6:JLcSNBBr8wBWOpfHqsp3qNoGdzypxUZqobHQpCxMyDutbcAjiFToZsLQZl+fVGhhFjWDECYlQT6z/FHSCOGEtP4+DelIQ3jm4vqlVxQgi+RGN3kyxFMVTiLZ/PZAFalocJDKHsLrRSb7pCnsGbOb84Udexy5ja4TUwmxDHf1b2h7xSMmI5LCWb4JDSiYLO9RZzIn8JQaDfQZq2KZ+chbKsYFdJek+edhbecttUAigwjY1WO2p1DFYDjjY4cAdO/ljaZ7bzsYJbyxJ3IQklwQXsyFMQd2YSYcJpeQ2sCv9cmODsEr1JsqrDkNgQQkfN/smVBk6yQrqeaIa4G03JbFfQ==; 5:DRDjdYRX1dDhxi4Cji+s73YwKQ7zAEZbqergaSCtp33BFOaUB8Kaj6DSFcaJH9TBMHZqnWxcAu9FI+m+PqRNNNur2N1+ugSeZ/4Yliy4GfKLpng1K4BoyNCQenckNNPLwuBetaaqBspYN5UZ61rT0Q==; 24:DXxH0HHZbnx/91oWIK664Nn6WFlJmnLK/uZ+ASkSgq6MxkV6eY+GCD9CoEFaIC/6Hrnwuepnop0CH9kF9jv4ZeA9/++hi3O38grhTZhBka4=; 7:RJ5uV2hUj0soCRitiBodOKaeSzB/hEWTVTm8oKelrkg5bVXBXReerIRXcGFBbCMMbpqKoijgOf/VUTGfB7xsFKtfQEfZzRl3UIJuUBdcXBE+u2JJk8FLkaQpRWBEYauRy5iGGNx5Ik587SK2C/hHCe4dy1MM4kViN4EzaAXEZYS+1aYfQZDOav7wqnNnzAwIYr0OVK5i6WfRylWjRhd0s1GXmKCjCf1hGMTmKwuIBk0= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Sep 2017 06:50:12.3669 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR07MB3058 Subject: Re: [dpdk-dev] vf init issue with patch igb_uio: issue FLR during open and release of device file X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Sep 2017 06:50:17 -0000 On Mon, Sep 18, 2017 at 03:50:30AM +0000, Yang, Qiming wrote: > Sorry, Gregory and Shijith > > I misunderstand your advice. > If we only remove PCI reset at igbuio_pci_open, not include igbuio_pci_release, I think it is a good solution. > It reserve the functional of this patch and we have test on FVL 10G/40G/25G, all work fine. > Thanks Qiming. Glad to hear that removing pci_reset_function from igbuio_pci_open fixed the issue for Intel NICs. Harish, Please let us know the behavior with QEDE. Reverting won't be necessary if the fix works for all. Thanks, Shijith > > -----Original Message----- > > From: Zhang, Helin > > Sent: Monday, September 18, 2017 10:39 AM > > To: Yang, Qiming ; Gregory Etelson > > ; thomas@monjalon.net > > Cc: dev@dpdk.org; Tan, Jianfeng ; Thotton, Shijith > > ; Hu, Xuekun ; Yigit, > > Ferruh ; Patil, Harish ; Li, > > Xiaoyun > > Subject: RE: [dpdk-dev] vf init issue with patch igb_uio: issue FLR during open > > and release of device file > > > > Hi guys > > > > May I suggest to revert the patch first, as it blocks existing functionalities. > > Then the original authors can add it back with a fix? > > > > Regards, > > Helin > > > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Yang, Qiming > > Sent: Monday, September 18, 2017 10:21 AM > > To: Gregory Etelson > > Cc: thomas@monjalon.net; dev@dpdk.org; Tan, Jianfeng > > ; Thotton, Shijith ; Hu, > > Xuekun ; Yigit, Ferruh ; Patil, > > Harish ; Li, Xiaoyun > > Subject: Re: [dpdk-dev] vf init issue with patch igb_uio: issue FLR during open > > and release of device file > > > > Yes, I have tried, and it works. But I think removing this function also makes the > > patch meaningless. > > > > Qiming > > From: Gregory Etelson [mailto:gregory@weka.io] > > Sent: Sunday, September 17, 2017 10:50 AM > > To: Yang, Qiming > > Cc: thomas@monjalon.net; dev@dpdk.org; Tan, Jianfeng > > ; Thotton, Shijith ; Hu, > > Xuekun ; Yigit, Ferruh ; Patil, > > Harish > > Subject: Re: [dpdk-dev] vf init issue with patch igb_uio: issue FLR during open > > and release of device file > > > > > > Hello Qiming, > > > > > > > > Did you try to remove PCI reset at igbuio_pci_open ? > > > > Reverting the patch entirely will get us back to VF issues > > > > > > > > Regards, > > > > Gregory > > > > > > > > > > > > On Friday, 15 September 2017 11:04:16 IDT Yang, Qiming wrote: > > > > > Hi, Thomas > > > > > We meet a urgent issue because of Shijith's patch. > > > > > When use DPDK version 17.08, DPDK VF driver and kernel PF driver, i40e, ixgbe > > and qede(Harish said) VF all meet initial failure. > > > > > This issue only occurred when use 17.08 igb_uio, vfio-pci and 17.05 igb_uio all > > works well. > > > > > Considering this issue will block our vf driver develop and test work, could we > > revert this patch first and find another appropriate way? > > > > > > > > > > Qiming > > > > > > > > > > > -----Original Message----- > > > > > > From: Patil, Harish [mailto:Harish.Patil@cavium.com] > > > > > > Sent: Thursday, September 14, 2017 3:45 AM > > > > > > To: Yigit, Ferruh >; > > Hu, Xuekun >; > > > > > > Thotton, Shijith > > >; Yang, > > Qiming > > > > > > >; Gregory Etelson > > > > > > > > > Cc: dev@dpdk.org; Tan, Jianfeng > > > > > > > > > Subject: Re: [dpdk-dev] vf init issue with patch igb_uio: issue FLR during open > > > > > > and release of device file > > > > > > > > > > > > > > > > > > > > > > > > -----Original Message----- > > > > > > From: dev > on > > behalf of Ferruh Yigit > > > > > > > > > > > > > Date: Wednesday, September 13, 2017 at 10:06 AM > > > > > > To: "Hu, Xuekun" >, > > "Thotton, Shijith" > > > > > > >, > > "Yang, Qiming" >, > > > > > > Gregory Etelson > > > > > > > Cc: "dev@dpdk.org" > > >, "Tan, Jianfeng" > > > > > > > > > Subject: Re: [dpdk-dev] vf init issue with patch igb_uio: issue FLR during open > > > > > > and release of device file > > > > > > > > > > > > >On 9/13/2017 3:25 PM, Hu, Xuekun wrote: > > > > > > >> I met the same issue too, only with i40e 2.1.26 PF kernel driver. > > > > > > >> > > > > > > >> -----Original Message----- > > > > > > >> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Ferruh Yigit > > > > > > >> Sent: Wednesday, September 13, 2017 7:04 PM > > > > > > >> To: Shijith Thotton > > > .com>>; Yang, > > > > > > >>Qiming >; > > Gregory Etelson > > > > > > > >> Cc: dev@dpdk.org; Tan, Jianfeng > > > > > > > > > >> Subject: Re: [dpdk-dev] vf init issue with patch igb_uio: issue FLR > > > > > > >>during open and release of device file > > > > > > >> > > > > > > >> On 9/13/2017 11:48 AM, Shijith Thotton wrote: > > > > > > >>> On Wed, Sep 13, 2017 at 07:51:30AM +0000, Yang, Qiming wrote: > > > > > > >>>> Hi, Shijith > > > > > > >>>> > > > > > > >>>> > > > > > > >>>> > > > > > > >>>> VF init error will happen after apply your patch, error log as > > > > > > >>>>below. If > > > > > > >>>> revert your commit, all things work well. And this issue is not > > > > > > >>>>only occur > > > > > > >>>> in i40 VF but also ixgbe. > > > > > > > > > > > > > >Hi Qiming, > > > > > > > > > > > > > >I can reproduce the issue for the case: > > > > > > > > > > > > > >1- i40e 2.1.26 PF kernel driver (NOT reproduced with 1.6.27-k) > > > > > > >2- DPDK app run on host, so both PF and VF are in host. Linux driver > > > > > > >for PF and DPDK for VF. (When VF used in a VM, Linux PF on host and > > > > > > >DPDK VF on guest, this works fine) > > > > > > > > > > > > > >And I confirm the function igbuio_pci_open() added with below patch is > > > > > > >causing it. > > > > > > > > > > > > > >igbuio_pci_open() does: > > > > > > > pci_reset_function(dev); > > > > > > > pci_set_master(dev); > > > > > > > > > > > > > >Don't know yet root cause of the error, will dig more. > > > > > > > > > > > > > >>>> > > > > > > >>>> Could you help to check it soon? > > > > > > >>>> > > > > > > >>>> > > > > > > >>>> > > > > > > >>>> [root@localhost app]# ./testpmd -c 7 -n 4 -- -i > > > > > > >>>> > > > > > > >>>> EAL: Detected 10 lcore(s) > > > > > > >>>> > > > > > > >>>> EAL: No free hugepages reported in hugepages-1048576kB > > > > > > >>>> > > > > > > >>>> EAL: Probing VFIO support... > > > > > > >>>> > > > > > > >>>> EAL: WARNING: cpu flags constant_tsc=yes nonstop_tsc=no -> using > > > > > > >>>> unreliable clock cycles ! > > > > > > >>>> > > > > > > >>>> EAL: PCI device 0000:00:03.0 on NUMA socket -1 > > > > > > >>>> > > > > > > >>>> EAL: Invalid NUMA socket, default to 0 > > > > > > >>>> > > > > > > >>>> EAL: probe driver: 8086:154c net_i40e_vf > > > > > > >>>> > > > > > > >>>> i40evf_init_vf(): init_adminq failed: -53 > > > > > > >>>> > > > > > > >>>> i40evf_dev_init(): Init vf failed > > > > > > >>>> > > > > > > >>>> EAL: Requested device 0000:00:03.0 cannot be used > > > > > > >>>> > > > > > > >>>> > > > > > > >>>> > > > > > > >>>> commit b58eedfc7dd57eef6d12e2c654a52c834f36084a > > > > > > >>>> Author: Shijith Thotton > > > .com>> > > > > > > >>>> Date: Fri Jul 7 16:43:51 2017 +0530 > > > > > > >>>> > > > > > > >>>> igb_uio: issue FLR during open and release of device file > > > > > > >>>> > > > > > > >>>> Set UIO info device file operations open and release. Call pci > > > > > > >>>>reset > > > > > > >>>> function inside open and release to clear device state at start > > > > > > >>>>and end. > > > > > > >>>> Copied this behaviour from vfio_pci kernel module code. With > > > > > > >>>>this patch, > > > > > > >>>> it is not mandatory to issue FLR by PMD's during init and close. > > > > > > >>>> > > > > > > >>>> Bus master enable and disable are added in open and release > > > > > > >>>>respectively > > > > > > >>>> to take care of device DMA. > > > > > > >>>> > > > > > > >>>> Signed-off-by: Shijith Thotton > > > .com>> > > > > > > >>>> Reviewed-by: Jianfeng Tan > > > > > > > > > >>>> Acked-by: Ferruh Yigit > > > > > > > > > >>>> Acked-by: Gregory Etelson > > > > > > > > > >>>> > > > > > > >>>> > > > > > > >>>> > > > > > > >>>> Best Regard, > > > > > > >>>> > > > > > > >>>> Yang Qiming > > > > > > >>>> > > > > > > >>>> > > > > > > >>> > > > > > > >>> Hi Yang Qiming, > > > > > > >>> > > > > > > >>> We didn't face this issue while preparing patch. I think, Gregory > > > > > > >>> tested it for Intel NICs. Adding more people to the loop for help. > > > > > > >>> > > > > > > >> > > > > > > >> I will try to reproduce the issue. > > > > > > >> > > > > > > >>> Shijith > > > > > > > > > > > > [Harish] We are seeing similar issue with the bringup of qede VF devices due > > to > > > > > > this patch. > > > > > > Could we revert this and leave it to individual PMDs to manage it? > > > > > > >> > > > > > > > > > > > > >