From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <gaetan.rivet@6wind.com>
Received: from mail-wm0-f54.google.com (mail-wm0-f54.google.com [74.125.82.54])
by dpdk.org (Postfix) with ESMTP id 920641AEEB
for <dev@dpdk.org>; Mon, 18 Sep 2017 13:37:24 +0200 (CEST)
Received: by mail-wm0-f54.google.com with SMTP id 13so1791302wmq.2
for <dev@dpdk.org>; Mon, 18 Sep 2017 04:37:24 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=6wind-com.20150623.gappssmtp.com; s=20150623;
h=date:from:to:cc:subject:message-id:references:mime-version
:content-disposition:content-transfer-encoding:in-reply-to
:user-agent; bh=06IbqRQv7GHo4AIyX+19KI39Wuq1gQleBMOaJai9TRA=;
b=K38UYbEMhMoKjwu6xXFzgeY9fgOu/kAU2hySjZSeQLPkLYfCRvxID8qqYSzcBnn/n+
lABh1HBjA7HY5FQkKkS+HmBoTJoMCyEpgGRYUx7YZ/gimHbMZe/gmBFvpHwNMx5lpSfi
ZOoql2cMuUoVb8OhoxLpIWoCBlM9ohQonpMT2n0ywST+Yh/IM3MNjddjxLhxsJ5nfPWa
VKvMajzHi5Hg4FPdEBXCVwU9iWP+0kdzLXTv+VQXGn2hlRyStjtTbhkOA0hjpel2zwvf
XoSHmdP8ypg5ritORRL1TzZDnYYgmxcbhnE3xRdBF1R905rAMm3UvNDpwws9YS6tjGa6
xNeA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:date:from:to:cc:subject:message-id:references
:mime-version:content-disposition:content-transfer-encoding
:in-reply-to:user-agent;
bh=06IbqRQv7GHo4AIyX+19KI39Wuq1gQleBMOaJai9TRA=;
b=UEI1vK+MDHycCCJ9OQMqah3jEqikb0LGPl8/DhzZbpRJF0ipZ2S5US1SlT2AKtQDTZ
lqH1hdQacsiT2vrePI/NYYsVZMPikmnVcPnp2y532xcsBX/QMSki5n4b236eMFYpVwrN
WXSJgcghinKc6uq/gyegfBuDPm94FVAUuJstezSp7h7rvg0de706rse6BLWJOn8MiOdf
nDEsoJkzseKwprl31qZChnijqKdDYPP8KCvWA8ezuzUOgOWjMlXHJ4CpFw501WxR6UtK
dkDN2xlERD/D0+JsX0MK653Xq8QIqsk3UF+ERDP0TkOYyyXxaLTBdz1WR21VreL+k7+B
jlvg==
X-Gm-Message-State: AHPjjUhTesbPLSq43OV2BSUoVPdddB00bHbugwUEGIxAaicwdvoiCg9V
poAMNrNvJey4CYZ7
X-Google-Smtp-Source: AOwi7QBrBM1m4aOSYT8vv0+u4hvbZfSsKrqacolK7LNhAoyzpWnGLHHCXSjSUXYFID9W1byw/BRLzA==
X-Received: by 10.28.135.5 with SMTP id j5mr9625001wmd.21.1505734643975;
Mon, 18 Sep 2017 04:37:23 -0700 (PDT)
Received: from bidouze.vm.6wind.com (host.78.145.23.62.rev.coltfrance.com.
[62.23.145.78])
by smtp.gmail.com with ESMTPSA id g13sm7293506wrg.63.2017.09.18.04.37.22
(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
Mon, 18 Sep 2017 04:37:23 -0700 (PDT)
Date: Mon, 18 Sep 2017 13:37:13 +0200
From: =?iso-8859-1?Q?Ga=EBtan?= Rivet <gaetan.rivet@6wind.com>
To: Shreyansh Jain <shreyansh.jain@nxp.com>
Cc: dev@dpdk.org
Message-ID: <20170918113713.GR21444@bidouze.vm.6wind.com>
References: <cover.1503651392.git.gaetan.rivet@6wind.com>
<cover.1505726803.git.gaetan.rivet@6wind.com>
<d50965340fd71c6556da620243b70d6d6263282d.1505726803.git.gaetan.rivet@6wind.com>
<53c6676d-14fe-7037-29db-ae3265257a82@nxp.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <53c6676d-14fe-7037-29db-ae3265257a82@nxp.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Subject: Re: [dpdk-dev] [PATCH v2 01/14] eal: expose rte_eal_using_phys_addrs
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 18 Sep 2017 11:37:24 -0000
On Mon, Sep 18, 2017 at 04:17:08PM +0530, Shreyansh Jain wrote:
> Hello Gaetan,
>
> On Monday 18 September 2017 03:01 PM, Gaetan Rivet wrote:
> >This function was previously private to the EAL layer.
> >Other subsystems requires it, such as the PCI bus.
> >
> >In order not to force other components to include stdbool, which is
> >incompatible with several NIC drivers, the return type has
> >been changed from bool to int.
> >
> >Signed-off-by: Gaetan Rivet <gaetan.rivet@6wind.com>
> >---
>
> [...]
>
> >diff --git a/lib/librte_eal/linuxapp/eal/eal_memory.c b/lib/librte_eal/linuxapp/eal/eal_memory.c
> >index 5279128..af8719b 100644
> >--- a/lib/librte_eal/linuxapp/eal/eal_memory.c
> >+++ b/lib/librte_eal/linuxapp/eal/eal_memory.c
> >@@ -1542,7 +1542,7 @@ rte_eal_hugepage_attach(void)
> > return -1;
> > }
> >-bool
> >+int
> > rte_eal_using_phys_addrs(void)
> > {
> > return phys_addrs_available;
> >diff --git a/lib/librte_eal/linuxapp/eal/rte_eal_version.map b/lib/librte_eal/linuxapp/eal/rte_eal_version.map
> >index 8c08b8d..f866b70 100644
> >--- a/lib/librte_eal/linuxapp/eal/rte_eal_version.map
> >+++ b/lib/librte_eal/linuxapp/eal/rte_eal_version.map
> >@@ -205,6 +205,7 @@ DPDK_17.08 {
>
> This symbol should be added to 17.11, isn't it?
>
Ah, yes indeed
> > rte_bus_find;
> > rte_bus_find_by_device;
> > rte_bus_find_by_name;
> >+ rte_eal_using_phys_addrs;
> > rte_log_get_level;
> > } DPDK_17.05;
> >
> -
> Shreyansh
--
Gaëtan Rivet
6WIND