From: Ajit Khaparde <ajit.khaparde@broadcom.com>
To: dev@dpdk.org
Cc: ferruh.yigit@intel.com
Subject: [dpdk-dev] [PATCH v2 12/19] net/bnxt: fix config rss update
Date: Mon, 18 Sep 2017 10:17:48 -0500 [thread overview]
Message-ID: <20170918151755.86605-13-ajit.khaparde@broadcom.com> (raw)
In-Reply-To: <20170918151755.86605-1-ajit.khaparde@broadcom.com>
We are not configuring the RSS settings updated by rss_hash_update().
Fix it.
Fixes: cc0aa1edc10 ("net/bnxt: add RSS hash configuration")
Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
---
drivers/net/bnxt/bnxt.h | 2 ++
drivers/net/bnxt/bnxt_ethdev.c | 4 ++++
drivers/net/bnxt/bnxt_rxq.c | 5 +++++
3 files changed, 11 insertions(+)
diff --git a/drivers/net/bnxt/bnxt.h b/drivers/net/bnxt/bnxt.h
index 405d94d..4a88210 100644
--- a/drivers/net/bnxt/bnxt.h
+++ b/drivers/net/bnxt/bnxt.h
@@ -176,6 +176,7 @@ struct bnxt {
void *bar0;
struct rte_eth_dev *eth_dev;
+ struct rte_eth_rss_conf rss_conf;
struct rte_pci_device *pdev;
uint32_t flags;
@@ -184,6 +185,7 @@ struct bnxt {
#define BNXT_FLAG_PORT_STATS (1 << 2)
#define BNXT_FLAG_JUMBO (1 << 3)
#define BNXT_FLAG_SHORT_CMD (1 << 4)
+#define BNXT_FLAG_UPDATE_HASH (1 << 5)
#define BNXT_PF(bp) (!((bp)->flags & BNXT_FLAG_VF))
#define BNXT_VF(bp) ((bp)->flags & BNXT_FLAG_VF)
#define BNXT_NPAR_ENABLED(bp) ((bp)->port_partition_type)
diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c
index 6eed19c..48e18ff 100644
--- a/drivers/net/bnxt/bnxt_ethdev.c
+++ b/drivers/net/bnxt/bnxt_ethdev.c
@@ -832,6 +832,10 @@ static int bnxt_rss_hash_update_op(struct rte_eth_dev *eth_dev,
if (rss_conf->rss_hf & BNXT_ETH_RSS_SUPPORT)
return -EINVAL;
}
+
+ bp->flags |= BNXT_FLAG_UPDATE_HASH;
+ memcpy(&bp->rss_conf, rss_conf, sizeof(*rss_conf));
+
if (rss_conf->rss_hf & ETH_RSS_IPV4)
hash_type |= HWRM_VNIC_RSS_CFG_INPUT_HASH_TYPE_IPV4;
if (rss_conf->rss_hf & ETH_RSS_NONFRAG_IPV4_TCP)
diff --git a/drivers/net/bnxt/bnxt_rxq.c b/drivers/net/bnxt/bnxt_rxq.c
index bae16da..0ae7da5 100644
--- a/drivers/net/bnxt/bnxt_rxq.c
+++ b/drivers/net/bnxt/bnxt_rxq.c
@@ -189,6 +189,11 @@ int bnxt_mq_rx_configure(struct bnxt *bp)
struct rte_eth_rss_conf *rss = &dev_conf->rx_adv_conf.rss_conf;
uint16_t hash_type = 0;
+ if (bp->flags & BNXT_FLAG_UPDATE_HASH) {
+ rss = &bp->rss_conf;
+ bp->flags &= ~BNXT_FLAG_UPDATE_HASH;
+ }
+
if (rss->rss_hf & ETH_RSS_IPV4)
hash_type |= HWRM_VNIC_RSS_CFG_INPUT_HASH_TYPE_IPV4;
if (rss->rss_hf & ETH_RSS_NONFRAG_IPV4_TCP)
--
2.10.1 (Apple Git-78)
next prev parent reply other threads:[~2017-09-18 15:18 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-18 15:17 [dpdk-dev] [PATCH v2 00/19] bnxt patch set Ajit Khaparde
2017-09-18 15:17 ` [dpdk-dev] [PATCH v2 01/19] net/bnxt: fix HWRM_*() macros and locking Ajit Khaparde
2017-09-18 15:17 ` [dpdk-dev] [PATCH v2 02/19] net/bnxt: use 64-bits of address for vlan_table Ajit Khaparde
2017-09-18 15:17 ` [dpdk-dev] [PATCH v2 03/19] net/bnxt: fix an issue with group id calculation Ajit Khaparde
2017-09-18 15:17 ` [dpdk-dev] [PATCH v2 04/19] net/bnxt: fix calculation of number of pools Ajit Khaparde
2017-09-18 15:17 ` [dpdk-dev] [PATCH v2 05/19] net/bnxt: handle multi queue mode properly Ajit Khaparde
2017-09-18 15:17 ` [dpdk-dev] [PATCH v2 06/19] net/bnxt: fix rx handling and buffer allocation logic Ajit Khaparde
2017-09-18 15:17 ` [dpdk-dev] [PATCH v2 07/19] net/bnxt: fix an issue with broadcast traffic Ajit Khaparde
2017-09-18 15:17 ` [dpdk-dev] [PATCH v2 08/19] net/bnxt: fix usage of ETH_VMDQ_* flags Ajit Khaparde
2017-09-18 15:17 ` [dpdk-dev] [PATCH v2 09/19] net/bnxt: set checksum offload flags correctly Ajit Khaparde
2017-09-18 15:17 ` [dpdk-dev] [PATCH v2 10/19] net/bnxt: update status of Rx IP/L4 CKSUM Ajit Khaparde
2017-09-18 15:17 ` [dpdk-dev] [PATCH v2 11/19] net/bnxt: add support for xstats get by id Ajit Khaparde
2017-09-19 12:39 ` Ferruh Yigit
2017-09-18 15:17 ` Ajit Khaparde [this message]
2017-09-18 15:17 ` [dpdk-dev] [PATCH v2 13/19] net/bnxt: set the hash_key_size Ajit Khaparde
2017-09-18 15:17 ` [dpdk-dev] [PATCH v2 14/19] net/bnxt: add support for rx_queue_count Ajit Khaparde
2017-09-18 15:17 ` [dpdk-dev] [PATCH v2 15/19] net/bnxt: add support for rx_descriptor_status Ajit Khaparde
2017-09-18 15:17 ` [dpdk-dev] [PATCH v2 16/19] net/bnxt: add support for tx_descriptor_status Ajit Khaparde
2017-09-18 15:17 ` [dpdk-dev] [PATCH v2 17/19] net/bnxt: add new HWRM structs to support flow filtering Ajit Khaparde
2017-09-18 15:17 ` [dpdk-dev] [PATCH v2 18/19] net/bnxt: add support for flow filter ops Ajit Khaparde
2017-09-19 12:38 ` Ferruh Yigit
2017-09-18 15:17 ` [dpdk-dev] [PATCH v2 19/19] doc: update release notes Ajit Khaparde
2017-09-18 18:46 ` Mcnamara, John
2017-09-19 12:39 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170918151755.86605-13-ajit.khaparde@broadcom.com \
--to=ajit.khaparde@broadcom.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).