From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <Shijith.Thotton@cavium.com>
Received: from NAM01-BY2-obe.outbound.protection.outlook.com
(mail-by2nam01on0081.outbound.protection.outlook.com [104.47.34.81])
by dpdk.org (Postfix) with ESMTP id B0C99101B
for <dev@dpdk.org>; Tue, 19 Sep 2017 08:45:39 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version;
bh=t3fAMLdEKEbI501xnxOGc8P1QDOeo6qc2buPGpnbgZ4=;
b=iaRCOK37uiX8GUdNVfFQ73QGQw6KMiLOAzg/8R7fmqf/AwnAFBwuIlw6Ojdzityl86NWFHzkijfsEjP4gN1tMoRbaJR4nA0qJTKAh+1NGSl9BdkcyyNskwdNSQ1svTGkC8CDHDIqkG3osuwA+JIGmAGCGqe8lJAhkap0goieuvY=
Authentication-Results: spf=none (sender IP is )
smtp.mailfrom=Shijith.Thotton@cavium.com;
Received: from localhost.localdomain (14.140.2.178) by
CY4PR07MB3064.namprd07.prod.outlook.com (10.172.116.145) with Microsoft SMTP
Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id
15.20.56.11; Tue, 19 Sep 2017 06:45:35 +0000
Date: Tue, 19 Sep 2017 12:15:20 +0530
From: Shijith Thotton <shijith.thotton@caviumnetworks.com>
To: Yong Wang <wang.yong19@zte.com.cn>
Cc: shijith.thotton@cavium.com, dev@dpdk.org
Message-ID: <20170919064519.GA18600@localhost.localdomain>
References: <1505476108-11005-1-git-send-email-wang.yong19@zte.com.cn>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1505476108-11005-1-git-send-email-wang.yong19@zte.com.cn>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-Originating-IP: [14.140.2.178]
X-ClientProxiedBy: PN1PR01CA0097.INDPRD01.PROD.OUTLOOK.COM (10.174.144.13) To
CY4PR07MB3064.namprd07.prod.outlook.com (10.172.116.145)
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 81e51904-0570-41f7-9973-08d4ff2a08d3
X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0;
RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);
SRVR:CY4PR07MB3064;
X-Microsoft-Exchange-Diagnostics: 1; CY4PR07MB3064;
3:ymT7GtPkJQlocrjjM1G7JI4Hc2HrfAPKQwOPeURvz5M37YtV9tXJFl87Vg9lQj6Z6Jav0IGTLronWeD5k9NnTVn+Ln372TTjRKFlFsNR5vqwplqlzvMxKmN+f7AkMeuITu3Muoi3a4DRPpQ4znI/kDcquUxrWxoZ5H8mEtp78XE41mDnYchjblzqUe1D48AnagCjopjzWQw5TENwjjeFfLhP48bWZCcEvlpabVSp0VvL0US/Vdjinnj8v37FrdT1;
25:DnS333KK7DIK52/x/6NVBFTAaH6qpUdf0s73WkwxmPcLSN1qFRn5SI8ToHJTA8BJ6+HIb6Pzko+eje3Yg0V+0OSfPmaEBMoDRp7mVAHWPXFhDIKT04rNAhLRMXsfsQfqjMAuBx0QSuRWzSl6/5mPDq4/bom2Hl7C1gffa+5XDl4lhmlzGud+IMMJufqMO2fD/W0BHPtRe90/02YSjX+f/DcyFeRzkPtaU/oIYCG+fmSwK4hd9uoji1e1yr+90m9a3qO+wK4Shxcx/0Ef0tEtWvHcWRMEVzmP4B7Y+1LjiagHpik7OUp7CrVVXeCll0BXtu+T+Ab2RqZoOecToNjkcg==;
31:njROPn6z4GIwMxnXiMx1s0e0cYxgE5ZrmPzV63vIdtJCIEfsfXGjkQsktLd/b4+g8IRMS/sgsJqZXBIa6rE7SB/wtG9fBhdfc9YoOoIRql2kodufN27rlkVLWSx1lD0CnU1TiUKuvxWNwFp6lm6QKrL8TQiFO1x34mJ/VnGI45oyONnLaYUj1amTsscWCAyXmRClUtIW5UXGKB2NpdywsU31mHB+sc+8RrN/3cBilOk=
X-MS-TrafficTypeDiagnostic: CY4PR07MB3064:
X-Microsoft-Exchange-Diagnostics: 1; CY4PR07MB3064;
20:anTxgpoqux85jDZF1CU7qlmlixXJwOnMhNcycq1R/TXDjrW1Kli+pDqM1RqlvuEsM3xaL82ihh9F8jlNXrryYCLa/bjIZnVHnc9adbElRDyNeElAUhAzuNfv1k7oGpHhxeskl0c7n15UMNl47Iu2BnLWh/ZzSDvsNeteRrlj93WSdRshjqttKxNZsakb65h0bAtZsgm7pyk+xZ2973P6XBuIIvXknHxYm2X0fdXecufpUHUDCE+yqhQ/OZynvy0ayKiUdY3sQlnb9RJbKC/9UXqvPNXInmzxfQjJos3JXMAeX1ckhJ2t3pn0YUbD15XGRTjePHiSowuCdsPEyg9WllQHp4ALH9XJwn+BDd5boy11Ol0fB+9zMiGH2w6wOfFITlbbcwktlwU7lOH4HlwCXan3Z97aqjBoPQm7pyCx3k37CgGIZDN9nugVQuweCwdaLS8CiX1YtIQwVmZpOUVYl+FkPlYn3q9w0QcmeYQwJDtErKHoj5cwgUiXqoFdse+dzZcZQPoRNyt+Vt+hTV1VrUKOlsfmW81tQsz1Odmy214/XKQcJahR7RRAOoWkI0WFCezF27hhUAWaob6aOTB769bH/r5m/vEe4/+0VrH8HSA=;
4:RDPFwzdr/uU36Y4f4D/AOfJGt/izLcquBL8/mro4jtibq9QhwnriCkS+/1ldVXAVvBf+wqfm3jaMVXxGVEDiXc+kgaQKFS9+8fInlVPihg18gon1lF+xP+lLCSakRIEa3xVjr1JpuI4MgxU8xIizawYT+mj5wvhbHb10tesJglSvKqGHDLHqjgXAKwnGDuvzuHoXBhmpgSuN8nA8tMwcA0PDls8iklOKYEh7XQEekv4ynsxU5VxXYuV8SzG98Qb3
X-Exchange-Antispam-Report-Test: UriScan:;
X-Microsoft-Antispam-PRVS: <CY4PR07MB30640574DC36A9D799D9124281600@CY4PR07MB3064.namprd07.prod.outlook.com>
X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0;
RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(10201501046)(3002001)(100000703101)(100105400095)(93006095)(6041248)(20161123555025)(20161123560025)(20161123564025)(20161123558100)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);
SRVR:CY4PR07MB3064; BCL:0; PCL:0;
RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);
SRVR:CY4PR07MB3064;
X-Forefront-PRVS: 04359FAD81
X-Forefront-Antispam-Report: SFV:NSPM;
SFS:(10009020)(6069001)(6009001)(346002)(376002)(199003)(189002)(24454002)(6666003)(42882006)(6116002)(478600001)(316002)(16526017)(6916009)(1076002)(81166006)(5009440100003)(2950100002)(83506001)(58126008)(16586007)(53936002)(72206003)(9686003)(23726003)(68736007)(2906002)(229853002)(6246003)(97736004)(25786009)(5660300001)(3846002)(47776003)(50466002)(189998001)(8936002)(6506006)(50986999)(305945005)(106356001)(54356999)(7736002)(33656002)(55016002)(8676002)(4326008)(76176999)(105586002)(101416001)(81156014)(61506002)(66066001)(110426004)(18370500001);
DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR07MB3064; H:localhost.localdomain; FPR:;
SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en;
Received-SPF: None (protection.outlook.com: cavium.com does not designate
permitted sender hosts)
X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CY4PR07MB3064;
23:yZVKpyie523Cub/u6sh1Zhnabgp2UeiBczRnTu5ZZ?=
=?us-ascii?Q?QYQrBe4YAkumOXQwk2X1rZviL+5dkj74CqDa8NdjqhS20hOiY8RFpqYnUXYS?=
=?us-ascii?Q?wVI5g779cHEvVTCbXtp+7sjwbHAdi8jQXGN7W5Xvim/02H11PpMEkKx5YYwS?=
=?us-ascii?Q?7luxWti4kJztDpBd4OfftZFjkcCu5aMS5Pt/YMstsVfgO0etUrwBGA81zIl5?=
=?us-ascii?Q?j/+9GoI2S/kvWmi2sRC2TW/0EoU1Q6C9s7xeTzzaJvZ3QzTvuLG1Fy7XJjML?=
=?us-ascii?Q?JUPDj2hJ1nOJZh6sGRn8s46jXEmMgd/XSWNHStMccUrMKOdiuoTkaQH2y9ga?=
=?us-ascii?Q?gG6Cdhi1rvNNYj1IooV7UYkuVkxuv+O/jCVaZCIAcqjvSz2e86X5slLszMLD?=
=?us-ascii?Q?rwNk8MQL9vi6cnzsSiVAUXeENyxIz2sKpsXnJKlbqhkHotEEsW5dcNw/vhTg?=
=?us-ascii?Q?jrZB+P7dYisdG7FxPCDPRMgG+hdmaK3P1Blj3xk7tNSPMu3p37YX1fDa5vKp?=
=?us-ascii?Q?BXqjTafoD40hGWDPbqABnC5gvwYjZ92r0Il0YpR04wOEI6v6dfbQxUnKr3er?=
=?us-ascii?Q?muE3F3H/reNLM/hq/WNDCWrEBZYcY+6uHQU+A1l3YCf2ZuZqMWKk6CcjHu9k?=
=?us-ascii?Q?uIZ3kwENIhM6kLGYdjTGuP45qtSvpLnOWVwbh90vayLgnifye6IuH4M+N+ix?=
=?us-ascii?Q?W98236yLcoJC1Z5Vrb5BNLUBTqHPhFXwUmZbnSR8n5DGFVQMG382JYzKfwhy?=
=?us-ascii?Q?QkyFU1l1z10XRRLJ3czV/DDn+MzRo7ZNY14udihj/rX9Lg5dZtSIAu39bR9e?=
=?us-ascii?Q?iDRNPa0BioAAkOjvVUoJOR3mjrYtJEMRMmPU91ax9mkRDbThXb8r7Gi0bIHh?=
=?us-ascii?Q?s0PdBdiop3sUaRK6F+NV9S3Mi/FLfnOOj6PEQDlg26EBHucCdnLqcBzPbB4w?=
=?us-ascii?Q?j5VVw2iEpPKa8+hQFHk0lKfUUmgNyImMRfK0p2nz+2YKPTKeoMAf1kS4txuV?=
=?us-ascii?Q?OL41LYnnPTLpdWfbfnpUfqsrD+4NbhLmThKZw7ZjvphWxH/cB2GObCWYkw6x?=
=?us-ascii?Q?5eLeprNY+8T3h/oW4xRV+HvmnHAy4NGxnxBtZliMeFQO3+JtCa6KYSMT0wlz?=
=?us-ascii?Q?jtSU1KfleAszUf8Tqlh2hKAk+DX4bRkCEZ/H2l9+plrX4673a7cTkgBNBUBl?=
=?us-ascii?Q?ZlRyuW+G/+Ug6TIsfntLZEQQlo2l2NsxIGiLrP/xMcl0m/tNbvwXn97GPYFy?=
=?us-ascii?Q?PqzNs6+DDp3ABfL5xmxylPJShvYuPn4azsyEYkp?=
X-Microsoft-Exchange-Diagnostics: 1; CY4PR07MB3064;
6:9aw8rK30Mr32Qj6tq3B0JtwGDKUKv/DioTHVsoUn80LyeytgwvHjXK/Cq25McbsPmhAIqjSRGp/4RE0GwUsy2+vFyhehWlTntYNigURHx75zDKog10xN4WMRavSxWo2t4IzUXuROsvt0HLUbqjIepReZpzezb5Jd/M373S+KSszCNbj82Fd0IPjss0zVvbwL3uc/eL0l7AVMUiYUmyJtwGB8+RNHKaq0vEcOrfNtcZ8U5zWC4tm9rh12sB5anSqr3XBB12v+7B3ByS+pO/DBZAiySqCkq+D56wNlRIG+CgJA8Q5g7YlkcueDTvf+z0GuJFBAsXOURXdKk3nMtNXl+A==;
5:Oje69qcg3M4MFRYkvI8oeZoUQSxBYoOQT4zS7e5r6NpTmS6FcesnCo5HvD6YHWyLHzPkQBPfCQSsi2MnL4wCqvjCu8fNHS5kyTD4gYXJ3TG8xRF/EwcHvsje3s7EGkOGCHLG8JqQUg1YO+qUjxVbxg==;
24:G//dpD4uXgqe+ugvS8TdItOudHONiD8GqAW3xIKMdKNYbgS2bRXCQOeR8vpNFy3wM4bvZlQIXvbGkhb+PmNomQ/pKj3PpEtLm+VDp/SWfCo=;
7:Os1MXoqHHjItIwoqAy4UpnXRGqZWQJBodMPihhRcl8s0BNGGXXAsNNbXTyVV+IUt/3Ey8b1muHe6KHuskwQTzgLoTe3uHi5AubdO6JCXk+F/XBsCBGYCgrp74ZAD2S38knTM9Tf0KI04g/hj+bmLSBmjrSh3SQOzMGJS1MR+XGh6GSNks1avd8lYIZWfmfqkxRlADC7mtAJjVZ7yKCkCNCs2/NY6Vx0t+kLOuBwkf/E=
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-OriginatorOrg: caviumnetworks.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Sep 2017 06:45:35.2914 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR07MB3064
Subject: Re: [dpdk-dev] [PATCH v2] net/liquidio: fix uninitialized variable
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 19 Sep 2017 06:45:40 -0000
On Fri, Sep 15, 2017 at 07:48:28AM -0400, Yong Wang wrote:
> In func lio_dev_link_update(), "link.link_autoneg" is used in func call
> lio_dev_atomic_write_link_status(), but is uninitialized.
>
> v2:
> * Modify the initial value of 'link.link_autoneg' from 'ETH_LINK_FIXED'
> to 'ETH_LINK_AUTONEG'.
>
> Signed-off-by: Yong Wang <wang.yong19@zte.com.cn>
Acked-by: Shijith Thotton <shijith.thotton@caviumnetworks.com>
> ---
> drivers/net/liquidio/lio_ethdev.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/liquidio/lio_ethdev.c b/drivers/net/liquidio/lio_ethdev.c
> index 479936a..30119d2 100644
> --- a/drivers/net/liquidio/lio_ethdev.c
> +++ b/drivers/net/liquidio/lio_ethdev.c
> @@ -939,6 +939,7 @@ struct rte_lio_xstats_name_off {
> link.link_status = ETH_LINK_DOWN;
> link.link_speed = ETH_SPEED_NUM_NONE;
> link.link_duplex = ETH_LINK_HALF_DUPLEX;
> + link.link_autoneg = ETH_LINK_AUTONEG;
> memset(&old, 0, sizeof(old));
>
> /* Return what we found */
> --
> 1.8.3.1
>