Re: [dpdk-dev] [PATCH v2 1/3] eal: move bitmap from lib sched

[Pavan Nikhilesh Bhagavatula <pbhagavatula@caviumnetworks.com>]

On Wed, Sep 20, 2017 at 04:39:22PM +0000, Dumitrescu, Cristian wrote:
>
>
> > -----Original Message-----
> > From: Pavan Nikhilesh Bhagavatula
> > [mailto:pbhagavatula@caviumnetworks.com]
> > Sent: Wednesday, September 20, 2017 4:45 PM
> > To: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>;
> > stephen@networkplumber.org
> > Cc: dev@dpdk.org
> > Subject: Re: [dpdk-dev] [PATCH v2 1/3] eal: move bitmap from lib sched
> >
> > On Wed, Sep 20, 2017 at 03:40:46PM +0000, Dumitrescu, Cristian wrote:
> > >
> > >
> > > > -----Original Message-----
> > > > From: Pavan Nikhilesh [mailto:pbhagavatula@caviumnetworks.com]
> > > > Sent: Wednesday, September 20, 2017 4:37 PM
> > > > To: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>;
> > > > stephen@networkplumber.org
> > > > Cc: dev@dpdk.org; Pavan Bhagavatula
> > > > <pbhagavatula@caviumnetworks.com>
> > > > Subject: [dpdk-dev] [PATCH v2 1/3] eal: move bitmap from lib sched
> > > >
> > > > From: Pavan Bhagavatula <pbhagavatula@caviumnetworks.com>
> > > >
> > > > The librte_sched uses rte_bitmap to manage large arrays of bits in an
> > > > optimized method so, moving it to eal/common would allow other
> > libraries
> > > > and applications to use it.
> > > >
> > > > Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> > > > ---
> > > >
> > > > v2 changes:
> > > >  - undo rte_bitmap.h cosmetic changes
> > > >  - update maintainer info
> > > >
> > > >  lib/librte_eal/common/Makefile                               | 1 +
> > > >  lib/{librte_sched => librte_eal/common/include}/rte_bitmap.h | 0
> > > >  lib/librte_sched/Makefile                                    | 5 +++--
> > > >  lib/librte_sched/rte_sched.c                                 | 2 +-
> > > >  4 files changed, 5 insertions(+), 3 deletions(-)
> > > >  rename lib/{librte_sched => librte_eal/common/include}/rte_bitmap.h
> > > > (100%)
> > > >
> > >
> > > You say (in the change log) that you did it, but you forgot to add
> > MAINTAINERS file changes to your patch
> >
> > addressed in the 3rd patch of the patchset
> > http://dpdk.org/dev/patchwork/patch/29037/
>
> Oh, yes, you're right, sorry.
>

No problem! :)